From nobody Fri Sep 08 22:09:20 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Rj9Jq11vLz4sRdF; Fri, 8 Sep 2023 22:10:03 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-yw1-x1131.google.com (mail-yw1-x1131.google.com [IPv6:2607:f8b0:4864:20::1131]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Rj9Jp6HrRz3WVl; Fri, 8 Sep 2023 22:10:02 +0000 (UTC) (envelope-from mavbsd@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-yw1-x1131.google.com with SMTP id 00721157ae682-5924093a9b2so25118047b3.2; Fri, 08 Sep 2023 15:10:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694211001; x=1694815801; darn=freebsd.org; h=content-transfer-encoding:in-reply-to:subject:from:references:cc:to :content-language:user-agent:mime-version:date:message-id:sender :from:to:cc:subject:date:message-id:reply-to; bh=rWBcnRs5Wav0FBJFlqfy4EcvCQStG37/cpDo/kq1GZc=; b=Bs4Csdb0qBE+PRhk91BZf052zY+P9xpBVhB2zAUrcezDaNoqcg0y1oTZnInG8BpmZO 4r8HI4I/dQo1jhTQYJy+bbhuSPMrgCeIrlmGf5rI4iA/XkX4khhM8vydgXuVlhyPDp6t teJESr595Y0KlOLGwLU088vkf6gqIwz592AxEuFWVNW3K8cfdOeyzW6g1dCdCLDR2RP3 6OlwtF2FZY6jOCKYX+e8EUscI33+hYPyNJiNnLpunQUgbW/hFj2vtFBNflyOJsARhBkf a681fxyuX7Lot/SVA4niRCZjbyGUBRZW8IZkL313vnHB7OzQXNJIANJ7pOT0M05C78NN 5HNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694211001; x=1694815801; h=content-transfer-encoding:in-reply-to:subject:from:references:cc:to :content-language:user-agent:mime-version:date:message-id:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rWBcnRs5Wav0FBJFlqfy4EcvCQStG37/cpDo/kq1GZc=; b=ohxKn4WjdOYE0dGZYuRXbcA3OqYc6ikzV1oPVWNHy33qX5v1JormXDteycyUSBITeA X2CTTZkDW6Bpsmo/Ds991rlAWrL8Rto22EpRSuXTUIp0lNXwTVh2W/ZX+Y4BuRrYdGet 7TXHo0h4GL23ryHmLkV8a91Qvor0o0BY2k4HXjx95Mp5M2DrXVXiCJvniUGowvDN9ak5 UpNM1I8uRdVryk0grj4RVglVYqVTixwJy7pfnB96doJg72iJVrv21T8iFlYu8yJiCDLe +VTQXLP0FNG3gzRj15330tJR2GQmo/RoNIsIQg94n+I0PiXD9miCRO5VGeUFhx++3rnG GoIw== X-Gm-Message-State: AOJu0Yy50c1YIau5nDs7BWNoDfm8E9Ut42K/pEFhOB6bys3xJw9kYKSk 9nEHupKEWkF5aLhxnDRsVxaCbTLrjcQNjQ== X-Google-Smtp-Source: AGHT+IGok/kyWyNBPq7I2HyFBtDAgA5PcnpedWXw0CYb9a7rTLn+MWnnHjhT9Q025JNrmYsERzmHoA== X-Received: by 2002:a0d:ea0b:0:b0:57a:3dd8:1038 with SMTP id t11-20020a0dea0b000000b0057a3dd81038mr4089938ywe.12.1694211001386; Fri, 08 Sep 2023 15:10:01 -0700 (PDT) Received: from [10.230.45.5] ([38.32.73.2]) by smtp.gmail.com with ESMTPSA id h6-20020a0df706000000b0058c55d40765sm639106ywf.106.2023.09.08.15.10.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Sep 2023 15:10:00 -0700 (PDT) Message-ID: <2a25427c-5a61-3f72-4e31-b7666741d38d@FreeBSD.org> Date: Fri, 8 Sep 2023 18:09:20 -0400 List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Content-Language: en-US To: Martin Matuska , Mark Millard , Glen Barber Cc: Current FreeBSD , FreeBSD-STABLE Mailing List , Pawel Jakub Dawidek References: <7CE2CAAF-8BB0-4422-B194-4A6B0A4BC12C@yahoo.com> <08B7E72B-78F1-4ACA-B09D-E8C34BCE2335@yahoo.com> <20230907184823.GC4090@FreeBSD.org> <4f4e2b68-57e0-a475-e2bd-1f2b8844ebfe@FreeBSD.org> <354C5B8C-4216-4171-B8C2-8E827817F8E5@yahoo.com> <8B8B3707-4B37-4621-8124-D6A77CAF6879@yahoo.com> <15df58d3-4603-132f-112e-d10a6d4419bf@FreeBSD.org> From: Alexander Motin Subject: Re: main [and, likely, stable/14]: do not set vfs.zfs.bclone_enabled=1 with that zpool feature enabled because it still leads to panics In-Reply-To: <15df58d3-4603-132f-112e-d10a6d4419bf@FreeBSD.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4Rj9Jp6HrRz3WVl On 08.09.2023 09:52, Martin Matuska wrote: > I digged a little and was able to reproduce the panic without poudriere > with a shell script. > > #!/bin/sh > nl=' > ' > sed_script=s/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb/ > for ac_i in 1 2 3 4 5 6 7; do >     sed_script="$sed_script$nl$sed_script" > done > echo "$sed_script" 2>/dev/null | sed 99q >conftest.sed > > repeats=8 > count=0 > echo -n 0123456789 >"conftest.in" > while : > do >     cat "conftest.in" "conftest.in" >"conftest.tmp" >     mv "conftest.tmp" "conftest.in" >     cp "conftest.in" "conftest.nl" >     echo '' >> "conftest.nl" >     sed -f conftest.sed < "conftest.nl" >"conftest.out" 2>/dev/null || > break >     diff "conftest.out" "conftest.nl" >/dev/null 2>&1 || break >     count=$(($count + 1)) >     echo "count: $count" >     # 10*(2^10) chars as input seems more than enough >     test $count -gt $repeats && break > done > rm -f conftest.in conftest.tmp conftest.nl conftest.out Thank you, Martin. I was able to reproduce the issue with your script and found the cause. I first though the issue is triggered by the `cp`, but it appeared to be triggered by `cat`. It also got copy_file_range() support, but later than `cp`. That is probably why it slipped through testing. This patch fixes it for me: https://github.com/openzfs/zfs/pull/15251 . Mark, could you please try the patch? -- Alexander Motin