From nobody Thu Nov 23 16:56:05 2023 X-Original-To: current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SbklW0Jmrz51ypV for ; Thu, 23 Nov 2023 16:56:07 +0000 (UTC) (envelope-from mhorne@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SbklV6vX0z4f51; Thu, 23 Nov 2023 16:56:06 +0000 (UTC) (envelope-from mhorne@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1700758567; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=fwAbmcEsXNt11mvKJR9NsoZ5P58xm5Yvt96il3wovmM=; b=Mu05iuwc8YQL9GLbr5j67DUm/h9OeOJDO6YJx4Ia+UAcsKTqJH0a3FiOTyyGhJ8rhoA+26 Ir9LdFViNQBWv3iyqH3xfNfNC+B9YZ55s1HH0I/Iw2ibbiG12zH92nUGZ20KmYRwW+dDeB El4UWS9YZJwqj/bCZsTZxmTVCuSAmJqQ/GYIlw6hAi4oqOzmtA3c1PUdQqpbBxaA8zVxgB ef+F2gsCVaQZpN1ZzoE9vbOxj4mysd6e2GwdEKXZP1bvYR88mYrmcTL+HZLxFaq4CEDVD1 x13ayWJ2c65Mu7vZJmYFnYVZvoj03TPj39xKRVd8WX0PAV+Gf2f5iHCmsljdDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1700758567; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=fwAbmcEsXNt11mvKJR9NsoZ5P58xm5Yvt96il3wovmM=; b=EC1QonCaAYTZEVFE5LbMezvbLO2ifirEFgaSepvwB9gAekX4in49FbtXEJMTy0SOCUGoTg teNPj65n2/dsh6oRmYfhQ8O/tUO0HjrWnaQzcXIOQnTEz1t+IHIECqI4xhRiif2nJCTwW4 uXGQtAGNiQxRVxSi/sVEMV/Qyrm/3NcQUxDVYzBI/UobSlDz0SCjTuoFEZmb6u4y0E4g7E zsAdifpR6NwQru+OHquJUUvPB630XaxF47FIMbf81spJUdd6WbV8RxdS4MsZI4ob1XFbGy H57PUAIsWuHTgZnzR34z2IuLr9ytlVPS8v86vcEwIKlCijnyVKFY2zA3NLBFtg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1700758567; a=rsa-sha256; cv=none; b=J+8oBx9IIdijzoKLUdtSLR0UT9KVFADcVyhhyxNJ/pB6T1fa2G/zb7fME7P0nJxx+h+Un/ xifuk8An1tBLCVcYd9gi6WVb9CcRDzIycVOW3I3gXzrGR7vduEhxhIdkMVhfTcYmsBChoU 4UMoGAG1jxCKfpgY4A5dxRbIpYZkjwaaaLvXs9f3BHOpb61Ab+vCz2MSIfslBMrZNz//Po y/xMpOn/zMAnyvYFREW99EGivRKUyal0iq+bbBGyupnI76ZbvWxaPF+Xz9blLynuGchcjB Fk4gowGDWhJraEUqR5jG07KM8qAS2nB01Sh6fgs/LU13hxB0ghs2zWDIpdrZ2A== Received: from [192.168.1.151] (host-173-212-76-127.public.eastlink.ca [173.212.76.127]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mhorne) by smtp.freebsd.org (Postfix) with ESMTPSA id 4SbklV4m9zz14Jx; Thu, 23 Nov 2023 16:56:06 +0000 (UTC) (envelope-from mhorne@freebsd.org) Message-ID: <06ffebce-65fa-4876-bce3-6120489017be@freebsd.org> Date: Thu, 23 Nov 2023 12:56:05 -0400 List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: db> reset -> panic: acquiring blockable sleep lock with spinlock or critical section held ... To: "Bjoern A. Zeeb" Cc: current@freebsd.org References: <0q526858-7s33-27qo-6q80-8o1q10415q2s@yvfgf.mnoonqbm.arg> <2b0ef12f-a158-4de3-8d25-ad2e5fcde644@freebsd.org> Content-Language: en-CA From: Mitchell Horne Autocrypt: addr=mhorne@freebsd.org; keydata= xsBNBFyS2dQBCADdiXBG8hBVLmYbxu7aSzbwLwUf3HkGFz3rooS1kwyy+SfmjZ4UKNnl9WMx WKrJ7OAZpiNH6bLQ5nsqfx09OnpWL8c/QuPbhNdUywQoqqYpRI0K8GEn//nS9Gs0KTYwVpWb XlrzP+jf3Uh/9L5mcQmStLIH4zaaqMYHW+pMuPrvBmLIHTvLj2QjOkxslrcUdord9uvxe5Ht LU8RuTpQpHOKz705Z9/v7twFdi2HtKzpLwO6SzVyu351di1J+GihsVpcT5josQV5cHbIP3Un x+kmtKBEEc/jl/zBglF7ruWUtwgbryID+2ZPEaO1Mj+RResX4LFVMusq3uUpWRb5WJXxABEB AAHNI01pdGNoZWxsIEhvcm5lIDxtaG9ybmVARnJlZUJTRC5vcmc+wsCUBBMBCgA+AhsDBQsJ CAcCBhUKCQgLAgQWAgMBAh4BAheAFiEEkp/cYPcfabAiQvACi/gnTOdUid8FAmIyDpUFCQtC z0EACgkQi/gnTOdUid8IsQf+N8IptrrCgifT5Z0/WUVFfnHThFOKf4zBjaGswsIM8+VKsKnF 15jCWHODUHP6s+dcQ4nQi81PHPsnMfBSkGPvN/X3ess2/1KUVkH+6tAJbqXDjXhD8HT+i0NM QEFIXlLnotpgIKW3yOHjKv3ZvKw9LCvUjyNY9vOJmLk/6AbbkFh+INo65nXtQWb/hM5FVEHW S+zUoU8AqZRJoVAQfj9wmIfg/HdsxeDGKL0zkv5AwKpccvb8VJNGJbCVMgoy5uQYcUeXxcie cg0VlbFLshNQTfyhVQ85vyuHahARrUWs/k8KiYODoBnW1ChtyF8yM6VZTzSYx7pINqPq2YZy i/Htd87ATQRcktnUAQgA3zt4M4ecoQqfxpjliNLujt9klDqvmkJvWmzMuMXdzlPgGRJ0doio 9YIeEdkOt6xN0pPTK/ReCZ8WqFQ8zo23u1pwGuo0CnR58XF19wyxyUuKu/PHbt+56mC8tNHm AXsMyXQmlDqWvn/WzLY7euNRtNS4QQIwtxfM5EC4GGa5KQwxn0kM7dkUSOE/cxr+/kNbHHzb gagZR4cnNUqtPPr3dYXcibCTzgz96Lyt3/qMLXX9RTBRzu+O6E+byxWOe8ar/ZlwY2b4wTQG mhgNttkSxKtxMpZnd8+DGV/bI1P5Ct/K2GeCwNyupQGON5ymn6o7jTch+qmFX0ItkBWO4zn4 9QARAQABwsB8BBgBCgAmAhsMFiEEkp/cYPcfabAiQvACi/gnTOdUid8FAmIyDtwFCQtCz4gA CgkQi/gnTOdUid/i5gf/aQ75pJR4TJFM2vVVr6PDIwTdl0b5EchB4w4s4g/zE84XNbMOQanb BginLYEhAacLQVAvM3XdvUEhwrhaMQdjdSEB1krResL3/mbxrtKwdHSMbHA3IS3XdvxFWTB7 P5JjUSPsW6hqgoidbn4w3OxaNHhs45H2b0Nx5QiKcSyepmCZuB52gCEHnEnrdaz8TFQMXOLq 94WbTmZeIjChW3FB61m1gTf0UEFjoZAfTAUB+pbwoCa4AykIeZnDC19vjsruVU9Gy5rLglwd bjsZNfXIJGOZNEvdF8FOBwM7DlXx7SYvTJcUNoNJjOKtQ0bYGVgGqYOB/y2mTjVuKeU0eOkN Uw== In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 11/20/23 15:40, Bjoern A. Zeeb wrote: > On Mon, 20 Nov 2023, Mitchell Horne wrote: > > Hi Mitchell, > >> On 11/16/23 18:21, Bjoern A. Zeeb wrote: >>> Hi, >>> >>> I seem to remember changes related to that a while ago but my cache >>> is miss for the actual change.  Are we suppoed to handle this case? >>> >>> It would be nice if "reset" would reset again the first time ... >>> >> >> Hi Bjoern, >> >> This is still my fault, I am sorry to say. If you recall, I proposed a >> fix after your initial report (back in February!), see > > now that you say I do.  I thought we had this all sorted.  Cache miss, > miss. > Maybe I had a local patch and hadn't seen it for a while because of that. > I likely dropped the ball on review and testing feedback. > > >> I posted what I believe to be the better fix just now, see >> https://reviews.freebsd.org/D42684. I will commit this ASAP along with >> some other tweaks to shutdown hooks which should (loaded word) >> eliminate this type of recursive panic during debugger reset. At >> least, that is the goal of the series :) >> >> I apologize for the delay on this, my ability to finish some of the >> work I've started has been spotty this year. > > Oh, no worries; I've been way worse this year.  Thank you for stepping up > working on this and the fixes.  It is much appreciated! > > Bjoern > You are welcome. FYI the fix has landed in main, 4e78a766f607. Mitchell