From nobody Tue Nov 14 17:44:58 2023 X-Original-To: current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SVDG65516z50PYb for ; Tue, 14 Nov 2023 17:45:02 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-yw1-x1129.google.com (mail-yw1-x1129.google.com [IPv6:2607:f8b0:4864:20::1129]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SVDG6353Dz3ZcF for ; Tue, 14 Nov 2023 17:45:02 +0000 (UTC) (envelope-from mavbsd@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-yw1-x1129.google.com with SMTP id 00721157ae682-5b383b4184fso69416867b3.1 for ; Tue, 14 Nov 2023 09:45:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699983901; x=1700588701; darn=freebsd.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=XIHs5jWKTP3bMasydA+O8p2OIhF9eoav3hqv1Nmtky0=; b=AL8oR04/rL338DMYEeTnlC4W0hKCUQdAFPe/JaOZ9og8koouyVe4eKzIdbjJYnnBsC uMwWeFx32lMt8jbbbknacR0QKXmlVHjzBBa/d+SlxY84wIruF2ZvC1jz6+ORI1ffdKK2 Mt4bHFaNybEJ4yh96SRsLemLfGNpbkb3CJlfkCvBcQzIiJy8zYehqOM2LgsPZegNPpww n3V3RMDaabJ++nUO+SyCChvZgbznSgnd3M2ncqJA2jb+pum3IL6Bw1UxoQqYLyGXxZLo +bXgRsI1OungPMuVuu6fGxokv++qeRqOPqXdQmw+YVqvMyx6289Tw2ojKA5eZHOt1tgz 96KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699983901; x=1700588701; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XIHs5jWKTP3bMasydA+O8p2OIhF9eoav3hqv1Nmtky0=; b=UVPddsGy6dah1MMV9MG5AgQwwxH1WYz6/fydXCdt/QuqEl2Pb7qVoBNgTE1kWE4Rrg sbdVNDvSYdIZyWVvI2QeTxcy36vmE3/4PEC6gA9G6XLmTCrP7TZym1WRpTYxuhlGIquO phIWi04G2zkEIOP66Ud7K6CHnM5G63HigaOIvtMLMOxTGk3wfk7j2lb7Z8MrSurlw9oF dWdveb7VhS60CwP5UXP3QYzrDQQVwqLod3bZQyXlK8Lw6Uf/LJFOPH6aYIGHuSvWBoR0 waPpnrfWxzrEX6rQT2/7XsWwSiAVzQy7vJwJhPBijZ1LtwRylJfpojN69+oOMqZQNKRa GbGQ== X-Gm-Message-State: AOJu0YzmWim2zJHOtAdqeO84o3bPcIizhEs1HY4Nl2ugUMDY2vIsYl/n UNcX9AmWoDXCfnFrR+qz2lQ= X-Google-Smtp-Source: AGHT+IF0IVnOKXU/nENKAm08oQXEtO47s0zn2olq5zftiXti84SC4j69gQ7y//0+DVoXTdJk0N1wpg== X-Received: by 2002:a81:49c2:0:b0:5b3:23f7:4254 with SMTP id w185-20020a8149c2000000b005b323f74254mr10973969ywa.25.1699983901027; Tue, 14 Nov 2023 09:45:01 -0800 (PST) Received: from [10.230.45.5] ([38.32.73.2]) by smtp.gmail.com with ESMTPSA id w137-20020a0dd48f000000b0059f802fad40sm2451445ywd.22.2023.11.14.09.44.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Nov 2023 09:45:00 -0800 (PST) Message-ID: Date: Tue, 14 Nov 2023 12:44:58 -0500 List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: crash zfs_clone_range() Content-Language: en-US To: Mateusz Guzik , Ronald Klop Cc: Konstantin Belousov , current@freebsd.org References: <349700057.3452.1699611152405@localhost> <1900239445.5968.1699966796547@localhost> From: Alexander Motin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4SVDG6353Dz3ZcF On 14.11.2023 12:39, Mateusz Guzik wrote: > One of the vnodes is probably not zfs, I suspect this will do it (untested): > > diff --git a/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vnops_os.c > b/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vnops_os.c > index 107cd69c756c..e799a7091b8e 100644 > --- a/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vnops_os.c > +++ b/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vnops_os.c > @@ -6270,6 +6270,11 @@ zfs_freebsd_copy_file_range(struct > vop_copy_file_range_args *ap) > goto bad_write_fallback; > } > } > + > + if (invp->v_mount->mnt_vfc != outvp->v_mount->mnt_vfc) { > + goto bad_write_fallback; > + } > + > if (invp == outvp) { > if (vn_lock(outvp, LK_EXCLUSIVE) != 0) { > goto bad_write_fallback; > vn_copy_file_range() verifies for that: /* * If the two vnodes are for the same file system type, call * VOP_COPY_FILE_RANGE(), otherwise call vn_generic_copy_file_range() * which can handle copies across multiple file system types. */ *lenp = len; if (inmp == outmp || strcmp(inmp->mnt_vfc->vfc_name, outmp->mnt_vfc->vfc_name) == 0) error = VOP_COPY_FILE_RANGE(invp, inoffp, outvp, outoffp, lenp, flags, incred, outcred, fsize_td); else error = vn_generic_copy_file_range(invp, inoffp, outvp, outoffp, lenp, flags, incred, outcred, fsize_td); -- Alexander Motin