From nobody Sun May 28 10:53:15 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QTb9m6cdKz4XDCg for ; Sun, 28 May 2023 10:53:32 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QTb9m623Bz3pyZ; Sun, 28 May 2023 10:53:32 +0000 (UTC) (envelope-from dim@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1685271212; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pF3KeIQc2QSODgUdaGaNzWOrpwheKRheDSJrDQ5CKxc=; b=gPHHBJsZVkHRT2FtuYC2CGoYAUIzPpPaZNgH5oZXuOlxpDBg74ylq+2BAnfSq+BdX+EHCV YQAJChDCTwU7Tfda7fpcl+eE+MHoxnmGRoNasFbkvqo6PWks1Zf+kKImzIar/UJCzvKouj FZlD5ONrOrzo4yDSZ56hqanAaOPNlrhmWOeyFjH30b5Hdhw5SgMC7by1BUovrlFIGhSd5E 7VvP9Pz7EUymBfrblq+1uraY7LC7lPfr2WlkEYni5z0y83x0WXAwFlqNryHA7NJcohg/ue Bsxfbxg0rilJFSn1sLWSltRwiMz+KbKqpddfv8hNvRiSR6CvsFPzwVg2YVXCEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1685271212; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pF3KeIQc2QSODgUdaGaNzWOrpwheKRheDSJrDQ5CKxc=; b=H/gTca1OH8tIF2zgU6JD2fRTwQsITYxGGElQG4rdTX4WwUYCn8pxYlPW0Ajwl8hurf7z9j q6+Lrr/u18Ivh8nrWdIeNOZzgODT7gb26Gc+8R2k4z+M4rERAvrSatUtT+BOu/gEDOuFp2 tpmYJI+166+A8f7Ok2RiRn8Zun/czfmzn05jw4ODiyS1Ww20tlEhXHKZ5YwMwybeDRl8rO wItaah2UR6KHtdxKfrBnSlA1kaj6litzC6t3M/vEmfRIOaroHEGHx2Aw0Shtp1veLJoJ63 zaJ3ucI6LAxv//ZB4d25OoPCoFBqgoiPkxOx/6AzP9QB0F5oGCzuIZEhZl9x1w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1685271212; a=rsa-sha256; cv=none; b=Cv6Ezt22o0dUyaBkBTzoJA0cgkz2wFyoIHioqlWjIXX0qQcsEI1rYTZyKviiQ/H4WUyv8I iblMo7eqA1g5UXIBGY3pT87ijL7ARhCzw8dbQvEsNN7xbFh78hOqQazOeMus87O+SGVL29 qezpX3AWP3Nbc5HwGNolr5/HqZ7N8yxgGHBkZpYaiXNumzA12/KPkx1utPF5SOIA8eMJ77 0Hv1O37AUwqI7x2k79t9d7hlta7fG8nXIvIy/qTRAAS1rkaOvsd2HcKe/vzlTJJYt3iDZw y6igCIRLLvXdLBnBQ69ksBh2H1LBUXlLeiAQN5tdjo2WVx4xjtSBI5E7kbDcMg== Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "tensor.andric.com", Issuer "R3" (verified OK)) (Authenticated sender: dim) by smtp.freebsd.org (Postfix) with ESMTPSA id 4QTb9m4Nf3zdb6; Sun, 28 May 2023 10:53:32 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from smtpclient.apple (longrow.home.andric.com [192.168.0.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id E5F624FFEB; Sun, 28 May 2023 12:53:30 +0200 (CEST) Content-Type: multipart/signed; boundary="Apple-Mail=_F0A5DA72-7432-4EFC-B48C-F5618FB16633"; protocol="application/pgp-signature"; micalg=pgp-sha1 List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.600.7\)) Subject: Re: "make hierarchy" from main tree breaks c++ headers on older branches with unclear errors if "make install world" is interrupted From: Dimitry Andric In-Reply-To: Date: Sun, 28 May 2023 12:53:15 +0200 Cc: FreeBSD Current Message-Id: <0DA92266-62F8-439E-9C56-44106A6B0073@FreeBSD.org> References: To: Enji Cooper X-Mailer: Apple Mail (2.3731.600.7) X-ThisMailContainsUnwantedMimeParts: N --Apple-Mail=_F0A5DA72-7432-4EFC-B48C-F5618FB16633 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 On 28 May 2023, at 07:18, Enji Cooper wrote: >=20 > I just tried to run =E2=80=9Cmake hierarchy=E2=80=9D from a main tree = on a 13.2-RELEASE system, and doing so completely broke my headers. > It took me about 30 minutes to figure out what happened=E2=80=A6 = /usr/include/c++/v1/__string was a header, whereas on :main it=E2=80=99s = a directory?! Yes, upstream libc++ has split up large headers into multiple = components, in particular __string and __type_traits. Since we had a file named __string, it had to be somehow replaced by a = directory. This is what the distrib-cleanup target in the top-level = Makefile does: https://github.com/DimitryAndric/freebsd-src/commit/6b13b4a095e3 Afterwards, the replacement directory named __string is created as part = of the regular mtree commands. ... > I reinstalled the headers by going to lib/libc++ in my releng/13.2 = tree, building, and installing all of the 13.2-RELEASE headers. > This change has been live for almost a year now on :main =E2=80=94 is = this a known caveat when doing a source-based upgrade from 13.2-RELEASE* = to 14.0-CURRENT, i.e., that the installworld (if interrupted) could = break the c++ compiler? I think it should already be quite clear that interrupting installworld = is risky. If you were just in the middle of replacing libc or rtld, and = those were half-written, your system will be completely hosed. (I am = speaking from experience. :) The same goes for any system headers or = libraries, not only the C++ ones. If you have a half-installed tree, it = should not be used for anything except attempting another installworld. -Dimitry --Apple-Mail=_F0A5DA72-7432-4EFC-B48C-F5618FB16633 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.2 iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCZHMymwAKCRCwXqMKLiCW o3ObAKCWU9dC7rMvTRTOf28qefpoWbKdwwCfc6JlfgTotbzLVh+Ew6ztHRpY4RE= =UBb8 -----END PGP SIGNATURE----- --Apple-Mail=_F0A5DA72-7432-4EFC-B48C-F5618FB16633--