From nobody Wed May 24 12:27:46 2023 X-Original-To: current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QR9SS20N8z4CfWJ for ; Wed, 24 May 2023 12:27:52 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-il1-x12a.google.com (mail-il1-x12a.google.com [IPv6:2607:f8b0:4864:20::12a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QR9SR3bK1z3FQ5; Wed, 24 May 2023 12:27:51 +0000 (UTC) (envelope-from markjdb@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-il1-x12a.google.com with SMTP id e9e14a558f8ab-3382dc7d50bso5752305ab.2; Wed, 24 May 2023 05:27:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684931269; x=1687523269; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=z5MSxoPB5vFexC9dAWXMNfmxKRJRd5ccui+JYCECuuY=; b=gMgHp+MJxRPTjihmXVqjulgQYrlpjLEDC7Fy9IhJgw6LxT4MAk/R0dBKnKdbOvCZLO A47usZm/hgXyyipZ2+1myFpyqapMzuybCsSF1maSI5vlsrBQ8bFZ8IRdf0KxCArsN+2I p85g0mq1YD+exWvzbp6VLciDqqf+/uDUxEiOylwtwoc8GenwcDN52igt0NcEJVEB6JtZ 4rXQ5/c/2eaQGQ98ycj8zye1HwpEjbi7Zum0LibtLHjL/lcMBHl+JwgzNWE6YTYa2KO8 pTX5Dv/ey2+p0TPq1+wG49G9rZilm9mKmQpZAq+BqM9QUFieU6edKI4JPvSM2+dkjJrP zn+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684931269; x=1687523269; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=z5MSxoPB5vFexC9dAWXMNfmxKRJRd5ccui+JYCECuuY=; b=da1dSyXCs5yKt40OGbT4pHczEax4Yz90Fqls9lDYyNbBwOioxOeEv7vQEOUgoTuc05 BpA3u3FXWfv36Vr0DGmKcnsk/s0lvgq3H3AVHhyhgsXzZC7yCxD65CN1Y+RMzgaVcNMy WDAL4dq0VPWyhy4T94hznLckCk+Ha72rbbUszmB5nTkRkcNl0CgFLz/9O2IbLZxXqYJs 8VmPAhnpNJ/P63v5fiOQ8iFTv+7Uz1LzQPd0BwFI+E+iZE1wapuY+l2WVZGRYAumLUt6 MlRFmfHPGJ1u3J3v6SfIZAP1fhBXzXhkr6DAppzwScLJwj8LYpZEQI06nOqtxZfdYdOL Muqw== X-Gm-Message-State: AC+VfDxgy987fQRoGqYHIUfzyO6MokH5/G6yfNGYNWL277r/D8iU5ScK 5Yk06AC48cS1aWiWupph2eOQPagpLNA= X-Google-Smtp-Source: ACHHUZ4P/BuV9T90JFCqOSv8ECB++Ab2pcKCyFkNUaP8j/tN01UzOKObxJITNSUrSLJIXKN95puc4g== X-Received: by 2002:a92:cb4a:0:b0:335:542b:aa48 with SMTP id f10-20020a92cb4a000000b00335542baa48mr12585407ilq.19.1684931269538; Wed, 24 May 2023 05:27:49 -0700 (PDT) Received: from nuc (192-0-220-237.cpe.teksavvy.com. [192.0.220.237]) by smtp.gmail.com with ESMTPSA id m16-20020a92d710000000b0032e1f94be7bsm2967804iln.33.2023.05.24.05.27.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 May 2023 05:27:48 -0700 (PDT) Date: Wed, 24 May 2023 08:27:46 -0400 From: Mark Johnston To: Dimitry Andric Cc: current@freebsd.org Subject: Re: Build failure in usr.sbin/bhyvectl; sources at main-n263112-ad513b4dba3e Message-ID: References: <60EE10D6-1D12-494B-B51C-B81CAF537EF9@FreeBSD.org> List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <60EE10D6-1D12-494B-B51C-B81CAF537EF9@FreeBSD.org> X-Rspamd-Queue-Id: 4QR9SR3bK1z3FQ5 X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On Wed, May 24, 2023 at 01:39:26PM +0200, Dimitry Andric wrote: > On 24 May 2023, at 13:25, David Wolfskill wrote: > > > > This is from an in-place source update from main-n263073-634a770a5e16 to > > main-n263112-ad513b4dba3e: > > > > ... > > Building /common/S4/obj/usr/src/amd64.amd64/lib/libc/tests/stdio/scanf_test > > Building /common/S4/obj/usr/src/amd64.amd64/usr.bin/ncurses/dump_entry.o > > Building /common/S4/obj/usr/src/amd64.amd64/usr.bin/mkimg/tests/img-1x1-4096-mbr.vhdx > > Building /common/S4/obj/usr/src/amd64.amd64/cddl/usr.sbin/zfsd/zfsd.full > > /usr/src/usr.sbin/bhyvectl/bhyvectl.c:2389:24: error: incompatible pointer types passing 'struct vm_exit *' to parameter of type 'struct vm_run *' [-Werror,-Wincompatible-pointer-types] > > error = vm_run(vcpu, &vmexit); > > ^~~~~~~ > > /common/S4/obj/usr/src/amd64.amd64/tmp/usr/include/vmmapi.h:158:46: note: passing argument to parameter 'vmrun' here > > int vm_run(struct vcpu *vcpu, struct vm_run *vmrun); > > ^ > > 1 error generated. > > > > > > Given that yesterday's update was uneventful, and that > > src/usr.sbin/bhyvectl/bhyvectl.c has not changed in several days, > > I'm guessing that perhaps a recent change to a header, possibly > > involving vmexit, may be at issue here. > > It appears to be broken since "vmm: Avoid embedding cpuset_t ioctl ABIs": > https://cgit.freebsd.org/src/commit/?id=e17eca327633efc511450310afb5e4a662724e3d > > See also https://ci.freebsd.org/job/FreeBSD-main-amd64-build/, where it shows an error since https://ci.freebsd.org/job/FreeBSD-main-amd64-build/26653/ This should be fixed now. My apologies, I had no idea bhyvectl provided a way to run a VM...