From nobody Wed May 24 02:10:30 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QQvmG4cpyz4TLn8 for ; Wed, 24 May 2023 02:10:38 +0000 (UTC) (envelope-from gad@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QQvmG4BqWz3Gph; Wed, 24 May 2023 02:10:38 +0000 (UTC) (envelope-from gad@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1684894238; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ULesKFEF4HB1ksq452FajH+p5Ux5cV4Uj88zfF6Ozhw=; b=TC0gkCTHSTAUMHx8YwnK+b4eY/Jm3CYWmibT/6NpVCCYnp0qXy1cRyvUhgSp2iKVxnByVU pG7SSK/B5Fq09FGzZ/xliKxP+ur0mi/xraga5fmLvsKPQaVdfQF3Qkni5toywGaK5/71wh MUqDRXoKV489myhFBsiyLYsVPSO+fdWw7RFfGxs/bIl6a15zFLd1rz9nSMz62NLBIYMD4j 2FVDFA6imJoXNwxktYOT6dbo+/mcJrXHY4FzQtUaz+NCyNV7sgH4P+JUp2fKNkfOjAwODL MYRu02raeou/jD2QJpW2pWrxpWtg9f1Rwq2/AzM8ft/RU3pXlMg6tUlMiJ7hCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1684894238; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ULesKFEF4HB1ksq452FajH+p5Ux5cV4Uj88zfF6Ozhw=; b=MXRau+5ZeYyPhiCAYZs31qYXOc2RAbk7jKtdncCiKl3WSUgs7Pk+pQtrYLydn7spqKvx9X TQoRm9NPXLbL0Ja7T3wUZAGKNwrIbk8k86oW2Cek9XnGHB34F+jEoWw/Yk6CywHOkJjyV4 ltrUlQoQkhAs1S3/2EmTaPgC7rlVtap2vUZcw8Ges3lfImUdAEukNDBRJTHrK7OpEK+I8T FGDXD8e3WhEhiWSdrs9N/xHvACZeJIodPQfAGUNQwclhnoXqpUozIZn4BkxyKMrTGBsl61 vGLOCcISfm7JZnIOJfZyGMoPhn69zPHaA7QiZ8VPbPL5LDpewdzdyvvxbzRwiw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1684894238; a=rsa-sha256; cv=none; b=v16OuvsnKfGKBruL11feW8QUqAtn/Ye1ENHjZVgBRe9JgHjhSQf6YAFmzF75+Bj1fSYI0k oegiSCK06udFzXS52cHm9vu4+rvL+UHJ46Ds6jK5SDMlR39nNH9a9B9rM/Rhp+CLBNrP/6 O3GA2uGlK+oXfWxYkn/SZyR1GqShfBZyfMzhNOU5nwWX3HXKH95bI14qe2bSflR0S/zTLM HEA1cpahN5UwKXxNO7dQW3gHPU+uBCUNaKHrzZefOKS/KiDmONihNg69C/977NAQH8vrwU gmIM/wokVlfcJvxLu1il3CFL4HCUAs4tKOoZIY1qrHiNhKxdWsQrDLXc4BN86A== Received: from [128.113.125.11] (cpe-72-224-11-59.nycap.res.rr.com [72.224.11.59]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: gad/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4QQvmG251Dzn1t; Wed, 24 May 2023 02:10:38 +0000 (UTC) (envelope-from gad@FreeBSD.org) From: Garance A Drosehn To: Jamie Landeg-Jones Cc: freebsd-current@freebsd.org Subject: Re: MOTD is not created correctly (since 2022/02/18) Date: Tue, 23 May 2023 22:10:30 -0400 X-Mailer: MailMate (1.14r5937) Message-ID: In-Reply-To: <202305230318.34N3IOaX056503@donotpassgo.dyslexicfish.net> References: <202305230318.34N3IOaX056503@donotpassgo.dyslexicfish.net> List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="=_MailMate_025F1A85-250B-4CB7-B6EB-3C2DC3C3949B_=" X-ThisMailContainsUnwantedMimeParts: N --=_MailMate_025F1A85-250B-4CB7-B6EB-3C2DC3C3949B_= Content-Type: text/plain; format=flowed; markup=markdown Content-Transfer-Encoding: quoted-printable On 22 May 2023, at 23:18, Jamie Landeg-Jones wrote: > I've just finally updated to 13-stable, and can't be the first to = > notice this?! > > /etc/rc.d/motd contains the line: > > uname -v | sed -e 's,^\([^#]*\) #\(.* = > [1-2][0-9][0-9][0-9]\).*/\([^\]*\) $,\1 (\3) #\2,' > > Note the space before the "$" - needed because the uname -v output = > used > to have a trailing space. This was fixed and comitted on 2022/02/18: > > https://cgit.freebsd.org/src/commit/usr.bin/uname/uname.c?id=3D7e05fa3b= 449007adaa6e588ebb3b8d76f30b355c > > Since then, the sed doesn't match, so the uname(1) output is = > unchanged. > > There's no point altering the sed to work with both possibilities, so = > can > someone commit the fix of removing the ' ' before the '$' in = > /etc/rc.d/motd ? Not that it helps you much, but I did notice it and have an alternate version of rc.d/motd on my own systems. I had no particular attachment to the earlier format, so my motd starts out by printing the two lines of: ``` -KU 1302505 1302505 -b 18fa15f83c483db67b818e3a48bbb312908754b1 FreeBSD 13.2-STABLE (Garance-13x) #0 -- Fri May 5 17:53:55 EDT 2023 ``` (that first line is the output from ```printf ' -KU %s -b %s\n' "$(uname -KU)" "$(uname -b)"``` ) But I thought that committing that would trigger a bikeshed debate, so I also have an option to produce the output we previously had. And given that no one seemed to be complaining about the "full uname" version, I figured I had an option for that too. And then I thought all these = options were overkill and would trigger and even longer debate, so I never = brought the ideas forward. :) -- = Garance Alistair Drosehn =3D drosih@rpi.edu Lead Developer @rpi and gad@FreeBSD.org Rensselaer Polytechnic Institute; Troy, NY; USA --=_MailMate_025F1A85-250B-4CB7-B6EB-3C2DC3C3949B_= Content-Type: text/html Content-Transfer-Encoding: quoted-printable

On 22 May 2023, at 23:18, Jamie Landeg-Jones wrote:

I've just finally updated to 13-stable, and can't be the = first to notice this?!

/etc/rc.d/motd contains the line:

uname -v | sed -e 's,^([^#]) #(. [1-2][0-9][0-9]= [0-9])./([^]) $,\1 (\3) #\2,'

Note the space before the "$" - needed because = the uname -v output used
to have a trailing space. This was fixed and comitted on 2022/02/18:

https://cgit.freebsd.org/src/commit/usr.bin/uname/uname.c?id=3D= 7e05fa3b449007adaa6e588ebb3b8d76f30b355c

Since then, the sed doesn't match, so the uname(1) output= is unchanged.

There's no point altering the sed to work with both possi= bilities, so can
someone commit the fix of removing the ' ' before the '$' in /etc/rc.d/mo= td ?

Not that it helps you much, but I did notice it and have = an alternate
version of rc.d/motd on my own systems. I had no particular attachment to the earlier format, so my motd starts out by printing the two lines of:

    -KU 1302505 1302505 -b 18fa15f83c483=
db67b818e3a48bbb312908754b1
FreeBSD 13.2-STABLE (Garance-13x) #0 -- Fri May  5 17:53:55 EDT 2023

(that first line is the output from
printf ' -KU %s -b %s\n' "$(uname -KU)"= ; "$(uname -b)"
)

But I thought that committing that would trigger a bikesh= ed debate, so I
also have an option to produce the output we previously had. And given that no one seemed to be complaining about the "full uname" ver= sion, I
figured I had an option for that too. And then I thought all these optio= ns
were overkill and would trigger and even longer debate, so I never brough= t
the ideas forward. :)

-- =
Garance Alistair Drosehn = =3D drosih@rpi.edu
Lead Developer @rpi = and gad@FreeBSD.org
Rensselaer Polytechnic Institut= e; Troy, NY; USA
--=_MailMate_025F1A85-250B-4CB7-B6EB-3C2DC3C3949B_=--