From nobody Sat Jun 03 08:18:43 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QYCSS447xz4Z0ly for ; Sat, 3 Jun 2023 08:18:48 +0000 (UTC) (envelope-from garyj@gmx.de) Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mout.gmx.net", Issuer "Telekom Security ServerID OV Class 2 CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QYCSR4sN0z4NpG; Sat, 3 Jun 2023 08:18:47 +0000 (UTC) (envelope-from garyj@gmx.de) Authentication-Results: mx1.freebsd.org; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1685780325; x=1686385125; i=garyj@gmx.de; bh=ZEngNEc0TnNEBatqBIMpr4wY0bz4WTqIr7cK2Bfk/44=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:In-Reply-To:References:Reply- To; b=EphlgQ25PfbQAfzL8KZ7JoJ/Cn8CZ9a224ApTrPDM5ecTv9kxBLqKPGsc+9D7BlqIZ5vLuF ojO2QUq+gKiRsdNVVMfzQ8mHCZRPJeLP6Ft8abs6YTSXNr1exyDrbk9iSyViOFFIliagYVs1u lKBMNtv0CSCRCcXu/AwK2Hila+lRM9YfvGOLn9NmqsDh9zsmDBOlISrir9gmhw3dOGC6t0zhO ZJj9YGNE3KziFr0LAGYkdcxoedih3BX0HnLtPJIBGRDssUdzPP7H62g7y70LCjgtoyQQyrBfO 4dRWNLYm7/ZP2geWjUdC0v7D9ZguOd2FrmN2cCvtK9GVzNNlr3oA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from ernst.home ([91.59.239.189]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MLzBp-1pny2m3AoL-00Huxm; Sat, 03 Jun 2023 10:18:45 +0200 Date: Sat, 3 Jun 2023 08:18:43 +0000 From: Gary Jennejohn To: "Alexander Chernikov" Cc: freebsd-current@freebsd.org Subject: Re: Error building kernel in current Message-ID: <20230603101843.717e30c9@ernst.home> In-Reply-To: References: <20230602115644.7ce88b9f@ernst.home> <20230602115940.7c9d2f4e@ernst.home> <20230602173055.583db61d@ernst.home> Reply-To: garyj@gmx.de X-Mailer: Claws Mail 3.19.0 (GTK+ 2.24.33; amd64-portbld-freebsd14.0) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:VjnTCkiourr31l4vBV6AsTWYjwvebNVBg+yPQRwdidbbbQbBUNR PjhOGvLHcEolbawude2YChNNrVA/zarw7OZ/YDS142hzQXeObJWuvssBbkwlIpbdyY0XO4J GF70nexwAqbhHTzAThR5rKprnX3Vq1NptcBSAmNvbMBcsZ06EaIzVDA9QxClcTEpdIvV0X9 DGoTSZSq9Q2Utz6MrVv5g== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:r9coonT7nUY=;3QKVqAuMCXxYcmuRSu5bQpUxmzN KPAowoOPWpwMSvUVhNRC1xCPn9FHhBn64+qAkSzgBsilm4Wjcur8T/oQ1c2ly2ytavOTqmbJY ge8Vk4WEfZdYGYc/QPl1C9ubDt7KVF3M5NPMN54FuhhqQuCZZPfHj8EIzibKoifx4QI3FISvT 2RMWe40UCl00bsbIU9LbbuRJNya6yY7Smt3U7kjJjZOe4Uuo7PH63bAccZTXU0eMdIYbnVyms aJOklOi3Fz21we9pfBHOxh70Dwq54/0hlkdEv0wRLjt/SdR3XgciEmGeSmSb9hBAwXQ7q5Irv dD+ZTLDs3qZNZMAAaERgXtfRag9WbGWiXzkhIUcGYksuwY/oC/DGFJWUBrLmIPaSk9crC4vBH JJbM0yHm/m/U2E2Zo95sGpKSr+kXSI2iiQlV62pWRy5vRkWtPldZpD6oL+Bah+W+fqh/nnFm+ OcCCc1l+bU9C/i8mYktLX+2at6BNNvlOHoGMibUB3xVKTBCBnlDevzr77kbPUrZ8+S8keJsEX 1UUNcQBARLnFgWRUPcBEpZnHNlbV7DP9HaA+g9y4w1GzeUxifS5CDHTn3ZEP8pQgAuZKrWM3+ YHeRTw18AVzq+1NDT2w4IituoPUqdRfr5oXeoqMMjJiLHaKVpmYarF9QnpvOJ30w+KsHB05N6 VOgNXqD6mqxooPGDhoeUXxdtFOVXsR8zmpD+VqwgRbe5D8DNlT3izgqAibDKCWDG99/avBMlO 8D0Y9SVU7FuHx/OmzT6HTcGmYBs6VHLK/rkcDqlCrFR5os6/lD51A5rBF4Q/prPZ+ybrOYWt1 5G+6JAdd3ZwcIyDz8F7iDtoHuHg1uyn/AX4fJoyKJZtrcPQAQ6TXU6iWqeyMzG9kH0VBf5W9a ZmauHMPjSUqI8QoFR+1cr8TollBG3ci42Z1lw92Gh6mPg7W0Q/7y9KDfsSyuWfftEA/Kp5n2W nwVxovXI7L1QFscPTGxVbLwLtMw= X-Rspamd-Queue-Id: 4QYCSR4sN0z4NpG X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:8560, ipnet:212.227.0.0/16, country:DE] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On Fri, 02 Jun 2023 19:57:40 +0100 "Alexander Chernikov" wrote: > On Fri, 2 Jun 2023, at 4:30 PM, Gary Jennejohn wrote: > > On Fri, 2 Jun 2023 09:59:40 +0000 > > Gary Jennejohn wrote: > > > > > On Fri, 2 Jun 2023 09:56:44 +0000 > > > Gary Jennejohn wrote: > > > > > > > Error building kernel in current: > > > > > > > > -------------------------------------------------------------- > > > > >>> stage 3.1: building everything > > > > -------------------------------------------------------------- > > > > /usr/src/sys/netlink/route/iface.c:1315:22: error: use of undeclar= ed > > > > identifier 'if_flags' > > > > if (error =3D=3D 0 && !(if_flags & IFF_UP) && (if_getflags= (ifp) & IFF_UP)) > > > > ^ > > > > 1 error generated. > > > > --- iface.o --- > > > > *** [iface.o] Error code 1 > Sorry for the breakage, I?ll fix it in a couple of hours. > > > > > > > > My source tree was updated just a few minutes ago and I didn't see= any > > > > recent changes to iface.c. > > > > > > > > I have WITHOUT_NETLINK_SUPPORT=3D in my src.conf. > > > > > > > > > > Ah, my error. The failure occurs while building the kernel, so I fi= xed > > > Subject accordingly. > > > > > > > OK, this is another INET6 error. I don't have INET6 enabled. > > > > At line 1280 we have: > > #ifdef INET6 > > int if_flags =3D if_getflags(ifp); > > #endif > > > > and if_flags is used at line 1315 without checking whether INET6 is > > defined. > > > > if_flags seems to be totally redundant, since the code at line 1315 wi= ll > > invoke if_getflags(ifp) if !(if_flags & IFF_UP) is true. > > > I wish it was true. The case here is that interface flags can change > after adding the address, as many interface drivers silently bring the > interface up upon the first address addition. Please see > https://cgit.freebsd.org/src/commit/sys/netinet6?id=3Da77facd27368f61852= 0d25391cfce11149879a41 > description for a more detailed explanation. I suspected that may have been the reason, but I wasn't sure. Thanks for the link. =2D- Gary Jennejohn