From nobody Thu Jun 01 02:42:05 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QWr4y6qSjz4Y4mm for ; Thu, 1 Jun 2023 02:42:10 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QWr4y4rgHz4M34; Thu, 1 Jun 2023 02:42:10 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-pf1-x435.google.com with SMTP id d2e1a72fcca58-64d2f99c8c3so264012b3a.0; Wed, 31 May 2023 19:42:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685587329; x=1688179329; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:from:to:cc:subject:date:message-id:reply-to; bh=OwSiQF9UQJApCeN2Y5YAuDRHfN/jP687lJaN3drqT9U=; b=VwX9MbK41Ozw7/UsQro9yYWjqreXxqqfM1Z1ppuL9MdIZdkWsaj+j0IvCLv5NXgnQt 5oShVQ85VyA7ai5MIMlCQss+oKaD31yi7hUNz2VuAAZM0S8NJguiNVJwGqwXaEFaF2SN 3C2TyuyZKkfzSKJX3vJSm4qxhv2IM2q8JQfU61M3fwmMnRptYjcBvtem+v7UPN/wmcwN a52mMwSR1KfzCts8Q2KPvJvkt/1lF0MuHvwJi4vWj/3+Vqf0mYLJkAIT1AyIvIQAYKtz cnxKF1RK0//ilCJgEKgpDWU6jIqd0gAJcQKNqoJreonzrxFtkjKdfABt41QpHh7tcXnZ vaaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685587329; x=1688179329; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OwSiQF9UQJApCeN2Y5YAuDRHfN/jP687lJaN3drqT9U=; b=PqEsj110e6qYOHgBAnSk3N/Fg6KrB3R8vap+ZPjq0KnsWc94eFzNev3y96zA0XCS1d ejSRViYCGSGJ9xNLBka6rFXWvvLHymap37hf6bLc2sEc3Q15NEw/bFohCi/UYIJXKy13 y1TXe5vEvgpx/6HdJ0pHrkuGjd5CNTwNQomTOn/068jlwt/Vnt6Jp1seyMIuZK4izcHQ kj1c+fmVzR/mvRbb/pHbwHkMEYcp74gcm9T1FWpLe5eVPfanTwLG8hVp/rhv2+E9/4Pd 4iUaRKUDEx9JgBQAnnZVuYdpxNckhYfEdg9bp/R5GZaNVbLFCyDNP2zKoNtdlgtPBQgk 7wLg== X-Gm-Message-State: AC+VfDzsXIX6PtJqW08hP7o7XRfPmbzN6MJ6MkyV8JcuUJ2eCCXFoSsG j71MCBt6jZp706i7a927B0e/Ms+BmaIhOA== X-Google-Smtp-Source: ACHHUZ7rtE3/Ou7/iwxQWpfT+tUQaUle2WofDUpNKPFHC7RxeJw55rMY58eJ1TDJ2r2hfevM3H+h8w== X-Received: by 2002:a05:6a00:174c:b0:643:98cb:ec1 with SMTP id j12-20020a056a00174c00b0064398cb0ec1mr7582389pfc.0.1685587328663; Wed, 31 May 2023 19:42:08 -0700 (PDT) Received: from smtpclient.apple (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id x21-20020aa784d5000000b0063b86aff031sm3988916pfn.108.2023.05.31.19.42.07 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 31 May 2023 19:42:07 -0700 (PDT) From: Enji Cooper Message-Id: <3F4CBAD1-3C59-4A76-BDB2-F53A345BBB1A@gmail.com> Content-Type: multipart/signed; boundary="Apple-Mail=_C1F58AB8-E213-4CBF-B735-F42D49AE8532"; protocol="application/pgp-signature"; micalg=pgp-sha256 List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.3\)) Subject: Re: "make hierarchy" from main tree breaks c++ headers on older branches with unclear errors if "make install world" is interrupted Date: Wed, 31 May 2023 19:42:05 -0700 In-Reply-To: <8CD00413-E6B3-4DBA-8A71-CAFA647DF2FF@FreeBSD.org> Cc: FreeBSD Current To: Dimitry Andric References: <0DA92266-62F8-439E-9C56-44106A6B0073@FreeBSD.org> <8CD00413-E6B3-4DBA-8A71-CAFA647DF2FF@FreeBSD.org> X-Mailer: Apple Mail (2.3696.120.41.1.3) X-Rspamd-Queue-Id: 4QWr4y4rgHz4M34 X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N --Apple-Mail=_C1F58AB8-E213-4CBF-B735-F42D49AE8532 Content-Type: multipart/alternative; boundary="Apple-Mail=_5EC10A4A-3679-4F15-847E-EC6F9FE88D22" --Apple-Mail=_5EC10A4A-3679-4F15-847E-EC6F9FE88D22 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On May 31, 2023, at 2:06 AM, Dimitry Andric wrote: >=20 > On 31 May 2023, at 01:07, Enji Cooper > wrote: =E2=80=A6 >> That=E2=80=99s a fair point, however, given that this follows the = standard installation workflow=E2=80=A6 >> 1. etcupdate pre-run. >> 2. install kernel >> 3. reboot >> 4. make installworld >> 5. etcupdate post-run >> =E2=80=A6 this could surprise end-users. In particular, the C++ = compiler will be broken between step 1 and step 4. >=20 > How so? The deletion of the old __string file is done as part of = installworld, i.e. in step 4, not in any of the earlier steps. The only = case where you can have problems is when you start installworld, let it = run until it has completed its distrib-cleanup target, and then = interrupt it before it can install the new headers. No wait =E2=80=94 you=E2=80=99re right. The directories aren=E2=80= =99t created until =E2=80=9Cmake installworld=E2=80=9D is run so this is = a short-lived issue =E2=80=94 it impacts folks who run =E2=80=9Cmake = hierarchy=E2=80=9D out of band, but we=E2=80=99re an extreme exception, = not the norm. Thanks for helping me figure this out :). Cheers, -Enji --Apple-Mail=_5EC10A4A-3679-4F15-847E-EC6F9FE88D22 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8
On = May 31, 2023, at 2:06 AM, Dimitry Andric <dim@FreeBSD.org> = wrote:

On 31 May 2023, = at 01:07, Enji Cooper <yaneurabeya@gmail.com> = wrote:

=E2=80=A6

That=E2=80=99s a fair point, however, given = that this follows the standard installation workflow=E2=80=A6
1. etcupdate pre-run.
2. install kernel
3. reboot
4. make installworld
5. = etcupdate post-run
=E2=80=A6 this could surprise = end-users. In particular, the C++ compiler will be broken between step 1 = and step 4.

How so? The = deletion of the old __string file is done as part of installworld, i.e. = in step 4, not in any of the earlier steps. The only case where you can = have problems is when you start installworld, let it run until it has = completed its distrib-cleanup target, and then interrupt it before it = can install the new headers.

= No wait =E2=80=94 you=E2=80=99re right. The directories aren=E2=80=99= t created until =E2=80=9Cmake installworld=E2=80=9D is run so this is a = short-lived issue =E2=80=94 it impacts folks who run =E2=80=9Cmake = hierarchy=E2=80=9D out of band, but we=E2=80=99re an extreme exception, = not the norm.
Thanks for helping me figure this = out :).
Cheers,
-Enji
= --Apple-Mail=_5EC10A4A-3679-4F15-847E-EC6F9FE88D22-- --Apple-Mail=_C1F58AB8-E213-4CBF-B735-F42D49AE8532 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEtvtxN6kOllEF3nmX5JFNMZeDGN4FAmR4BX0ACgkQ5JFNMZeD GN4ENxAAjoHcPrqjKSYTFyUGop3TlYwz/zBnn9F605oi332oVEptSaf0VJmvMyrY iDWw90oCt3NmeTJrdEYqO2+A4DVGf2X6pPHN/5ZLykxEW422tSaJPwtxJRYBqS+s nhV0PbtzVjbgs/H9lZL9ueGPEWQvq0C9QDcozrGJB5hppI6F83F3aE5BUF+ninX0 wpXnVs6xSh07AVQWQHON0k0FKfl6o07fJtSD8B2yhc7QSN15V37dKWVqOor+3BLB aGuk0tjxunLH94GG7Oc6yd0820MRO8rmxX/AQXnNRSC1qtlBaLA7+alO57KA3JlO Yi7sMWSh3JlojQdiKx1ebXlQagU4HzlkfLsoGfuk4leao16KHlX/DeDYM/fHq3vB cn7VHMSgzIvAVYR41+0GbvHc8k8BB1ElvWFPjBmLCsn8U5F3d2fymoQu7HqTAKSH hCQXBvA1fx1SxX4OO3Qb3zf5qjUvAMQVsfy3RytBoC/S7qu6BRWnSODu0a7xmbCf Ael04VrEOnfScy066VRXPzqB9lq/65ycbQRycuB+Sudnc+PlPvm+jg6/E5/HD0/2 I7Y/o+M3GFPM54An5zzR54Q0JlRGGDvSK+hKLqZE5pjx5EmVH8PPzxWe06EQbLEY 8rnO/6IDykzFSdjkSB8VUHm1qUQuaHyGn6zeFM+ny2OWGqsPN5c= =EOCb -----END PGP SIGNATURE----- --Apple-Mail=_C1F58AB8-E213-4CBF-B735-F42D49AE8532--