From nobody Fri Feb 24 07:33:54 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PNMB03pB4z3tdn3 for ; Fri, 24 Feb 2023 07:35:20 +0000 (UTC) (envelope-from sjg@juniper.net) Received: from mx0b-00273201.pphosted.com (mx0b-00273201.pphosted.com [67.231.152.164]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.pphosted.com", Issuer "Thawte RSA CA 2018" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PNMB01pLLz3F48; Fri, 24 Feb 2023 07:35:20 +0000 (UTC) (envelope-from sjg@juniper.net) Authentication-Results: mx1.freebsd.org; none Received: from pps.filterd (m0108162.ppops.net [127.0.0.1]) by mx0b-00273201.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31O0P74P022589; Thu, 23 Feb 2023 23:34:58 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; h=to : cc : subject : in-reply-to : references : from : mime-version : content-type : content-id : date : message-id; s=PPS1017; bh=HsJtb39bkQ3FTIncbUld9FkQW5aawHsch90I4g9l4oA=; b=o08/cfkOY//NWR+BN6/MPp431l606M6DlZq9F2zJpLIoagpiFS9/MfuQoruutxhVnz8y f5UxYdsTqHFIL9iaDFlTX6LFnlbbtnHei7YnJen2xWTA83NJBjTZqO50VMG/SFsp5zVe Jb/XOd3CeSeuviiEInjlO7xkQ0L3Rlnt98N0V1m912ekLV/6yABGfayhKO94KYCEuWmP olL3ClYg0jcsxINCnYi3TuCgki33Rgo/zk/rGT+cbYLFLWuQOoNWG9c6FI2aYMFCb7kp NRc3A9y7aKakbjbygtdZDUzxbFvBMtKB6bnQnFjWd5sYyZd2kIH5Tp1yYX0YqYwJ/fTt Tw== Received: from cy4pr02cu007-vft-obe.outbound.protection.outlook.com (mail-westcentralusazlp17011010.outbound.protection.outlook.com [40.93.6.10]) by mx0b-00273201.pphosted.com (PPS) with ESMTPS id 3nxjp1rnww-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 23 Feb 2023 23:34:58 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iBXT4NRTxJO/myiayCrsOmPoT4ZKbrLI+G7yCGEfn6usS8/QA0AGEgsBGZb+juIuZAgrBjDD/YAEU3tyaRK6bRoVfm+mIzNR/zNPpfXskMdvBN1boE2OOZ1ORyzw8r1UGxu3OWgehFxk1VR3j7sQOkWrttfiLLoEhXtjDy39W1D1Qx/ugX4OA19fJRnNxrHAZnWCUdGFfBKKAyEDLzJgQXZZVkVFh93lDmejVRmNLYtl6lOJSJxxn8MtC3cIGAt25vpKvx0CU5FCHnKLQ2MHAownqv9jlDoKuu+1yX1b+CHJ8YmojjNeWn9LZ2B03mcy0QAq/IfqUm0XT0uzDcMa9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HsJtb39bkQ3FTIncbUld9FkQW5aawHsch90I4g9l4oA=; b=WOZYV7GFMdFpWmagxCpc7L7cj9CsDmdBZFdQu2Ahj/+a5hepCwEWgcrx7Tp8dZqsQlcbZZGP7gx6U9w8zjbrNuIUrR7FX5DZctEGoy7H88Hey0i1g4yxVKX6rypteoB6+r7dYfsdTnXDIq8kgwPHGfxHvE7ZNpVkiytcg/z9UTe6ERVRb2SP+GjJrnGnvGtUo2noX/r33bwwE/agDb4KjKIAOcy+vAAuwArNkmv+5fYtG3yqT5Zi8GYysZPzTqcXEWXFZ1zVQnZMOhB562Ht1cQ83BbQDMzJgApTNszg3JJD7pS+k89988IRQ9oMPiKCiIZ5DsgimtF5Kjx6D1r3TA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip is 66.129.239.15) smtp.rcpttodomain=yahoo.com smtp.mailfrom=juniper.net; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=juniper.net; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HsJtb39bkQ3FTIncbUld9FkQW5aawHsch90I4g9l4oA=; b=U3d3QJlgiBAqcPIEI6OHuypOL6frgx628Ftr1y5b6+C+oEL+pWXPfpIn0moDCxC4dBrxqGK21XO8JWCUs29FWHECdupjZZ0rWSR6l7SqsUsO2szrtKdR1eoOzJAvvORl14LDaMdT2hnBZVapMBot+kwyPauaCYFh0WmBUZumu+4= Received: from DM6PR07CA0044.namprd07.prod.outlook.com (2603:10b6:5:74::21) by BLAPR05MB7490.namprd05.prod.outlook.com (2603:10b6:208:296::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.24; Fri, 24 Feb 2023 07:34:55 +0000 Received: from DM6NAM12FT095.eop-nam12.prod.protection.outlook.com (2603:10b6:5:74:cafe::5b) by DM6PR07CA0044.outlook.office365.com (2603:10b6:5:74::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.24 via Frontend Transport; Fri, 24 Feb 2023 07:34:55 +0000 X-MS-Exchange-Authentication-Results: spf=softfail (sender IP is 66.129.239.15) smtp.mailfrom=juniper.net; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=juniper.net; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning juniper.net discourages use of 66.129.239.15 as permitted sender) Received: from p-exchfe-eqx-02.jnpr.net (66.129.239.15) by DM6NAM12FT095.mail.protection.outlook.com (10.13.178.194) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.19 via Frontend Transport; Fri, 24 Feb 2023 07:34:55 +0000 Received: from p-exchbe-eqx-02.jnpr.net (10.104.9.15) by p-exchfe-eqx-02.jnpr.net (10.104.9.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.30; Fri, 24 Feb 2023 01:34:54 -0600 Received: from p-mailhub01.juniper.net (10.104.20.6) by p-exchbe-eqx-02.jnpr.net (10.104.9.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.30 via Frontend Transport; Fri, 24 Feb 2023 01:34:54 -0600 Received: from kaos.jnpr.net (kaos.jnpr.net [172.23.255.201]) by p-mailhub01.juniper.net (8.14.4/8.11.3) with ESMTP id 31O7YsuP001227; Thu, 23 Feb 2023 23:34:54 -0800 (envelope-from sjg@juniper.net) Received: by kaos.jnpr.net (Postfix, from userid 1377) id 9FF5C2115A; Thu, 23 Feb 2023 23:33:54 -0800 (PST) Received: from kaos.jnpr.net (localhost [127.0.0.1]) by kaos.jnpr.net (Postfix) with ESMTP id 9CB18212B7; Thu, 23 Feb 2023 23:33:54 -0800 (PST) To: Mark Millard CC: Bryan Drewery , Current FreeBSD , Peter , Subject: Re: FYI: Why META_MODE rebuilds so much for building again after installworld (no source changes) In-Reply-To: <21F1E7D4-D709-4DFF-98D6-51795B9BB291@yahoo.com> References: <3345EBA5-A09C-4E3F-B94D-39F57F56BDBB@yahoo.com> <73088.1611797582@kaos.jnpr.net> <10819.1677108389@kaos.jnpr.net> <76FA98EF-6184-4D7E-A01F-0EE8117D0D10@yahoo.com> <29887.1677115125@kaos.jnpr.net> <27790339-240F-4C97-97C7-38AFD8DE03D5@yahoo.com> <7FB6F619-6E71-4075-8A6C-573564371DD5@yahoo.com> <2655.1677134606@kaos.jnpr.net> <242BB478-B2FE-4BCC-A56E-098F3FEB3EE1@yahoo.com> <42586.1677183334@kaos.jnpr.net> <30.1677189836@kaos.jnpr.net> <1B5FCF8A-0DFD-4246-8464-65A44A40529F@yahoo.com> <93460.1677202939@kaos.jnpr.net> <17672.1677210880@kaos.jnpr.net> <21F1E7D4-D709-4DFF-98D6-51795B9BB291@yahoo.com> Comments: In-reply-to: Mark Millard message dated "Thu, 23 Feb 2023 20:57:20 -0800." From: "Simon J. Gerraty" X-Mailer: MH-E 8.6+git; nmh 1.7.1; GNU Emacs 28.1 List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <98794.1677224034.1@kaos.jnpr.net> Date: Thu, 23 Feb 2023 23:33:54 -0800 Message-ID: <30.1677224034@kaos.jnpr.net> X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM12FT095:EE_|BLAPR05MB7490:EE_ X-MS-Office365-Filtering-Correlation-Id: 0115cdbb-51bc-4147-3585-08db16399ff8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9JBzbuhOzkA+RR7iANWFqj7e8U4XDAl4s7kSfjRt/bSJXY3yT80BvAGNUzCW2bSV1PYmh3f5heKncE12JaJx02nDS2K/A8gZ9WrvXMkMJQjlGgyi5S0Lb5ELvRJ24TIkcxjJPYwzF5PmEPmV61K/z/mqDrTbIn8XkeKJ7gSXleWwIAs7cDmf+hbliDauEHd/j7lAs/qhvVK7ixZcT2qjUiG582CbJl4fWjiUpyNiLZhEbQ4hAAWMeYXfEVYdOKuynZX3FHiSCu7P+n9jQjWGVHq6RDhCxzyK+LxKKIjVeNTMdr1AY1DwLVyLD7mqgksVvVliczKHz/ckjGQwswQaLiGVDGuh/wZ7nytuXQkC3SOf7fq55rLLXY3xqcGOyO+jJ3x5zjYNu4YddVIWFtqIFVKZBf9o2FVR3UrDznQ8A4cgxvMJ7liLiqIi9JuUZo/7+AtspVpe0yDZinP2cFIqiRi5jXN7K2nJw2fvnwgkK9jRD2I12Xm+X/ludDosvTGe1pGFdGGeFjW9lnVWt2Z1cwD42S0MFk0AK5foWUz9lNgmlxN4RQ5/muUzkbYNbvzmuq/chptQWbrg/o8wnZM1ygBchJBDIoH4dD7seTsI7bYzUjxNpc4GKRy3cDFrn4JKOIO+QriTjuoqpD3T1tEuy1eQdPZRelixK33d/MFJ/PPrg03v/+i8an/7uQ8PJyoWVqVR1BlUsoI0NZHB/DJRo5rSOQIoQJmxpstqEFGg3YA= X-Forefront-Antispam-Report: CIP:66.129.239.15;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:p-exchfe-eqx-02.jnpr.net;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(396003)(136003)(39860400002)(346002)(376002)(451199018)(40470700004)(36840700001)(46966006)(26005)(6266002)(9686003)(186003)(107886003)(36860700001)(47076005)(82310400005)(356005)(40460700003)(86362001)(40480700001)(55016003)(81166007)(82740400003)(7126003)(336012)(41300700001)(70206006)(70586007)(4326008)(8676002)(6916009)(2906002)(8936002)(5660300002)(7696005)(478600001)(54906003)(316002)(19627235002)(36900700001);DIR:OUT;SFP:1102; X-OriginatorOrg: juniper.net X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2023 07:34:55.5066 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0115cdbb-51bc-4147-3585-08db16399ff8 X-MS-Exchange-CrossTenant-Id: bea78b3c-4cdb-4130-854a-1d193232e5f4 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bea78b3c-4cdb-4130-854a-1d193232e5f4;Ip=[66.129.239.15];Helo=[p-exchfe-eqx-02.jnpr.net] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM12FT095.eop-nam12.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR05MB7490 X-Proofpoint-GUID: gI8BaIBOqA2RIg-fhiyfsJjpx6v3zOay X-Proofpoint-ORIG-GUID: gI8BaIBOqA2RIg-fhiyfsJjpx6v3zOay X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22 definitions=2023-02-24_04,2023-02-23_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_spam_notspam policy=outbound_spam score=0 bulkscore=0 suspectscore=0 impostorscore=0 mlxscore=0 malwarescore=0 spamscore=0 phishscore=0 mlxlogscore=999 clxscore=1015 adultscore=0 priorityscore=1501 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302240061 X-Rspamd-Queue-Id: 4PNMB01pLLz3F48 X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:22843, ipnet:67.231.152.0/24, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N Mark Millard wrote: > > Perhaps you want to be using > > > > .MAKE.META.IGNORE_PATHS+= ${MAKEOBJDIRPREFIX}/tmp/legacy/usr > > or is that ${MAKEOBJDIRPREFIX}/${TARGET}.${TARGET_ARCH}/tmp/legacy/usr > > > > I had started with trying to use MAKEOBJDIRPREFIX but it > appeared to end up with an empty expansion in something > I'd looked at, making the addition to > .MAKE.META.IGNORE_PATHS ineffective. > > But with the .info lines in place, I should probably > recheck an example with ${MAKEOBJDIRPREFIX} in it. > (Expecting .MAKE.META.IGNORE_PATHS to not work but > showing what happens for the MAKEOBJDIRPREFIX use.) > This turns out to be different for "modules" vs. > "pure kernel". I start with a "modules" example > below. Yes, if the value of MAKEOBJDIRPREFIX isn't consistent that's going to cause problems (I'd call it a bug). If so don't use MAKEOBJDIRPREFIX directly, set some other variable and export that. Hmm src.sys.obj.mk plays games with MAKEOBJDIRPREFIX so that's probably not a good option. Perhaps: diff --git a/share/mk/src.sys.obj.mk b/share/mk/src.sys.obj.mk index 3b48fc3c5514..3c7e570dbdbd 100644 --- a/share/mk/src.sys.obj.mk +++ b/share/mk/src.sys.obj.mk @@ -67,6 +67,9 @@ SB_OBJROOT?= ${SB}/obj/ OBJROOT?= ${SB_OBJROOT} .endif OBJROOT?= ${_default_makeobjdirprefix}${SRCTOP}/ +# save the value before we mess with it +_OBJROOT:= ${OBJROOT:tA} +.export _OBJROOT .if ${OBJROOT:M*/} != "" OBJROOT:= ${OBJROOT:H:tA}/ .else and then something like? .MAKE.META.IGNORE_PATHS += ${_OBJROOT}/${MACHINE}.${MACHINE_ARCH}/tmp/legacy/usr > and still not right (MAKEOBJDIRPREFIX expanded > to empty). See above > I still do not know notation to make .MAKE.META.IGNORE_PATHS > effective for the specific list of tmp/legacy/usr/sbin/* > examples in question. > > Effectively, it appears that the coverage of > .MAKE.META.IGNORE_PATHS is just incomplete (via the > notational constraints it is used within). No, your problem has nothing to do with .MAKE.META.IGNORE_PATHS but with the build's lack of a consistent definition of OBJTOP or OBJROOT or whatever you want to call it. You could I guess take note of .OBJDIR when setting .MAKE.META.IGNORE_PATHS and if it match */sys/compile* and tweak things accordingly so you actually get the value you want. The messing about with MAKEOBJDIRPREFIX has been around so long I don't know how you could go about fixing it at this point. FWIW in our build we make a clear distinction between things build for the "host" (all the tools you care about are actually host tools not target tools I think), and those built for a target. Everything built for host is found under ${HOST_OBJTOP} and everything for the targets is under ${OBJTOP} which we define consistently mk -V OBJTOP -V HOST_OBJTOP:tA /var/obj/FreeBSD/main/obj/amd64.amd64 /var/obj/FreeBSD/main/obj/freebsd13-amd64 (the :tA is needed there so you can see the relationship - HOST_OBJTOP comes from environment) mk -n buildworld -V OBJTOP Setting legacy build env... /var/obj/FreeBSD/main/obj/h/sjg/work/FreeBSD/main/src/amd64.amd64 and as you know, that value does not remain consistent thoughout the tree which makes it of questionable value. --sjg