From nobody Wed Feb 08 00:27:17 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PBLSK6Pqcz3p9BY for ; Wed, 8 Feb 2023 00:28:01 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PBLSK2gXhz44P7 for ; Wed, 8 Feb 2023 00:28:01 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ej1-x62c.google.com with SMTP id p9so1267646ejj.1 for ; Tue, 07 Feb 2023 16:28:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=y23A1klRIYaAqfBZSq3nkEuB4LNbYJcEIcks07DdS54=; b=bZ7SG+0Hf/zzv3s76JYBOytW0SsuI8/h0Nsl0lK27Zhb8F/3DVGuc5c9pMkLD7aenh 5RFVa4l1VdruoDRxniPjoXygJa7TSqog1Fe0YUMvlQ79WvE4O6ekV8JBQ/wBm1Xxt/Qe jb5vaX7H+o4pqqco5yiV7kvvOLrQb2x3oc0RD+3jkZFFvxZga71YMAGs+mZ8jNdDfp5R oYhxCiPnq8mLF+4NRIgUx3db67M8sM3KwcCRMI+jwsnwnDDTieHrzVNylF+8u+7ZLRSW OONQndoBoE4y47sR0Mbuw9RNQStlLEmLIeJMFt5/o66M9K5ja/ylVsTfdDINyExpPywR /lCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=y23A1klRIYaAqfBZSq3nkEuB4LNbYJcEIcks07DdS54=; b=QB7A1t1bRqmJi/GooxJjbBUP7LBtYRtU3GznjvPliWQLm4K+9BPPOe2uwbyB9DOANw hZL/wq6XW4c8oJwX1rkoBZPUo/zpXq/pxivskXg6Bovm5amzEkYXQAg5f8LElQGtMOic vAK6lcO5OOgfPEiZqBt+fWo6WV93p/GK6wgGLoXS5ELPD6dIFdYjga8LeR25XypHjUI/ JFcmzcxLhYu/k+yaeOrrg1t1fpDcA7YLMPvW1ZNx5w9d6G+yFugPjRHkl2aB82na3SzZ DctyRCxsHei0WgWhmWIjUflG291BLHI9bX3Tk7NHgALhPeWc1NW4JnKv/2rD4puj34wx ttwg== X-Gm-Message-State: AO0yUKWXfNb2uJERF6hu4NF/C0TgLuFM9zztPTBt5qv2IWtJ0TWR3/X2 Hn+IEUbuVO1IPKKfkhW7yjYFI5Iz92lncexeWoCA7A== X-Google-Smtp-Source: AK7set8pkTyhKpKVIV5ic9GYgw+rBWrEIdnn+k6hqMw0cm1dUPo7ea8AKGh/zzQ1UT68mfssHOHrWf0FZbUwaK2w5TA= X-Received: by 2002:a17:906:2f17:b0:888:c14e:70b6 with SMTP id v23-20020a1709062f1700b00888c14e70b6mr1375873eji.306.1675816079243; Tue, 07 Feb 2023 16:27:59 -0800 (PST) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 References: In-Reply-To: From: Warner Losh Date: Tue, 7 Feb 2023 17:27:17 -0700 Message-ID: Subject: Re: buildkernel avoidably building modules specified in the config To: Mateusz Guzik Cc: FreeBSD Current Content-Type: multipart/alternative; boundary="0000000000001cd5a105f425562b" X-Rspamd-Queue-Id: 4PBLSK2gXhz44P7 X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N --0000000000001cd5a105f425562b Content-Type: text/plain; charset="UTF-8" On Tue, Feb 7, 2023, 5:20 PM Mateusz Guzik wrote: > ... then a lot of the code ends up being compiled twice for no good reason. > > This popped up again as clang 15 emits a ton of warnings vs K&R funcs. > > I don't know how this works internally, is it really a big problem to sort > out? > I figured config(8) could generate a bunch of WITHOUT_ of similar, but I > guess > sys/modules/Makefile will have to be patched to support it, which it > only does for some modules at the moment. > > I don't have any interest in working on it, so just bringing this up > for interested. > Yea... it's on the list that config.ng would do... At one point modules and kernel .o files were built differently which precluded a number of Makefile hacks. Warner Warner > --0000000000001cd5a105f425562b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Tue, Feb 7, 2023, 5:20 PM Mateusz Guzik <mjguzik@gmail.com> wrote:
... then a lot of the code ends up being compil= ed twice for no good reason.

This popped up again as clang 15 emits a ton of warnings vs K&R funcs.<= br>
I don't know how this works internally, is it really a big problem to s= ort out?
I figured config(8) could generate a bunch of WITHOUT_ of similar, but I gu= ess
sys/modules/Makefile will have to be patched to support it, which it
only does for some modules at the moment.

I don't have any interest in working on it, so just bringing this up for interested.

Yea... it's on the list that config.ng would do... At on= e point modules and kernel .o files were built differently which precluded = a number of Makefile hacks.=C2=A0 =C2=A0

<= div dir=3D"auto">Warner=C2=A0

Warner
--0000000000001cd5a105f425562b--