From nobody Fri Dec 29 13:37:43 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T1mfH3PV6z56759 for ; Fri, 29 Dec 2023 13:37:59 +0000 (UTC) (envelope-from tuexen@freebsd.org) Received: from drew.franken.de (mail-n.franken.de [193.175.24.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.franken.de", Issuer "Sectigo RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T1mfH0wNvz3dG6; Fri, 29 Dec 2023 13:37:59 +0000 (UTC) (envelope-from tuexen@freebsd.org) Authentication-Results: mx1.freebsd.org; none Received: from smtpclient.apple (unknown [IPv6:2a02:8109:1140:c3d:d8cb:c5d8:57fa:1e9b]) (Authenticated sender: micmac) by drew.franken.de (Postfix) with ESMTPSA id DBE10721E2817; Fri, 29 Dec 2023 14:37:52 +0100 (CET) Content-Type: text/plain; charset=utf-8 List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.300.61.1.2\)) Subject: Re: devel/nspr: Fails to build on 1500008 5f71f9636efa From: tuexen@freebsd.org In-Reply-To: Date: Fri, 29 Dec 2023 14:37:43 +0100 Cc: Nuno Teixeira , FreeBSD CURRENT Content-Transfer-Encoding: quoted-printable Message-Id: References: <9EE91B0D-6CFB-464E-AB9C-3A15D77D55FB@freebsd.org> To: Dimitry Andric X-Mailer: Apple Mail (2.3774.300.61.1.2) X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, T_SCC_BODY_TEXT_LINE autolearn=disabled version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mail-n.franken.de X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:680, ipnet:193.174.0.0/15, country:DE] X-Spamd-Bar: ---- X-Rspamd-Queue-Id: 4T1mfH0wNvz3dG6 > On Dec 29, 2023, at 13:50, Dimitry Andric wrote: >=20 > The problem is really that our kernel headers (those under sys/) = require C99. The only thing that = https://cgit.freebsd.org/src/commit/?id=3Da8b70cf26030d68631200619bd1b0ad3= 5b34b6b8 did was move two static inline functions from = sys/netinet/tcp_var.h to sys/netinet/tcp.h, and it looks like the former = header is never directly included by ports. The latter is, so those = ports should be switched to C99, or the sys/netinet/tcp.h header should = be fixed to use __inline instead. Any preferred way? Maybe using __inline is the least intrusive way: https://reviews.freebsd.org/D43231 Best regards Michael >=20 > -Dimitry >=20 >> On 29 Dec 2023, at 13:30, Nuno Teixeira wrote: >>=20 >> (...) >> -ansi =3D=3D Same as -std=3Dc89 >>=20 >> So it seems correct to remove it when -std=3Dc99 is used. >>=20 >> Nuno Teixeira escreveu no dia sexta, 29/12/2023 = =C3=A0(s) 12:03: >>=20 >>=20 >>=20 >> I think we have two options: >> 1. Build the ports with a C version of at least C99. >>=20 >> - Adding USE_CSTD=3Dc99 >> - Removing -ansi: >> --- configure.orig 2023-12-29 11:54:11 UTC >> +++ configure >> - CFLAGS=3D"$CFLAGS $(DSO_CFLAGS) -ansi -Wall" >> + CFLAGS=3D"$CFLAGS $(DSO_CFLAGS) -Wall" >>=20 >> Fix build. >>=20 >> Notes: >>=20 >> Adding USE_CSTD=3Dc99 doesn't fix build by itself like we seen on = some ports that were fixed by it. >>=20 >> Something have changed from current 1500007 to 1500008. >>=20 >> 2. Remove the inline from tcp_[gs]et_flags(). >>=20 >> Best regards >> Michael >>> --=20 >>> Nuno Teixeira >>> FreeBSD Committer (ports) >>=20 >>=20 >>=20 >> --=20 >> Nuno Teixeira >> FreeBSD Committer (ports) >>=20 >>=20 >> --=20 >> Nuno Teixeira >> FreeBSD Committer (ports) >=20