From nobody Fri Dec 29 12:50:34 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T1lbc1pRpz56375 for ; Fri, 29 Dec 2023 12:50:36 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T1lbc1N83z3Wpq; Fri, 29 Dec 2023 12:50:36 +0000 (UTC) (envelope-from dim@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1703854236; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/Yamf2xvvTFNXiQcgypQOIqK9DDmU00RTlIcOUedJwY=; b=PqmqcThlm/f3jkXhpKg6CpgHL1ZMatYAA8p/+XuTitWwjm6JK19y+8AHG68jNUe5P1Ew30 wU5JIaBuj0lRkNYZF6BDOqcJOctU9RujKQ7rk5xhsjFQHIwuDBMKbXFTJnY0n8Pgi8ipHu R7bjNmnlPAHhXf7Zt93ZEdB/NbHjAwfAsfrLIWu+dL57DamWDraFgwoQ8mmiGHdGGf/g4v 6VpNTUOxsCQ8Q6++RnsA4k3pgLBfCAT66dkBmCls17iip2206W2DUzQaUJjjmPfcDS0jPG MjkxhUyFpUUmMSz2/Qpt1XCqoEJdbMweHgcsNGddVpVQW8ZTGcgtpCnqCDzUAA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1703854236; a=rsa-sha256; cv=none; b=Svlohi3CjQLRW3iy2r+72jqiToeD36qvOTaU+xesiQvuyPlB/6+8QhdnyXhXjL3v5S6XkH tG5jO7tmmgWXdjOfMJawlYThyc+uQGAFaFSXEsznKpRrInK6GVrOtFTf7janVqEyV3CHnY OHfnd1ATjmOGR+/vlrArDv4qBys6sJNNWO2IhOZjVTKHrSkglR8rhl1TjhQ+h38D3uPJTy ioQ0I9e25yso2Ds5uRIZ9bs69WZrhwR9Fn86yCGy2UHRvTGBb+RK8y33MFm9nQe5nvQEaM Pv6IO1UrTmK09vbFEpe/uAOPqgwj3Qy9BoXf4kdhC6xAcNrHRaDTlEjLY691FA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1703854236; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/Yamf2xvvTFNXiQcgypQOIqK9DDmU00RTlIcOUedJwY=; b=HKnLDMb4h9agjp6mWFTnlPHjGnmL7vn9CyPD+WYwiWuv4XhR72CRp1sF2OlwQMMpGbVCu0 6TvS+aBNJm1VjAe4WURYLglMNgu5gaqUGiL9hAenINGCAr9ZULGhTxxTtEvx7jiH0wP5u+ r8SAGjEoywc8bDMEJBW9KnqtGsduSb1NAdvXrqsleaP8QwwRTghpQOd1Z7ATwItftW0+I/ k/z4Em9PjQQWMybQdNxSUjRAVGCBawxuwLxQEgVISMnVbBzRjY70KZtRD5o2CtBBuxAlKm YsdgVcq4HLBmaLH4gxXTTWX3XksCs80B3d812hYyz6YUnzVSbuzRROqoToA73g== Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "tensor.andric.com", Issuer "R3" (verified OK)) (Authenticated sender: dim) by smtp.freebsd.org (Postfix) with ESMTPSA id 4T1lbb6qFzz10Cv; Fri, 29 Dec 2023 12:50:35 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from smtpclient.apple (longrow.home.andric.com [192.168.0.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id BE28642C30; Fri, 29 Dec 2023 13:50:34 +0100 (CET) Content-Type: text/plain; charset=utf-8 List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) Subject: Re: devel/nspr: Fails to build on 1500008 5f71f9636efa From: Dimitry Andric In-Reply-To: Date: Fri, 29 Dec 2023 13:50:34 +0100 Cc: tuexen@freebsd.org, FreeBSD CURRENT Content-Transfer-Encoding: quoted-printable Message-Id: References: <9EE91B0D-6CFB-464E-AB9C-3A15D77D55FB@freebsd.org> To: Nuno Teixeira X-Mailer: Apple Mail (2.3731.700.6) The problem is really that our kernel headers (those under sys/) require = C99. The only thing that = https://cgit.freebsd.org/src/commit/?id=3Da8b70cf26030d68631200619bd1b0ad3= 5b34b6b8 did was move two static inline functions from = sys/netinet/tcp_var.h to sys/netinet/tcp.h, and it looks like the former = header is never directly included by ports. The latter is, so those = ports should be switched to C99, or the sys/netinet/tcp.h header should = be fixed to use __inline instead. -Dimitry > On 29 Dec 2023, at 13:30, Nuno Teixeira wrote: >=20 > (...) > -ansi =3D=3D Same as -std=3Dc89 >=20 > So it seems correct to remove it when -std=3Dc99 is used. >=20 > Nuno Teixeira escreveu no dia sexta, 29/12/2023 = =C3=A0(s) 12:03: >=20 >=20 >=20 > I think we have two options: > 1. Build the ports with a C version of at least C99. >=20 > - Adding USE_CSTD=3Dc99 > - Removing -ansi: > --- configure.orig 2023-12-29 11:54:11 UTC > +++ configure > - CFLAGS=3D"$CFLAGS $(DSO_CFLAGS) -ansi -Wall" > + CFLAGS=3D"$CFLAGS $(DSO_CFLAGS) -Wall" >=20 > Fix build. >=20 > Notes: >=20 > Adding USE_CSTD=3Dc99 doesn't fix build by itself like we seen on some = ports that were fixed by it. >=20 > Something have changed from current 1500007 to 1500008. >=20 > 2. Remove the inline from tcp_[gs]et_flags(). >=20 > Best regards > Michael > > --=20 > > Nuno Teixeira > > FreeBSD Committer (ports) >=20 >=20 >=20 > --=20 > Nuno Teixeira > FreeBSD Committer (ports) >=20 >=20 > --=20 > Nuno Teixeira > FreeBSD Committer (ports)