From nobody Fri Dec 29 12:30:32 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T1l8j1fmVz561ct for ; Fri, 29 Dec 2023 12:30:45 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T1l8j11wNz3T48; Fri, 29 Dec 2023 12:30:45 +0000 (UTC) (envelope-from eduardo@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1703853045; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Apds7VP5RE+jQTiLaVP7/6aAgFfZ9nwsJBpGJypTXqc=; b=sgj5hqLCRO6vOKSJziXAL9tXb+bPl4GWIj4zvuszVHy6BUBe9MBp81UFCuUJ+jUD3KVp86 iVPZb2zbdJ5GXsWUUGC6etvCUo3DDnZMi32OZmsvmyDaFWK9uxHpeDMA0lCjsycF1NAoHI 2zZVC4Ildo0FIzfLt8WY3S5uCpQIWdm6n5veAMBwTFS1b6X5a81neW03aZaAQmCsUm+tV2 CFkrcEnWZUQxZZkCWThsH8u3YF2ukltlfaYeF4vKwOnVEjJLnSyeYOxymdGPx3Jz1X5TnF M/t6XOt0P7XU2ZtrVnUwJS10MyANKQhp0Wyo225JzMG1NnmjGvnG24DDMP5Igg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1703853045; a=rsa-sha256; cv=none; b=rufIc27oBEaJh4IG6Ya88DZpI14xnxc8p2n4Ltk9UD+Ehnuv+lDF/ik9Nzmq5Hfzyl3v0o sCV9SuLSuKEO5hQtHY186nahvsffrWbYxNQLEYU6NbbV740RPU9aEGH7wW+C3RgFD+1AH2 W8sjrnYixTaHhbpcWsLjB6sSZRCsTRE9LZaB71P3J5hPsPu9q4inBl+hwEI+Hmv/cJ2Wcj 3VsMGaJDcKF6BuiXb0PiUL8i3upICq0ndCZhETHR7O7v42+98ohO/H9yD6RdK99yD/Vfke gtfKjf6zw5QlzG/2w/o03H0zGYYV+Qdbi1Ab4yWABYXrPNtsH4TM145cThJHaw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1703853045; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Apds7VP5RE+jQTiLaVP7/6aAgFfZ9nwsJBpGJypTXqc=; b=BQeJyqwXVjNpnhTDWantf8s9V0lC8lnUMDo+OhTHJKmOYmDdtVNjhJGoSMC7X40rF+wNFt 7U8rDveHQ1eYKpIzhlyNuGs8sDaSGH6DzgOJTsKBuyO69nxqFCtiWb+ade+bykmqcOMfaB JcVoQ/rANGyFqK6LN5U0K+29sFHAc4rOce++T1NsHQFhQn0mHXnd1b7Q77fY05F2YfzJqG 3H1Fww1xoDKCdNgvVnj0VWoJNm7a1qcMiIY7Wwk+79UMTqjKkzS+n/Gr7+enbCkYXj+/os v+JdvZFym2vNuwXcxkk1UybY1IwLxb+MVjwT4NggL1WYwPhHFSAHyI1W2VKWNA== Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: eduardo) by smtp.freebsd.org (Postfix) with ESMTPSA id 4T1l8h75cYzxk1; Fri, 29 Dec 2023 12:30:44 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: by mail-qt1-f178.google.com with SMTP id d75a77b69052e-427b8775aebso38520451cf.1; Fri, 29 Dec 2023 04:30:44 -0800 (PST) X-Gm-Message-State: AOJu0Yw+p5hkakqT3s9LAG8LnRYnf9VautAIc4t3DmcKn4Sj6oC4T1M3 ocO7sZQvoGrPNeJFs+GhiBRtPUUsesieWyrsDoY= X-Google-Smtp-Source: AGHT+IE0AZTD9BZN4ec2RmV0gUrKjAoaD6fScxNk2dsr7qPE2UKJhh/2DF/dyiG9ddvoi+NrSLmkOkmchFP1lAXYPM8= X-Received: by 2002:a05:622a:491:b0:425:4042:f45b with SMTP id p17-20020a05622a049100b004254042f45bmr16993981qtx.63.1703853044391; Fri, 29 Dec 2023 04:30:44 -0800 (PST) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 References: <9EE91B0D-6CFB-464E-AB9C-3A15D77D55FB@freebsd.org> In-Reply-To: From: Nuno Teixeira Date: Fri, 29 Dec 2023 12:30:32 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: devel/nspr: Fails to build on 1500008 5f71f9636efa To: tuexen@freebsd.org Cc: FreeBSD CURRENT Content-Type: multipart/alternative; boundary="00000000000075e5aa060da533ac" --00000000000075e5aa060da533ac Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable (...) -ansi =3D=3D Same as -std=3Dc89 So it seems correct to remove it when -std=3Dc99 is used. Nuno Teixeira escreveu no dia sexta, 29/12/2023 =C3= =A0(s) 12:03: > > > > I think we have two options: >> 1. Build the ports with a C version of at least C99. >> > > - Adding USE_CSTD=3Dc99 > - Removing -ansi: > --- configure.orig 2023-12-29 11:54:11 UTC > +++ configure > - CFLAGS=3D"$CFLAGS $(DSO_CFLAGS) -ansi -Wall" > + CFLAGS=3D"$CFLAGS $(DSO_CFLAGS) -Wall" > > Fix build. > > Notes: > > Adding USE_CSTD=3Dc99 doesn't fix build by itself like we seen on some po= rts > that were fixed by it. > > Something have changed from current 1500007 to 1500008. > > > >> 2. Remove the inline from tcp_[gs]et_flags(). >> >> Best regards >> Michael >> > -- >> > Nuno Teixeira >> > FreeBSD Committer (ports) >> >> > > -- > Nuno Teixeira > FreeBSD Committer (ports) > --=20 Nuno Teixeira FreeBSD Committer (ports) --00000000000075e5aa060da533ac Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
(...)
-ansi =3D=3D Same as -std=3Dc89
=

So it seems correct to remove it when -std=3Dc99 is use= d.

Nuno Teixeira <eduard= o@freebsd.org> escreveu no dia sexta, 29/12/2023 =C3=A0(s) 12:03:
<= div dir=3D"ltr">


I think we have two options:
1. Build the ports with a C version of at least C99.
<= br>
- Adding USE_CSTD=3Dc99
- Removing -ansi:
--- co= nfigure.orig =C2=A0 =C2=A0 2023-12-29 11:54:11 UTC
+++ configure
- = =C2=A0 =C2=A0CFLAGS=3D"$CFLAGS $(DSO_CFLAGS) -ansi -Wall"
+ = =C2=A0 =C2=A0CFLAGS=3D"$CFLAGS $(DSO_CFLAGS) -Wall"
Fix build.

Notes:

=
Adding USE_CSTD=3Dc99 doesn't fix build by itself like we seen on = some ports that were fixed by it.

Something ha= ve changed from current 1500007 to 1500008.

=C2=A0=
2. Remove the inline from tcp_[gs]et_flags().

Best regards
Michael
> --
> Nuno Teixeira
> FreeBSD Committer (ports)



--
Nuno Teixeira
FreeBSD Committ= er (ports)


--
Nuno Teixeira
FreeBSD Committ= er (ports)
--00000000000075e5aa060da533ac--