From nobody Fri Dec 29 12:03:07 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T1kY41dqCz55yd8 for ; Fri, 29 Dec 2023 12:03:20 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T1kY40gXqz3Q6Z; Fri, 29 Dec 2023 12:03:20 +0000 (UTC) (envelope-from eduardo@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1703851400; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bGBi13D/ILV40gml8v1pd0fCMWX/0uERrjpoH3rXDK4=; b=tzfrlZ6V5do2JEW2mNFESUcOf0/mMMqrlMSzZK+llKojyl7vLZLWSowttZQv1a6IzOCVX8 QXxQsM/lpmuUrJv2RgfAcyoWY40Ztys5j7TWd79nGt2mjXxobvBlYWDg7CYUOz6z0la5uY dtySUsNxQ3KQiQJLjzey7YurCYEVLFhJt8cECdENnfT2gE0J+ofPEz1WF1RBZcA0/6Pjsv XFPzUQ3c/h9V0fbOJZTI6Rvic5Z9ZsOAWqMZQFglGdacq8Q6Gj467VbcwQAAvtqk94SVw8 SVtv4DOgAw7Pbb5op5MMyR8Apd9TVgdyRSPIrj5GWBohvr4sTBSEfCAiW9C/tw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1703851400; a=rsa-sha256; cv=none; b=fR5FoKVytYPPy/LBpHCysJv6x59gTDf9NliH5JfPhVrcuyIjmRuF8wZc0LcP3Ul7FdYHY6 vnJ8Utx7zeSWnyxMiHJhKo/HM2CBB65BzhV4KArqaoGqwbw5BpNa0sZh6IZBwwG45TdYwE R1vz3nMbU7UsQGKdiZYl1i3KGjpNJNFQwiK7QuPR8SmrUxTdp0mYWNr7MrqTLdRC7SOxW6 RSZPm0dNJCcpkUshwtUr0WJDMZ0wOlby371gngII4xnp0SEc1ffAr/8CU9L4SrCBrUEQjN j3OyPcIlboVCbGB0pSe8pOn+T0ofwyfdiCPPJgMKJ8SFeUc6vzF/o3ImG5mQaA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1703851400; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bGBi13D/ILV40gml8v1pd0fCMWX/0uERrjpoH3rXDK4=; b=XeSmaCXMm002U0ET9qlto5pZoloTYIzrGpP2xTP46qL9zu/jaXlHe3Ms9kw/KKXaHvLZTC g21A/n2GK1xEIrGdiO4ltS0FoDqvvJ3zxnRYS+ANc1nabvNRahTYa4OiIoOWAOhYOtC6ug L4SVOzgtjQbQd42esond7s3GZqva4pKxrrQDLaiGDqLlc7r98qJNAh2UIriHrrt4qX2u6P BVxZJXDa2O/LhYrn0W7pkdKByuB2YyBnestGoowUmJkX6JuHfkKoo7ATbJkkFnUXV9K4BO uqwPRx8ihtI8CB8t8bt6id23RDX04WTsikRCAtKFDfOkMC+4zyA9R1qr8Gq2sg== Received: from mail-oo1-f50.google.com (mail-oo1-f50.google.com [209.85.161.50]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: eduardo) by smtp.freebsd.org (Postfix) with ESMTPSA id 4T1kY36jwZzxYV; Fri, 29 Dec 2023 12:03:19 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: by mail-oo1-f50.google.com with SMTP id 006d021491bc7-5945fef58caso2717762eaf.2; Fri, 29 Dec 2023 04:03:19 -0800 (PST) X-Gm-Message-State: AOJu0Yx8VBkGPzo+v4F4ciJ+zlsHLIeX/E0xZru46/VYxz1pc4BWmdEB UgvRQAMYG6tQ48g8F8q6M4tV2oihW52unEuX+yA= X-Google-Smtp-Source: AGHT+IHy+L/2r2N1egd6J2jqXqNULnidJz5pZZc7D/lUJ8AC/Vn+0jNrhEJAL3mnjsigpFVR2ZEW1/xq5qnMF7JXlBk= X-Received: by 2002:a05:6358:7e9e:b0:175:b19:8b86 with SMTP id o30-20020a0563587e9e00b001750b198b86mr4148649rwn.13.1703851399046; Fri, 29 Dec 2023 04:03:19 -0800 (PST) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 References: <9EE91B0D-6CFB-464E-AB9C-3A15D77D55FB@freebsd.org> In-Reply-To: <9EE91B0D-6CFB-464E-AB9C-3A15D77D55FB@freebsd.org> From: Nuno Teixeira Date: Fri, 29 Dec 2023 12:03:07 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: devel/nspr: Fails to build on 1500008 5f71f9636efa To: tuexen@freebsd.org Cc: FreeBSD CURRENT Content-Type: multipart/alternative; boundary="00000000000063ea03060da4d1d0" --00000000000063ea03060da4d1d0 Content-Type: text/plain; charset="UTF-8" I think we have two options: > 1. Build the ports with a C version of at least C99. > - Adding USE_CSTD=c99 - Removing -ansi: --- configure.orig 2023-12-29 11:54:11 UTC +++ configure - CFLAGS="$CFLAGS $(DSO_CFLAGS) -ansi -Wall" + CFLAGS="$CFLAGS $(DSO_CFLAGS) -Wall" Fix build. Notes: Adding USE_CSTD=c99 doesn't fix build by itself like we seen on some ports that were fixed by it. Something have changed from current 1500007 to 1500008. > 2. Remove the inline from tcp_[gs]et_flags(). > > Best regards > Michael > > -- > > Nuno Teixeira > > FreeBSD Committer (ports) > > -- Nuno Teixeira FreeBSD Committer (ports) --00000000000063ea03060da4d1d0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
I think we have two options:
1. Build the ports with a C version of at least C99.
<= br>
- Adding USE_CSTD=3Dc99
- Removing -ansi:
--- co= nfigure.orig =C2=A0 =C2=A0 2023-12-29 11:54:11 UTC
+++ configure
- = =C2=A0 =C2=A0CFLAGS=3D"$CFLAGS $(DSO_CFLAGS) -ansi -Wall"
+ = =C2=A0 =C2=A0CFLAGS=3D"$CFLAGS $(DSO_CFLAGS) -Wall"
Fix build.

Notes:

=
Adding USE_CSTD=3Dc99 doesn't fix build by itself like we seen on = some ports that were fixed by it.

Something ha= ve changed from current 1500007 to 1500008.

=C2=A0=
2. Remove the inline from tcp_[gs]et_flags().

Best regards
Michael
> --
> Nuno Teixeira
> FreeBSD Committer (ports)



--
Nuno Teixeira
FreeBSD Committ= er (ports)
--00000000000063ea03060da4d1d0--