From nobody Sat Dec 23 22:17:31 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SyJSf6Wkzz555Kt for ; Sat, 23 Dec 2023 22:17:38 +0000 (UTC) (envelope-from mike@karels.net) Received: from mail2.karels.net (mail2.karels.net [3.19.118.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "freebsd", Issuer "freebsd" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SyJSf4H56z4WCh; Sat, 23 Dec 2023 22:17:38 +0000 (UTC) (envelope-from mike@karels.net) Authentication-Results: mx1.freebsd.org; none Received: from mail2.karels.net (localhost [IPv6:0:0:0:0:0:0:0:1]) by mail2.karels.net (8.17.1/8.17.1) with ESMTP id 3BNMHWSP076511; Sat, 23 Dec 2023 16:17:32 -0600 (CST) (envelope-from mike@karels.net) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=karels.net; s=mail2; t=1703369852; bh=jg1xqSHV0OHDJHAeZsjQDXPmjT67Ig6FrdJVsTBDZ1s=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Mha/73yZ2ZrBqD4WS/PE/CFdB/Ja3LFfTzmFM3nujQZPNRMefXYHO0fFJznwXRbl4 3zYORH5+aJrkWsAuN0KatBwsI9eVUlO3RDb/9/jtupVMe2u5frGEf3hTz8iSMTDBJl abRNf0ucNo04efeTcfbM3jo0bjNPTaPoA8ThSWNr1lMaphcWHI0SAAZ4UgOIoaPO37 oJvrLSGHPvdEORVLYuSJDkS7jVIlabbFt85WpAd6xnbynIMfW7SwIe+yl17Lxl9Nc3 xSvNOdBmO6nP7zSmVR2vS+DSYtfWKZ5cslZfESux/4i6QoZ9RgDzlwJ7Qa1FpW3iF1 dCcUT5FkrreTg== Received: from [10.0.2.130] ([73.62.165.147]) by mail2.karels.net with ESMTPSA id HUH5Hnxch2XdKgEAs/W3XQ (envelope-from ); Sat, 23 Dec 2023 16:17:32 -0600 From: Mike Karels To: Craig Leres Cc: Konstantin Belousov , d@delphij.net, freebsd-current@freebsd.org Subject: Re: Proposal: Disable compression of newsyslog by default Date: Sat, 23 Dec 2023 16:17:31 -0600 X-Mailer: MailMate (1.14r6015) Message-ID: <71C3C779-ACD1-4FF4-A213-5DBCD7707ED7@karels.net> In-Reply-To: References: List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16509, ipnet:3.16.0.0/14, country:US] X-Spamd-Bar: ---- X-Rspamd-Queue-Id: 4SyJSf4H56z4WCh On 23 Dec 2023, at 15:23, Craig Leres wrote: > On 12/23/23 06:52, Konstantin Belousov wrote: >> This is strange change at best. I have no opinion about the disabling= >> of compression of the rotated logs by default, but we already have kno= bs >> to do that. Adding a knob that disables (or enables) other knobs to w= ork >> is weird. > > I totally agree. This moves the compression knob from the config file t= o the command line. And what if the user wants some but not all files to = be compressed? Or wants to use different compression with different log f= iles? Another possibility would be to introduce some simple form of variables i= n newsyslog.conf, replacing J by a variable reference, with the variable being set near the beginning. E.g. V=3Dzstd (or just V=3D for none?) ... $V ... $V Then there would be one global change, and much easier changing of the default. It would also be possible to add /etc/newsyslog.local.conf at t= he beginning, and set variables there, making changes to the default file le= ss painful in the future. >> If you want to change the compression, update the default configuratio= n file. > > I also think this is the best approach. > > Given the current freebsd-update workflow, users will get to deal with = changes to the default newsyslog.conf via mergemaster. > > And having converted a number of systems from newsyslog compression to = zfs compression, just changing the config file is not the only change nee= ded, users will still need to compress/uncompress existing log files. Good point. Although newsyslog could be smart enough to recognize altern= ate suffixes (or none), and rotate the files anyway. Short of that, this sug= gests that a new default config file should specify bzip2, but it would be easy= to localize. Mike