From nobody Sat Dec 23 14:52:47 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Sy6bn39j7z54bsj for ; Sat, 23 Dec 2023 14:53:09 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Sy6bm3tzpz3FgS for ; Sat, 23 Dec 2023 14:53:08 +0000 (UTC) (envelope-from kostikbel@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: from tom.home (kib@localhost [127.0.0.1] (may be forged)) by kib.kiev.ua (8.17.1/8.17.1) with ESMTP id 3BNEqlxa080503; Sat, 23 Dec 2023 16:52:50 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 3BNEqlxa080503 Received: (from kostik@localhost) by tom.home (8.17.1/8.17.1/Submit) id 3BNEqlaq080502; Sat, 23 Dec 2023 16:52:47 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sat, 23 Dec 2023 16:52:47 +0200 From: Konstantin Belousov To: d@delphij.net Cc: freebsd-current@freebsd.org Subject: Re: Proposal: Disable compression of newsyslog by default Message-ID: References: List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=4.0.0 X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-14) on tom.home X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US] X-Spamd-Bar: ---- X-Rspamd-Queue-Id: 4Sy6bm3tzpz3FgS On Fri, Dec 22, 2023 at 11:18:23PM -0800, Xin Li wrote: > Hi, > > Inspired by D42961, I propose that we move forward with disabling the > compression by default in newsyslog, as implemented in > https://reviews.freebsd.org/D43169 > > Historically, newsyslog has compressed rotated log files to save disk space. > This approach was valuable in the early days where storage space was > limited. However, the landscape has changed significantly. Modern file > systems, such as ZFS, now offer native compression capabilities. > Additionally, the widespread availability of larger hard drives has > diminished the necessity for additional compression. Notably, the need to > decompress log files for pattern searches poses a significant inconvenience, > further questioning the utility of this legacy feature. > > In commit 906748d208d3, flags J, X, Y, Z can now indicate that a log file is > eligible for compression rather than directly enforcing it. It allows for a > more flexible approach, wherein the actual compression method can be set to > "none" or specified as one among bzip2, gzip, xz, or zstd. > > Therefore I would propose that we change the default compression setting to > "none" in FreeBSD 15.0. This change reflects our adaptation to the evolving > technological environment and user needs. It also aligns with the broader > initiative to modernize our systems while maintaining flexibility and > efficiency. > > I look forward to your thoughts and feedback on this proposal. This is strange change at best. I have no opinion about the disabling of compression of the rotated logs by default, but we already have knobs to do that. Adding a knob that disables (or enables) other knobs to work is weird. If you want to change the compression, update the default configuration file.