From nobody Tue Aug 22 08:26:22 2023 X-Original-To: current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RVMrS0C5cz4qZ2s for ; Tue, 22 Aug 2023 08:26:32 +0000 (UTC) (envelope-from mm@freebsd.org) Received: from www541.your-server.de (www541.your-server.de [213.133.107.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4RVMrQ5wbhz4pxj; Tue, 22 Aug 2023 08:26:30 +0000 (UTC) (envelope-from mm@freebsd.org) Authentication-Results: mx1.freebsd.org; dkim=none; spf=softfail (mx1.freebsd.org: 213.133.107.7 is neither permitted nor denied by domain of mm@freebsd.org) smtp.mailfrom=mm@freebsd.org; dmarc=none Received: from sslproxy03.your-server.de ([88.198.220.132]) by www541.your-server.de with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qYMiU-0002Qt-HZ; Tue, 22 Aug 2023 10:26:23 +0200 Received: from [192.168.0.32] (helo=webmail.your-server.de) by sslproxy03.your-server.de with esmtpsa (TLSv1.2:ECDHE-RSA-CHACHA20-POLY1305:256) (Exim 4.92) (envelope-from ) id 1qYMiU-000BRP-Px; Tue, 22 Aug 2023 10:26:22 +0200 Received: from [145.243.168.67] ([145.243.168.67]) by webmail.your-server.de (Horde Framework) with HTTPS; Tue, 22 Aug 2023 10:26:22 +0200 Date: Tue, 22 Aug 2023 10:26:22 +0200 Message-ID: <20230822102622.Horde.tUEwNRTMDn0AjOBiO1UB7OX@webmail.your-server.de> From: Martin Matuska To: Alexander Motin Cc: Dag-Erling =?utf-8?b?U23DuHJncmF2?= , current@freebsd.org, Mateusz Guzik Subject: Re: ZFS deadlock in 14 References: <86leeltqcb.fsf@ltc.des.no> <86h6p4s64h.fsf@ltc.des.no> <86a5utrafp.fsf@ltc.des.no> <86350kqokl.fsf@ltc.des.no> <86y1icp95t.fsf@ltc.des.no> <86ttt0p8wv.fsf@ltc.des.no> <197ead1e-210a-6be6-7e24-5c56b14bb777@FreeBSD.org> <86350hpiby.fsf@ltc.des.no> <0fd64567-59cd-9276-cc0c-17a09611f11a@FreeBSD.org> In-Reply-To: <0fd64567-59cd-9276-cc0c-17a09611f11a@FreeBSD.org> User-Agent: Horde Application Framework 5 Content-Type: text/plain; charset=utf-8; format=flowed; DelSp=Yes List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Authenticated-Sender: martin@matuska.de X-Virus-Scanned: Clear (ClamAV 0.103.8/27007/Mon Aug 21 09:40:10 2023) X-Spamd-Result: default: False [-3.09 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.99)[-0.990]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; DMARC_NA(0.00)[freebsd.org]; RCPT_COUNT_THREE(0.00)[4]; FREEFALL_USER(0.00)[mm]; MLMMJ_DEST(0.00)[current@freebsd.org]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; HAS_X_AS(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; R_SPF_SOFTFAIL(0.00)[~all:c]; TO_DN_SOME(0.00)[]; FREEMAIL_CC(0.00)[freebsd.org,gmail.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; R_DKIM_NA(0.00)[]; ASN(0.00)[asn:24940, ipnet:213.133.96.0/19, country:DE]; RCVD_TLS_ALL(0.00)[] X-Spamd-Bar: --- X-Rspamd-Queue-Id: 4RVMrQ5wbhz4pxj Hi Alexander, as 15107 is a prerequisite for 15122, would it be possible to have https://github.com/openzfs/zfs/pull/15107 merged into the OpenZFS zfs-2.2-release branch (and of course later 15122)? If the patches help I can cherry-pick them into main. Cheers, mm Alexander Motin wrote: > On 17.08.2023 15:41, Dag-Erling Smørgrav wrote: >> Alexander Motin writes: >>> Trying to run your test (so far without reproduction) I see it >>> producing a substantial amount of ZIL writes. The range of commits >>> you reduced the scope to so far includes my ZIL locking refactoring, >>> where I know for sure are some deadlocks. I am already waiting for 3 >>> weeks now for reviews and tests for PR that should fix it: >>> https://github.com/openzfs/zfs/pull/15122 . It would be good if you >>> could test it, though it seems to depend on few more earlier patches >>> not merged to FreeBSD yet. >> >> Do you have a FreeBSD branch with your patch applied? > > I don't have a FreeBSD branch, but these two patches apply clean and > build on top of today's FreeBSD main branch: > > https://github.com/openzfs/zfs/pull/15107 > https://github.com/openzfs/zfs/pull/15122 > > And if you still experience the issue, please show all stacks, or at > least include ZFS sync threads. > > -- > Alexander Motin