From nobody Tue Aug 08 03:32:03 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RKdzQ1jZ5z4q4mX for ; Tue, 8 Aug 2023 03:32:18 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RKdzP6NcXz3MMc for ; Tue, 8 Aug 2023 03:32:17 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-lf1-x134.google.com with SMTP id 2adb3069b0e04-4fe0d5f719dso8544780e87.2 for ; Mon, 07 Aug 2023 20:32:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20221208.gappssmtp.com; s=20221208; t=1691465535; x=1692070335; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=HABBHSf709WIgjKGKDSNNbMIwtus8jhTIPUTR6YbJwQ=; b=AfBb+1DMnFGa8PrCYMg2XomYTnxwU/ooP9h8IOatoPyk4RajKFkt1udDfGQKJeoy0/ T7d6ObWRswSBwpPbL2A7sg7h4x39jFE/AvZ28jWAbRsyDDp/DlLNU5RzpfZAeKcy4qec yxqAUBwbgyroZO/k+Px/PtFeQRS70hKT89qSh++/6V1VHjwherSGs//QnYTmH5cBW6Ll Hf3W/sDr89ESG9zWCRiQDP+s/TZw8DzqJHXBpXZz5rMfM0P5/6mEKNcW4LjmXp90oC5T fw3Dfnadwy+2qrt+JhipfqAgLFqwiKRq3PhEjVsLGjJkgo9ihqW9brCOpkF3UumREJeU uTYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691465535; x=1692070335; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HABBHSf709WIgjKGKDSNNbMIwtus8jhTIPUTR6YbJwQ=; b=kIvYzB5Sm9HFWRabWs/DLtomVLsC9Un/lNXhfc6mBa6PFeYLJHtyJH5246ajgYyzxy e0SJfDdxGMFdmLT3Nwjt7REXmjjJscfxr/6aWMmYXyTJJcmB6cKi2nWFymeqNiqrwIsT Q7rsoQLAH0Wp3ZBIlMN71Vr/yzJ1WTADotEPf9ds7DxBQfvwrsFaPBfAuRIANkOLDgUJ 2YSlbQqiu5HiQf89uDo+b9PrQM+XOJwQAnxFKsR2KwX+ZkU3r0cCQlnXcjzoMi67CItG 8w6+5PZOT4XRLDoCbjNhUfmYkldovK/7HS4WIYT/d3jX6S86Gc5BG+LfSLSnyUuobAdl jLJQ== X-Gm-Message-State: AOJu0YzeGAtdir4A4JT5CUL9L0u3S0WTUIhFwinvrftHxLCe6dphEuap zUdW+6nP1E+QQj8KS2KF3K1TqRBJqsKk6ZfXLMi3hKXwB5dvS9Lh X-Google-Smtp-Source: AGHT+IFLITkzChMAdDRuKQlNnBC2r4bjGZ3EIS4if+kiEBC4PPaQTZ7jX25IoWtqF4CoBC6MiERL0X1vHfYLWEZVUO8= X-Received: by 2002:a05:6512:2821:b0:4fb:bef0:948e with SMTP id cf33-20020a056512282100b004fbbef0948emr8263641lfb.5.1691465535032; Mon, 07 Aug 2023 20:32:15 -0700 (PDT) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 References: <20230806225055.bbccc4fc13e41f50ec524621@j.email.ne.jp> <73d081d7-5df6-9fe4-659d-edb191c94be4@aetern.org> In-Reply-To: <73d081d7-5df6-9fe4-659d-edb191c94be4@aetern.org> From: Warner Losh Date: Mon, 7 Aug 2023 21:32:03 -0600 Message-ID: Subject: Re: Jail compile error on CURRENT? To: Yuri Cc: FreeBSD Current Content-Type: multipart/alternative; boundary="0000000000005db60106026102bd" X-Rspamd-Queue-Id: 4RKdzP6NcXz3MMc X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] --0000000000005db60106026102bd Content-Type: text/plain; charset="UTF-8" On Mon, Aug 7, 2023, 5:55 PM Yuri wrote: > James Gritton wrote: > > On 2023-08-07 13:29, Dimitry Andric wrote: > >> On 7 Aug 2023, at 04:50, Yoshihiro Ota wrote: > >>> > >>> Am I the only one seeing this error? > >>> I'm on 12.4-RELEASE amd64 and building CURRENT as of now. > >>> > >>> jaillex.c:2228:43: error: unused parameter 'yyscanner' > >>> [-Werror,-Wunused-parameter] > >>> void *yyalloc (yy_size_t size , yyscan_t yyscanner) > >>> ^ > >>> jaillex.c:2233:58: error: unused parameter 'yyscanner' > >>> [-Werror,-Wunused-parameter] > >>> void *yyrealloc (void * ptr, yy_size_t size , yyscan_t yyscanner) > >>> ^ > >>> jaillex.c:2245:36: error: unused parameter 'yyscanner' > >>> [-Werror,-Wunused-parameter] > >>> void yyfree (void * ptr , yyscan_t yyscanner) > >>> ^ > >>> 6 errors generated. > >>> *** [jaillex.o] Error code 1 > >>> > >> > >> It seems you are not crazy. :) I can reproduce the error, and I think it > >> might be caused by: > >> > >> > https://cgit.freebsd.org/src/commit/?id=086e0149ae56641af245ce472e787c2f67d3aea5 > >> > >> However, as to why this does not result in an error (or even a warning) > >> on -CURRENT, I have no clue. Maybe in the mean time flex in -CURRENT got > >> updated... > > > > That is indeed the culprit. Fortunately, it builds from 13.2-RELEASE, > > so building CURRENT from 12 can be done in two steps. I hate to be the > > reason the update doesn't work directly, but the include capability I > > added to jail(8) requires re-entrant lex, which apparently managed to > > work around the error in 13. They reason it doesn't give a warning BTW > > is these two lines that lex adds: > > > > struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; > > (void)yyg; > > > > That makes yyscanner officially "used" even though its value is never > > actually read. I suspect the version of lex in 12.4-RELEASE doesn't > > have one or both of those lines. > > > > Perhaps you could add such lines to the offending functions yourself, > > and continue the make. Or maybe build (and install) lex on its own > > first; by the time you see this error, there should already be a newer > > version of lex you could pop into place. > > > > There's probably something I should do to make this work better, or > > perhaps some note I should put into UPDATING before 14.0 is released. > > Or there is already a recipe for bootstrapping lex in Makefile.inc1, > though for somewhat older versions; possibly it could be updated for < 13? > > .if ${BOOTSTRAPPING} < 1000033 > When in doubt, adding BOOTSTRAPPING=0 can help...not sure why you'd need to bootstrap lex though... Warner > --0000000000005db60106026102bd Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Mon, Aug 7, 2023, 5:55 PM Yuri <yuri@aetern.org> wrote:
James Gritton wrote:
> On 2023-08-07 13:29, Dimitry Andric wrote:
>> On 7 Aug 2023, at 04:50, Yoshihiro Ota <ota@j.email.ne.jp>= ; wrote:
>>>
>>> Am I the only one seeing this error?
>>> I'm on 12.4-RELEASE amd64 and building CURRENT as of now.<= br> >>>
>>> jaillex.c:2228:43: error: unused parameter 'yyscanner'=
>>> [-Werror,-Wunused-parameter]
>>> void *yyalloc (yy_size_t=C2=A0 size , yyscan_t yyscanner)
>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^
>>> jaillex.c:2233:58: error: unused parameter 'yyscanner'=
>>> [-Werror,-Wunused-parameter]
>>> void *yyrealloc=C2=A0 (void * ptr, yy_size_t=C2=A0 size , yysc= an_t yyscanner)
>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^
>>> jaillex.c:2245:36: error: unused parameter 'yyscanner'=
>>> [-Werror,-Wunused-parameter]
>>> void yyfree (void * ptr , yyscan_t yyscanner)
>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^
>>> 6 errors generated.
>>> *** [jaillex.o] Error code 1
>>>
>>
>> It seems you are not crazy. :) I can reproduce the error, and I th= ink it
>> might be caused by:
>>
>> https://cgit.freebsd.org/src/commit/?id=3D086e0149ae56641af245ce472e787c2= f67d3aea5
>>
>> However, as to why this does not result in an error (or even a war= ning)
>> on -CURRENT, I have no clue. Maybe in the mean time flex in -CURRE= NT got
>> updated...
>
> That is indeed the culprit.=C2=A0 Fortunately, it builds from 13.2-REL= EASE,
> so building CURRENT from 12 can be done in two steps.=C2=A0 I hate to = be the
> reason the update doesn't work directly, but the include capabilit= y I
> added to jail(8) requires re-entrant lex, which apparently managed to<= br> > work around the error in 13.=C2=A0 They reason it doesn't give a w= arning BTW
> is these two lines that lex adds:
>
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 struct yyguts_t * yyg =3D (= struct yyguts_t*)yyscanner;
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (void)yyg;
>
> That makes yyscanner officially "used" even though its value= is never
> actually read.=C2=A0 I suspect the version of lex in 12.4-RELEASE does= n't
> have one or both of those lines.
>
> Perhaps you could add such lines to the offending functions yourself,<= br> > and continue the make.=C2=A0 Or maybe build (and install) lex on its o= wn
> first; by the time you see this error, there should already be a newer=
> version of lex you could pop into place.
>
> There's probably something I should do to make this work better, o= r
> perhaps some note I should put into UPDATING before 14.0 is released.<= br>
Or there is already a recipe for bootstrapping lex in Makefile.inc1,
though for somewhat older versions; possibly it could be updated for < 1= 3?

.if ${BOOTSTRAPPING} < 1000033


When in doubt,= adding BOOTSTRAPPING=3D0 can help...not sure why you'd need to bootstr= ap lex though...

Warner<= /div>
--0000000000005db60106026102bd--