From nobody Mon Aug 07 23:38:36 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RKXnw0FFBz4plys for ; Mon, 7 Aug 2023 23:38:44 +0000 (UTC) (envelope-from jamie@freebsd.org) Received: from gritton.org (gritton.org [67.43.236.212]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "gritton.org", Issuer "gritton.org" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RKXnv4fJSz4W8L; Mon, 7 Aug 2023 23:38:43 +0000 (UTC) (envelope-from jamie@freebsd.org) Authentication-Results: mx1.freebsd.org; none Received: from gritton.org (localgritton [127.0.0.212]) (authenticated bits=0) by gritton.org (8.16.1/8.16.1) with ESMTPA id 377NcaYY099021; Mon, 7 Aug 2023 16:38:36 -0700 (PDT) (envelope-from jamie@freebsd.org) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 Date: Mon, 07 Aug 2023 16:38:36 -0700 From: James Gritton To: FreeBSD Current Cc: Yoshihiro Ota , Dimitry Andric Subject: Re: Jail compile error on CURRENT? In-Reply-To: References: <20230806225055.bbccc4fc13e41f50ec524621@j.email.ne.jp> User-Agent: Roundcube Webmail/1.4.11 Message-ID: X-Sender: jamie@freebsd.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4RKXnv4fJSz4W8L X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:36666, ipnet:67.43.224.0/20, country:CA] On 2023-08-07 13:29, Dimitry Andric wrote: > On 7 Aug 2023, at 04:50, Yoshihiro Ota wrote: >> >> Am I the only one seeing this error? >> I'm on 12.4-RELEASE amd64 and building CURRENT as of now. >> >> jaillex.c:2228:43: error: unused parameter 'yyscanner' >> [-Werror,-Wunused-parameter] >> void *yyalloc (yy_size_t size , yyscan_t yyscanner) >> ^ >> jaillex.c:2233:58: error: unused parameter 'yyscanner' >> [-Werror,-Wunused-parameter] >> void *yyrealloc (void * ptr, yy_size_t size , yyscan_t yyscanner) >> ^ >> jaillex.c:2245:36: error: unused parameter 'yyscanner' >> [-Werror,-Wunused-parameter] >> void yyfree (void * ptr , yyscan_t yyscanner) >> ^ >> 6 errors generated. >> *** [jaillex.o] Error code 1 >> > > It seems you are not crazy. :) I can reproduce the error, and I think > it > might be caused by: > > https://cgit.freebsd.org/src/commit/?id=086e0149ae56641af245ce472e787c2f67d3aea5 > > However, as to why this does not result in an error (or even a warning) > on -CURRENT, I have no clue. Maybe in the mean time flex in -CURRENT > got > updated... That is indeed the culprit. Fortunately, it builds from 13.2-RELEASE, so building CURRENT from 12 can be done in two steps. I hate to be the reason the update doesn't work directly, but the include capability I added to jail(8) requires re-entrant lex, which apparently managed to work around the error in 13. They reason it doesn't give a warning BTW is these two lines that lex adds: struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; (void)yyg; That makes yyscanner officially "used" even though its value is never actually read. I suspect the version of lex in 12.4-RELEASE doesn't have one or both of those lines. Perhaps you could add such lines to the offending functions yourself, and continue the make. Or maybe build (and install) lex on its own first; by the time you see this error, there should already be a newer version of lex you could pop into place. There's probably something I should do to make this work better, or perhaps some note I should put into UPDATING before 14.0 is released. - Jamie