Re: adopting zone1970.tab changes in tzsetup
- In reply to: Yuri : "adopting zone1970.tab changes in tzsetup"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Thu, 27 Apr 2023 10:22:10 UTC
Yuri wrote: > Hi, > > After tzsetup was switched to use zone1970.tab in 513419f4047 it mostly > works, but there are some content changes compared to zone.tab that was > used previously which need to be taken care of (would like to do so > before 14.0). If you have spare time, please take a look at the reviews > below. > > https://reviews.freebsd.org/D39634 - add baseline to tzsetup to check > that zone1970.tab changes don't break the assumptions of file format we > make in tzsetup (and tzsetup changes itself don't have unintended effects) This one is integrated. > https://reviews.freebsd.org/D39606 - adopt zone1970.tab changes > - assumption that single-zone countries do not have description is no > longer correct; do not try to optimize this case as it's only going to > make the code more confusing and we now have menus with a single zone > selection because of this > - remove the single-country continent short cut, it also only serves to > confuse users as we now have such a continent > - instead add a single-zone contry short cut (see above), now all > single-zone countries fall here > - use the @# continent overrides that zone1970.tab introduces (this is > visible at least fixing Iceland being currently listed under Africa) > - add Arctic Ocean "continent" coming only from the overrides at the > moment > - update baseline with the changes And this one is waiting for review :)