From nobody Wed Apr 26 18:33:03 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Q66tp1hQ5z4776R for ; Wed, 26 Apr 2023 18:33:06 +0000 (UTC) (envelope-from jakob@alvermark.net) Received: from out.alvermark.net (out.alvermark.net [185.34.136.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Q66tn6lT2z43VC; Wed, 26 Apr 2023 18:33:05 +0000 (UTC) (envelope-from jakob@alvermark.net) Authentication-Results: mx1.freebsd.org; none Received: from c-bc4d235c.06-431-73746f70.bbcust.telenor.se ([92.35.77.188] helo=mail.alvermark.net) by out.alvermark.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91 (FreeBSD)) (envelope-from ) id 1prjwt-0003fn-Pm; Wed, 26 Apr 2023 20:33:03 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=alvermark.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=T/feHl5/s0Rbsjg1NMjPnG3sMjvxCXP1/TjeBNxok8s=; b=dz6zWFTamE9mRiqxk7JZaEW03h sIC5pBPTEYKHPFGoOgrLZRCFgO2SfHJvH6gXbdTfj46SxSQxrTiPu+UWSSrAlKpZdh6NRFlJBu9aU UK9cDnux0DQgPswzh6QJLixLgRRvV9Uk9LQhaVUFzXFNQiO0Netvnz7eBVz8tr5H8x8u/6uaKcdFK 1FWNXM/XIT8H4zAf9acgM5UYGLyGjBhP5zPbCgf4qnzIlV41WSiu0vaCrFgVfCzM8NZ5t0oGyk80e qrRgYyQ6SnCpSp0HIO1rziGTc4Cjc5krGwZ8gJF8MeCH+aBXYqx2CudU+45WL2TfEaOIPUXWKRKjy F5knYZDA==; Received: from [192.168.67.27] by mail.alvermark.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.91 (FreeBSD)) (envelope-from ) id 1prjwt-0009jz-9d; Wed, 26 Apr 2023 20:33:03 +0200 Message-ID: <06e48531-aa6b-2d78-ac0b-474e4106de9a@alvermark.net> Date: Wed, 26 Apr 2023 20:33:03 +0200 List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: change in compat/linux breaking net/citrix_ica To: Dmitry Chagin Cc: freebsd-current References: <12cb8ced-8f80-1682-594a-63b402013768@alvermark.net> Content-Language: en-US From: Jakob Alvermark In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4Q66tn6lT2z43VC X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:34971, ipnet:185.34.136.0/24, country:IT] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On 4/26/23 16:00, Dmitry Chagin wrote: > On Wed, Apr 26, 2023 at 09:01:00AM +0200, Jakob Alvermark wrote: >> Hi, >> >> >> I use net/citrix_ica for work. > https://cgit.FreeBSD.org/src/commit/?id=76f8584e49cf7eedaa2e1312593bf46c7225d79a Yes, this works. Thanks for the quick response! >> After a recent change to -current in compat/linux it no longer works. >> The binary just segfaults. >> >> I have bisected and it happened after this commit: >> >> commit 40c36c4674eb9602709cf9d0483a4f34ad9753f6 >> Author: Dmitry Chagin >> Date:   Sat Apr 22 22:17:17 2023 +0300 >> >>     linux(4): Export the AT_RANDOM depending on the process osreldata >> >>     AT_RANDOM has appeared in the 2.6.30 Linux kernel first time. >> >>     Reviewed by:            emaste >>     Differential Revision:  https://reviews.freebsd.org/D39646 >>     MFC after:              1 month >> >>  sys/compat/linux/linux_elf.c | 3 ++- >>  sys/compat/linux/linux_mib.h | 1 + >>  2 files changed, 3 insertions(+), 1 deletion(-) >> >> >> If I revert the change, citrix_ica works again. >> >> >> Thanks, >> >> Jakob Alvermark >>