From nobody Wed Apr 26 14:00:09 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Q60qy5hHtz46YHG for ; Wed, 26 Apr 2023 14:00:14 +0000 (UTC) (envelope-from dchagin@heemeyer.club) Received: from heemeyer.club (heemeyer.club [195.93.173.158]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Q60qx424Hz4K7Q for ; Wed, 26 Apr 2023 14:00:13 +0000 (UTC) (envelope-from dchagin@heemeyer.club) Authentication-Results: mx1.freebsd.org; none Received: from heemeyer.club (localhost [127.0.0.1]) by heemeyer.club (8.17.1/8.16.1) with ESMTP id 33QE09uD003905; Wed, 26 Apr 2023 17:00:09 +0300 (MSK) (envelope-from dchagin@heemeyer.club) Received: (from dchagin@localhost) by heemeyer.club (8.17.1/8.16.1/Submit) id 33QE09kG003904; Wed, 26 Apr 2023 17:00:09 +0300 (MSK) (envelope-from dchagin) Date: Wed, 26 Apr 2023 17:00:09 +0300 From: Dmitry Chagin To: Jakob Alvermark Cc: freebsd-current Subject: Re: change in compat/linux breaking net/citrix_ica Message-ID: References: <12cb8ced-8f80-1682-594a-63b402013768@alvermark.net> List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <12cb8ced-8f80-1682-594a-63b402013768@alvermark.net> X-Rspamd-Queue-Id: 4Q60qx424Hz4K7Q X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:61400, ipnet:195.93.173.0/24, country:RU] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On Wed, Apr 26, 2023 at 09:01:00AM +0200, Jakob Alvermark wrote: > Hi, > > > I use net/citrix_ica for work. https://cgit.FreeBSD.org/src/commit/?id=76f8584e49cf7eedaa2e1312593bf46c7225d79a > > After a recent change to -current in compat/linux it no longer works. > The binary just segfaults. > > I have bisected and it happened after this commit: > > commit 40c36c4674eb9602709cf9d0483a4f34ad9753f6 > Author: Dmitry Chagin > Date:   Sat Apr 22 22:17:17 2023 +0300 > >     linux(4): Export the AT_RANDOM depending on the process osreldata > >     AT_RANDOM has appeared in the 2.6.30 Linux kernel first time. > >     Reviewed by:            emaste >     Differential Revision:  https://reviews.freebsd.org/D39646 >     MFC after:              1 month > >  sys/compat/linux/linux_elf.c | 3 ++- >  sys/compat/linux/linux_mib.h | 1 + >  2 files changed, 3 insertions(+), 1 deletion(-) > > > If I revert the change, citrix_ica works again. > > > Thanks, > > Jakob Alvermark >