Re: change in compat/linux breaking net/citrix_ica

In reply to: Jakob Alvermark : "change in compat/linux breaking net/citrix_ica"
Go to: [ bottom of page ] [ top of archives ] [ this month ]

From: Dmitry Chagin <dchagin_at_freebsd.org>
Date: Wed, 26 Apr 2023 08:57:15 UTC

On Wed, Apr 26, 2023 at 09:01:00AM +0200, Jakob Alvermark wrote:
> Hi,
> 
> 
> I use net/citrix_ica for work.
> 
> After a recent change to -current in compat/linux it no longer works. 
> The binary just segfaults.
> 
> I have bisected and it happened after this commit:
> 
> commit 40c36c4674eb9602709cf9d0483a4f34ad9753f6
> Author: Dmitry Chagin <dchagin@FreeBSD.org>
> Date:   Sat Apr 22 22:17:17 2023 +0300
> 
>      linux(4): Export the AT_RANDOM depending on the process osreldata
> 
>      AT_RANDOM has appeared in the 2.6.30 Linux kernel first time.
> 
>      Reviewed by:            emaste
>      Differential Revision:  https://reviews.freebsd.org/D39646
>      MFC after:              1 month
> 
>   sys/compat/linux/linux_elf.c | 3 ++-
>   sys/compat/linux/linux_mib.h | 1 +
>   2 files changed, 3 insertions(+), 1 deletion(-)
> 
> 
> If I revert the change, citrix_ica works again.
> 

Hi, thanks, I'll commit fix today after some testing

> 
> Thanks,
> 
> Jakob Alvermark
>