From nobody Tue Apr 25 14:56:33 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Q5Q7h1pT4z47HpL for ; Tue, 25 Apr 2023 14:56:48 +0000 (UTC) (envelope-from pete@nomadlogic.org) Received: from mail.nomadlogic.org (mail.nomadlogic.org [66.165.241.226]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mail.nomadlogic.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Q5Q7g5Dtbz3Mg4; Tue, 25 Apr 2023 14:56:47 +0000 (UTC) (envelope-from pete@nomadlogic.org) Authentication-Results: mx1.freebsd.org; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nomadlogic.org; s=04242021; t=1682434596; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pdZnZ5WlTrkQSK1YmaVjRvwKV/TuAAUONtK1kEavhB0=; b=A9AvdWu0h/Sa3ntERY5Bm2lGILlkEkQOhOk8HW5Q/YexRobtjJu5kYi24YwUxEW7wi7/tm pXHuTXUaOvgTkvxkiq6upgO5asNvez7vGVwc5IjjLJLMUixKuP/lS1RWCVmmf+QnCZDStc PtVdEA/+TiHC7zSPnMVPCwU5F03p+NE= Received: from [192.168.1.160] (cpe-24-24-168-214.socal.res.rr.com [24.24.168.214]) by mail.nomadlogic.org (OpenSMTPD) with ESMTPSA id 286ffed3 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Tue, 25 Apr 2023 14:56:35 +0000 (UTC) Content-Type: multipart/alternative; boundary="------------MkHvJs0pwSFTDOLkNx7PlcZm" Message-ID: <6052c5c7-cc32-c1ea-6943-aaebd0b9b02f@nomadlogic.org> Date: Tue, 25 Apr 2023 07:56:33 -0700 List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: current status of zfs block_cloning on CURRENT? Content-Language: en-US To: Warner Losh , Charlie Li Cc: FreeBSD Current References: <4f9470a0-4f14-a31b-52a9-7746d6fa09e6@nomadlogic.org> <5ee4d2ec-a09f-00ee-17f2-c1593aaf365c@freebsd.org> <9c55271b-e2cf-85b7-cc99-00ddcb76f98e@freebsd.org> From: Pete Wright In-Reply-To: X-Rspamd-Queue-Id: 4Q5Q7g5Dtbz3Mg4 X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:29802, ipnet:66.165.240.0/22, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N This is a multi-part message in MIME format. --------------MkHvJs0pwSFTDOLkNx7PlcZm Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 4/24/23 21:30, Warner Losh wrote: > > > On Mon, Apr 24, 2023 at 9:49 PM Charlie Li wrote: > > Charlie Li wrote: > > Pete Wright wrote: > >> i've seen a few threads about the block_cloning feature causing > data > >> corruption issues on CURRENT and have been keen to avoid > enabling it > >> until the dust settles.  i was under the impression that we either > >> reverted or disabled block_cloning on CURRENT, but when i ran > "zpool > >> upgrade" on a pool today it reported block_cloning was > enabled.  this > >> is on a system i rebuilt yesterday. > >> > > The dust has settled. > Barely... > >> i was hoping to get some clarity on the effect of having this > feature > >> enabled, is this enough to trigger the data corruption bug or does > >> something on the zfs filesystem itself have to be enabled to > trigger > >> this? > >> > > The initial problem with block_cloning [0][1] was fixed in commits > > e0bb199925565a3770733afd1a4d8bb2d4d0ce31 and > > 1959e122d9328b31a62ff7508e1746df2857b592, with a sysctl added in > commit > > 068913e4ba3dd9b3067056e832cefc5ed264b5cc. A different data > corruption > > problem [2][3] was fixed in commit > > 63ee747febbf024be0aace61161241b53245449e. All were committed > between > > 15-17 April. > > > > [0] > https://github.com/openzfs/zfs/pull/13392#issuecomment-1504239103 > > [1] https://github.com/openzfs/zfs/pull/14739 > > [2] https://github.com/openzfs/zfs/issues/14753 > > [3] https://github.com/openzfs/zfs/pull/14761 > > > Given mjg@'s thread reporting further crashes/panics, you may want to > keep the sysctl disabled if you upgraded the pool already. > > > I thought the plan was to keep it disabled until after 14. And even then, > when it comes back in, it will be a new feature It should never be > enabled. > that was my reading of things too - thanks for the tip on disabling the sysctl knob Charlie, I'll do that. if this is really intended to be live i'd like to suggest we update zpool-features(7) at the least so others aren't caught by surprise. i'd propose a PR myself, but I'm not %100 clear on what its intent is. -pete -- Pete Wright pete@nomadlogic.org @nomadlogicLA --------------MkHvJs0pwSFTDOLkNx7PlcZm Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

On 4/24/23 21:30, Warner Losh wrote:


On Mon, Apr 24, 2023 at 9:49 PM Charlie Li <vishwin@freebsd.org> wrote:
Charlie Li wrote:
> Pete Wright wrote:
>> i've seen a few threads about the block_cloning feature causing data
>> corruption issues on CURRENT and have been keen to avoid enabling it
>> until the dust settles.  i was under the impression that we either
>> reverted or disabled block_cloning on CURRENT, but when i ran "zpool
>> upgrade" on a pool today it reported block_cloning was enabled.  this
>> is on a system i rebuilt yesterday.
>>
> The dust has settled.
Barely...
>> i was hoping to get some clarity on the effect of having this feature
>> enabled, is this enough to trigger the data corruption bug or does
>> something on the zfs filesystem itself have to be enabled to trigger
>> this?
>>
> The initial problem with block_cloning [0][1] was fixed in commits
> e0bb199925565a3770733afd1a4d8bb2d4d0ce31 and
> 1959e122d9328b31a62ff7508e1746df2857b592, with a sysctl added in commit
> 068913e4ba3dd9b3067056e832cefc5ed264b5cc. A different data corruption
> problem [2][3] was fixed in commit
> 63ee747febbf024be0aace61161241b53245449e. All were committed between
> 15-17 April.
>
> [0] https://github.com/openzfs/zfs/pull/13392#issuecomment-1504239103
> [1] https://github.com/openzfs/zfs/pull/14739
> [2] https://github.com/openzfs/zfs/issues/14753
> [3] https://github.com/openzfs/zfs/pull/14761
>
Given mjg@'s thread reporting further crashes/panics, you may want to
keep the sysctl disabled if you upgraded the pool already.

I thought the plan was to keep it disabled until after 14. And even then,
when it comes back in, it will be a new feature It should never be enabled.


that was my reading of things too - thanks for the tip on disabling the sysctl knob Charlie, I'll do that.

if this is really intended to be live i'd like to suggest we update zpool-features(7) at the least so others aren't caught by surprise.  i'd propose a PR myself, but I'm not %100 clear on what its intent is.

-pete

-- 
Pete Wright
pete@nomadlogic.org
@nomadlogicLA
--------------MkHvJs0pwSFTDOLkNx7PlcZm--