From nobody Tue Apr 25 04:30:26 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Q58FD4494z46bg3 for ; Tue, 25 Apr 2023 04:30:40 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Q58FC6fJZz4ZYZ for ; Tue, 25 Apr 2023 04:30:39 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-x52d.google.com with SMTP id 4fb4d7f45d1cf-506bdf29712so39505827a12.0 for ; Mon, 24 Apr 2023 21:30:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20221208.gappssmtp.com; s=20221208; t=1682397038; x=1684989038; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=OojdO4RQuddAigwsgM3PihdIVQARkmEm4mG/hYBF2XU=; b=ygJ/AYxDH0M/uMMTcl/caEbRqDyqgJRXnqnIPFTMw8/sxUQi/JcaVrX6m+2BV/Hyb+ YT4h26mZ+GlS0cCHHODhCB2AXtm1mjbIuZGHTuNjIR9kpZAS50k9aDqozB3W3NsNfLIv jQTk+peR6GRrcpo5aTm/vGAs4ca6OAKVkFUvoF4TNr3nPPIcPs46gttr3+nx7v1ip6WG PhuQ4uD9wzzZDrKvozX46cfV55fzxL1+yAOLS9o51mAwjmvjbha9fwCQrM+djzH4J0lQ GURdAz3VifOtV2ct532+C2+Q+Fbw7gLiH0xw7M71rhjGnOvS47vh65IHkDzPlEG5ugjn bBLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682397038; x=1684989038; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OojdO4RQuddAigwsgM3PihdIVQARkmEm4mG/hYBF2XU=; b=fTEhe0fm4Bagx2L1l38aSR8SXqTx//kwKmCwz+Me/fwLM6EjgB/02t0x73gIGj/F5z z9eUS/xPjzk/Ej2ch3mWRQh6GTsAtXjDkSuWL9YdEBD7YHojbWra3tmcxWwlYG1XzxHG NDZmK3EOYOWN5FJWcYm1CbStZDn0J14asTUlwNXFLriAevPQs03KEmUe238Tu/MlRUy1 Dx9V35zrG5KdKpguwrzgpYftRdp3FiAC82ymNV6vSj8KVqEHthTSSo2U+hTNc2CYGSC8 Poytb2FR1519qW6b4RxXsYzKEjtjQIkyoneeZSkV55f/k0RHv24T3+CC7KhakcRF/1MJ EItQ== X-Gm-Message-State: AAQBX9cHCq0uzJfEFzpHvRS/Mxn5a/uoaZexehoQIeM6kROJEbSBD6Gl aBTH1NpD3TMqJhOyu9mCG4gzZz60O8LvTUwzrlYelmcqB14XRMMp X-Google-Smtp-Source: AKy350arPX1OZEbvmCmIUgJ1Y5d3T2G5EBznATDQJYVn3hL6w8cISh62GiTkZqNHSAiPEIlB+278s4cem3bXOaFsevk= X-Received: by 2002:aa7:cd11:0:b0:4ad:738b:6706 with SMTP id b17-20020aa7cd11000000b004ad738b6706mr15338159edw.2.1682397037584; Mon, 24 Apr 2023 21:30:37 -0700 (PDT) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 References: <4f9470a0-4f14-a31b-52a9-7746d6fa09e6@nomadlogic.org> <5ee4d2ec-a09f-00ee-17f2-c1593aaf365c@freebsd.org> <9c55271b-e2cf-85b7-cc99-00ddcb76f98e@freebsd.org> In-Reply-To: <9c55271b-e2cf-85b7-cc99-00ddcb76f98e@freebsd.org> From: Warner Losh Date: Mon, 24 Apr 2023 22:30:26 -0600 Message-ID: Subject: Re: current status of zfs block_cloning on CURRENT? To: Charlie Li Cc: Pete Wright , FreeBSD Current Content-Type: multipart/alternative; boundary="000000000000cbfd0105fa2195c9" X-Rspamd-Queue-Id: 4Q58FC6fJZz4ZYZ X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N --000000000000cbfd0105fa2195c9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Apr 24, 2023 at 9:49=E2=80=AFPM Charlie Li wr= ote: > Charlie Li wrote: > > Pete Wright wrote: > >> i've seen a few threads about the block_cloning feature causing data > >> corruption issues on CURRENT and have been keen to avoid enabling it > >> until the dust settles. i was under the impression that we either > >> reverted or disabled block_cloning on CURRENT, but when i ran "zpool > >> upgrade" on a pool today it reported block_cloning was enabled. this > >> is on a system i rebuilt yesterday. > >> > > The dust has settled. > Barely... > >> i was hoping to get some clarity on the effect of having this feature > >> enabled, is this enough to trigger the data corruption bug or does > >> something on the zfs filesystem itself have to be enabled to trigger > >> this? > >> > > The initial problem with block_cloning [0][1] was fixed in commits > > e0bb199925565a3770733afd1a4d8bb2d4d0ce31 and > > 1959e122d9328b31a62ff7508e1746df2857b592, with a sysctl added in commit > > 068913e4ba3dd9b3067056e832cefc5ed264b5cc. A different data corruption > > problem [2][3] was fixed in commit > > 63ee747febbf024be0aace61161241b53245449e. All were committed between > > 15-17 April. > > > > [0] https://github.com/openzfs/zfs/pull/13392#issuecomment-1504239103 > > [1] https://github.com/openzfs/zfs/pull/14739 > > [2] https://github.com/openzfs/zfs/issues/14753 > > [3] https://github.com/openzfs/zfs/pull/14761 > > > Given mjg@'s thread reporting further crashes/panics, you may want to > keep the sysctl disabled if you upgraded the pool already. > I thought the plan was to keep it disabled until after 14. And even then, when it comes back in, it will be a new feature It should never be enabled. Warner --000000000000cbfd0105fa2195c9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Mon, Apr 24, 2023 at 9:49=E2=80=AF= PM Charlie Li <vishwin@freebsd.or= g> wrote:
Charlie Li wrote:
> Pete Wright wrote:
>> i've seen a few threads about the block_cloning feature causin= g data
>> corruption issues on CURRENT and have been keen to avoid enabling = it
>> until the dust settles.=C2=A0 i was under the impression that we e= ither
>> reverted or disabled block_cloning on CURRENT, but when i ran &quo= t;zpool
>> upgrade" on a pool today it reported block_cloning was enable= d.=C2=A0 this
>> is on a system i rebuilt yesterday.
>>
> The dust has settled.
Barely...
>> i was hoping to get some clarity on the effect of having this feat= ure
>> enabled, is this enough to trigger the data corruption bug or does=
>> something on the zfs filesystem itself have to be enabled to trigg= er
>> this?
>>
> The initial problem with block_cloning [0][1] was fixed in commits > e0bb199925565a3770733afd1a4d8bb2d4d0ce31 and
> 1959e122d9328b31a62ff7508e1746df2857b592, with a sysctl added in commi= t
> 068913e4ba3dd9b3067056e832cefc5ed264b5cc. A different data corruption =
> problem [2][3] was fixed in commit
> 63ee747febbf024be0aace61161241b53245449e. All were committed between <= br> > 15-17 April.
>
> [0] https://github.com/openzfs= /zfs/pull/13392#issuecomment-1504239103
> [1] https://github.com/openzfs/zfs/pull/14739
> [2] https://github.com/openzfs/zfs/issues/14753<= br> > [3] https://github.com/openzfs/zfs/pull/14761
>
Given mjg@'s thread reporting further crashes/panics, you may want to <= br> keep the sysctl disabled if you upgraded the pool already.
=

I thought the plan was to keep it disabled until after = 14. And even then,
when it comes back in, it will be a new featur= e It should never be enabled.

Warner
--000000000000cbfd0105fa2195c9--