From nobody Tue Oct 04 13:35:25 2022 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Mhdxm4nksz4dt29 for ; Tue, 4 Oct 2022 13:35:40 +0000 (UTC) (envelope-from garyj@gmx.de) Received: from mout.gmx.net (mout.gmx.net [212.227.15.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mout.gmx.net", Issuer "TeleSec ServerPass Class 2 CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Mhdxl0KFKz3dxq for ; Tue, 4 Oct 2022 13:35:38 +0000 (UTC) (envelope-from garyj@gmx.de) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1664890534; bh=jLJhb+svF9fhHWdx9dr6fAJzJS4k/oO8xbnOkdA54nU=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:In-Reply-To:References: Reply-To; b=UbTcW//s4XM5QBO4JnLPbCPQbhNr+92n16UBh5wnWO65kQD9ME1G7r8c/3Qv/sAjh MArklt0CX/JpANw0E8ZCDRmwatFtVmgdrRc3GzIdyvH8MlOBubVAuBhXiUbYrdth38 rlblKAGSGTDkAhL2Couy+hKH3M4B5bJNsHdWxy9c= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from ernst.home ([91.2.53.8]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N6bk4-1pGiL20tCw-0183hS; Tue, 04 Oct 2022 15:35:34 +0200 Date: Tue, 4 Oct 2022 15:35:25 +0200 From: Gary Jennejohn To: Hans Petter Selasky Cc: Johan Hendriks , FreeBSD Current Subject: Re: build world fails on raw_ip.c Message-ID: <20221004153525.7a31a62d@ernst.home> In-Reply-To: References: Reply-To: garyj@gmx.de X-Mailer: Claws Mail 3.19.0 (GTK+ 2.24.33; amd64-portbld-freebsd14.0) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:3dTqR1ndqgpW/1UTg3Ri0zz3g0yauBLs/vWsYymcGM6eFlnCA7C x98lSarDQMboZThqsBQZJeFWOzgFFimkBJ4lLS/Iu9fWV/rnHPt1jHnodttp2OJCXN91hql ZisQXlmnClKncRmSAlW2gXgHJMdmYy/aJMk+7XOmIhWdKFcW47KmNFm4R4WMeJnbFmJeQrD OWrngliHYKvhz4mnQM0oA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:zaEfxePJLK0=:aFZdKKgFoBnCAEu4JFNB5A 24UkCqBQfH6OxiSJtYrzE9p2ui2kZcfGAeJh2Q1glwi2rYZLPwcleIxlHj3lNxLpyOUmrfNu4 Yphi8Kj4BCvHdHwOwc2+Wo77burEQUkkSK9sJBR+rE3hGB2v5kMB0MyCucS4BbTQflTgIirZw yzrQNcKnUAzhdboUz4mw6yoXpUF/VxW5fF8Iw+81SI2Rh9BK2aXD3S6syqtRyTqXiVEtkej4b 94Lfa6SWHWrbG71ndSVe25wiHO0ggllSSe8YWkaj5EA/xT7GSwzNnAutwz4i4CBSvdQ7oNDfy InJtqECjlsjLnXJx94ct8JzRtMV/NIeHtsNdt54cqI+1+gf3zqh/q9GGTkkT8MYrZNSzCP54m wBgk8FVpSfoQ78JiYeZnrx350ty5ZdkhXJKGPPqRVXcrdYPkockiTGpgR2fsCaKEPkjvkDUAy miAbJLI/58EpqMLriLOmatOYVgK7dErFJ6WzoF53uob87S169wXlyhIEBQdYri6CvBaJ1Vy6F q6hPfPZPsF65YeGZK5t5PqUMN5a9VJHo4kBKkmaUqfggrikm3f9P5YXDvBfR7UZm7NgNKzcQg 4KZ1ljEyGslHcTSAGZ2J9uK3iTELZlgPWr+IyZ/D9jPpVYy4U6YSixWcjCrioeWIyLSQx3JnO IXhWBW3zL1BIOemg2NafIqpoWvmLQSczx2t2/z6EFEe9BtE6YNKwAtud2kqcr5mgi7lGp525w R0ytMcrDS2r/YrqStkedyGVUgy7SXXa7wtzLPbQ50TQRFDv2XEtjoH2Xv9D4XyWtrGz30vypT HA7uzasZ4SoDSJ2ik7SFLK7YfXJLBf8rFgaFRiPFC5HclAkGUo8BwFwNOaxRHyMWK7IXpT1RZ I6LfRGYsOAbrcz5fLtwlarYCUJ6VgU8ZgUDJ3oubBPmhvzY/la7V6Hxsuze11AXpj6AMjKZch unriP5sQMLOP5mzsYe8Xx4utAj6G46YuCOL3TdUuh4pjy0FayIWk4B2b6ucr93T03u6Mkka10 P0oNP501Y1I+GzLxfNt7ABp0dYM8MDRNV7QubkjbX+x+weAcZ7hc3jayliRiVJ5g42PjPjMvn wit1Eu8xrIlMQ1V5SBvAyHdinjguYORzCw3wXEznFvH4HhBlV5LNPVQ2exau74hni5iToPU9L EJwKQ= X-Rspamd-Queue-Id: 4Mhdxl0KFKz3dxq X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmx.net header.s=badeba3b8450 header.b="UbTcW//s"; dmarc=pass (policy=none) header.from=gmx.de; spf=pass (mx1.freebsd.org: domain of garyj@gmx.de designates 212.227.15.18 as permitted sender) smtp.mailfrom=garyj@gmx.de X-Spamd-Result: default: False [-2.14 / 15.00]; DWL_DNSWL_LOW(-1.00)[gmx.net:dkim]; NEURAL_SPAM_MEDIUM(0.96)[0.964]; NEURAL_HAM_SHORT(-0.95)[-0.947]; DMARC_POLICY_ALLOW(-0.50)[gmx.de,none]; R_DKIM_ALLOW(-0.20)[gmx.net:s=badeba3b8450]; R_SPF_ALLOW(-0.20)[+ip4:212.227.15.0/25]; MIME_GOOD(-0.10)[text/plain]; RCVD_IN_DNSWL_LOW(-0.10)[212.227.15.18:from]; NEURAL_HAM_LONG(-0.06)[-0.058]; TAGGED_RCPT(0.00)[]; FREEMAIL_REPLYTO(0.00)[gmx.de]; HAS_REPLYTO(0.00)[garyj@gmx.de]; MLMMJ_DEST(0.00)[freebsd-current@freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; FREEMAIL_CC(0.00)[gmail.com,freebsd.org]; RWL_MAILSPIKE_POSSIBLE(0.00)[212.227.15.18:from]; RCPT_COUNT_THREE(0.00)[3]; ARC_NA(0.00)[]; RCVD_TLS_ALL(0.00)[]; REPLYTO_ADDR_EQ_FROM(0.00)[]; TO_DN_ALL(0.00)[]; FREEMAIL_FROM(0.00)[gmx.de]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; DKIM_TRACE(0.00)[gmx.net:+]; MIME_TRACE(0.00)[0:+]; FROM_EQ_ENVFROM(0.00)[]; ASN(0.00)[asn:8560, ipnet:212.227.0.0/16, country:DE]; FREEMAIL_ENVFROM(0.00)[gmx.de]; RCVD_COUNT_TWO(0.00)[2] X-ThisMailContainsUnwantedMimeParts: N On Tue, 4 Oct 2022 15:20:05 +0200 Hans Petter Selasky wrote: > On 10/4/22 15:14, Johan Hendriks wrote: > > I just updated the source today but now i get an error building world. > > The old build was from yesterday which was fine! > > > > Building /usr/obj/usr/src/amd64.amd64/sys/KRNL/raw_ip.o > > cc -target x86_64-unknown-freebsd14.0 > --sysroot=3D/usr/obj/usr/src/a= md64.amd64/tmp > -B/usr/obj/usr/src/amd64.amd64/tmp/usr/bin -c -O2 -pipe >= -fno-strict-aliasing -march=3Dbroadwell -g -nostdinc=A0 -I. -I/usr/src/sy= s > -I/usr/src/sys/contrib/ck/include -I/usr/src/sys/contrib/libfdt > -D_K= ERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common > -fn= o-omit-frame-pointer -mno-omit-leaf-frame-pointer > -fdebug-prefix-map=3D.= /machine=3D/usr/src/sys/amd64/include > -fdebug-prefix-map=3D./x86=3D/usr/= src/sys/x86/include > -fdebug-prefix-map=3D./i386=3D/usr/src/sys/i386/incl= ude -mcmodel=3Dkernel > -mno-red-zone -mno-mmx -mno-sse -msoft-float > -fn= o-asynchronous-unwind-tables -ffreestanding -fwrapv -fstack-protector > -W= all -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes > -Wpointer-= arith -Wcast-qual -Wundef -Wno-pointer-sign > -D__printf__=3D__freebsd_kpr= intf__ -Wmissing-include-dirs > -fdiagnostics-show-option -Wno-unknown-pra= gmas > -Wno-error=3Dtautological-compare -Wno-error=3Dempty-body > -Wno-er= ror=3Dparentheses-equality -Wno-error=3Dunused-function > -Wno-error=3Dpoi= nter-sign -Wno-error=3Dshift-negative-value > -Wno-address-of-packed-membe= r -Wno-format-zero-length=A0=A0 -mno-aes > -mno-avx=A0 -std=3Diso9899:1999= -Werror /usr/src/sys/netinet/raw_ip.c > > /usr/src/sys/netinet/raw_ip.c:811:3: error: too few arguments to > fun= ction call, expected 4, have 2 > > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 IPSEC_CTLINPUT(ipv4, ic= mp); > > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 ^~~~~~~~~~~~~~~~~~~~~~~= ~~~ > > /usr/src/sys/netipsec/ipsec_support.h:222:61: note: expanded from macr= o > 'IPSEC_CTLINPUT' > > =A0=A0=A0 ipsec_kmod_ctlinput(proto ## _ipsec_support, __VA_ARGS__) > > =A0=A0=A0 ~~~~~~~~~~~~~~~~~~~=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 ^ > > /usr/src/sys/netipsec/ipsec_support.h:196:5: note: 'ipsec_kmod_ctlinpu= t' > declared here > > int ipsec_kmod_ctlinput(struct ipsec_support * const, int, > > =A0=A0=A0 ^ > > 1 error generated. > > *** Error code 1 > > > > I've mailed the responsible committer. > > Just do: > > diff --git a/sys/amd64/conf/GENERIC b/sys/amd64/conf/GENERIC > index 9178abba36cc..ed8045e48257 100644 > --- a/sys/amd64/conf/GENERIC > +++ b/sys/amd64/conf/GENERIC > @@ -30,7 +30,7 @@ options PREEMPTION # Enable kernel = thread preemption > options VIMAGE # Subsystem virtualization, e.g= . VNET > options INET # InterNETworking > options INET6 # IPv6 communications protocols > -options IPSEC_SUPPORT # Allow kldload of ipsec and tcp= md5 > +# options IPSEC_SUPPORT # Allow kldload of ipsec and tcp= md5 > options ROUTE_MPATH # Multipath routing sup= port > options FIB_ALGO # Modular fib lookups > options TCP_OFFLOAD # TCP offload > > > > For now. > There are the usual other problems, like always assuming the every user has INET6 defined in their kernel config file. Here's an error I just saw: /usr/src/sys/netinet/tcp_subr.c:136:8: error: unknown type name 'ip6proto_= ctlinput_t'; did you mean 'ipproto_ctlinput_t'? static ip6proto_ctlinput_t tcp6_ctlinput; ^~~~~~~~~~~~~~~~~~~ ipproto_ctlinput_t /usr/src/sys/netinet/ip_var.h:242:14: note: 'ipproto_ctlinput_t' declared = here typedef void ipproto_ctlinput_t(struct icmp *); ^ 1 error generated. =2D-- tcp_subr.o --- *** [tcp_subr.o] Error code 1 =2D- Gary Jennejohn