From nobody Tue May 03 16:24:24 2022 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 98EEF1AB74C2; Tue, 3 May 2022 16:24:56 +0000 (UTC) (envelope-from jhs@berklix.com) Received: from land.berklix.org (land.berklix.org [144.76.10.75]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "land.berklix.org", Issuer "land.berklix.org" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Kt5076Hj9z4kL0; Tue, 3 May 2022 16:24:55 +0000 (UTC) (envelope-from jhs@berklix.com) Received: from mart.js.berklix.net (p4fe6d03e.dip0.t-ipconnect.de [79.230.208.62]) (authenticated bits=128) by land.berklix.org (8.16.1/8.16.1) with ESMTPSA id 243GOoMp081457 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 3 May 2022 16:24:54 GMT (envelope-from jhs@berklix.com) Received: from fire.js.berklix.net (fire.js.berklix.net [192.168.91.41]) by mart.js.berklix.net (8.14.3/8.14.3) with ESMTP id 243GOiE3083190; Tue, 3 May 2022 18:24:44 +0200 (CEST) (envelope-from jhs@berklix.com) Received: from fire.js.berklix.net (localhost [127.0.0.1]) by fire.js.berklix.net (8.14.7/8.14.7) with ESMTP id 243GOOjw078964; Tue, 3 May 2022 18:24:39 +0200 (CEST) (envelope-from jhs@berklix.com) Message-Id: <202205031624.243GOOjw078964@fire.js.berklix.net> To: Eugene Grosbein cc: freebsd-stable@FreeBSD.org, freebsd-current@FreeBSD.org, Ed Maste Subject: Re: breaking modules From: "Julian H. Stacey" Organization: http://berklix.com/jhs/ User-agent: EXMH on FreeBSD http://berklix.com/free/ X-From: http://www.berklix.org/~jhs/ In-reply-to: Your message "Tue, 03 May 2022 22:13:26 +0700." <1143af76-e4fe-6169-0cc8-9397b54c2afd@grosbein.net> Date: Tue, 03 May 2022 18:24:24 +0200 X-Rspamd-Queue-Id: 4Kt5076Hj9z4kL0 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of jhs@berklix.com has no SPF policy when checking 144.76.10.75) smtp.mailfrom=jhs@berklix.com X-Spamd-Result: default: False [-2.10 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; FREEFALL_USER(0.00)[jhs]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[berklix.com]; AUTH_NA(1.00)[]; HAS_ORG_HEADER(0.00)[]; RCVD_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-1.00)[-0.999]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; MLMMJ_DEST(0.00)[freebsd-current,freebsd-stable]; R_SPF_NA(0.00)[no SPF record]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:24940, ipnet:144.76.0.0/16, country:DE]; RCVD_TLS_LAST(0.00)[]; RECEIVED_SPAMHAUS_PBL(0.00)[79.230.208.62:received] X-ThisMailContainsUnwantedMimeParts: N List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org Hi, Reference: > From: Eugene Grosbein > Date: Tue, 3 May 2022 22:13:26 +0700 Eugene Grosbein wrote: > 03.05.2022 21:46, Julian H. Stacey wrote: > > > Hi, Reference: > >> From: "Julian H. Stacey" > >> Date: Fri, 29 Apr 2022 23:57:02 +0200 > > > > "Julian H. Stacey" wrote: > >> Ed Maste wrote: > >>> On Thu, 28 Apr 2022 at 11:28, Julian H. Stacey wrote: > >>>> > >>>> but that's crude. It's nice to be able to build most modules ready > >>>> in case wanted later, so how about a DUDS env. mechanism like ports/ ? > >>> > >>> I'd rather not add additional complexity to our build infrastructure > >>> to address a situation that shouldn't exist. Modules should build & > >>> function on an ongoing basis (and, I believe they generally do). CI > >>> doesn't report any issues on either stable branch or main at present. > >> > >> I'm building stable-12 not stable-13. It's broken here. I've seen modules break > >> for years, I used to suspect modules werent built by default by > >> build engines as often as main src/, so modules had more time to rot against > >> changing includes & libs, maybe now build engines might compile > >> them as often as eg bin/ls/ ? I don't know; But I'm seeing modules breaks. > >> > >> I just refetched with git this mid Friday afternoon (TZ=+02:00) 12.3-STABLE > >> & the 2 breaks are still present. See below. > >> > >> Setting a MODULE_DUDS would save work rather than repetitively retro > >> patching out the same modules in Makefile after each git pull --ff-only. > >> > >> I'd happily develop a patch for sys/modules/, but if someone > >> else prefers to, that might increase the chance of it being commited. > >> I'd be happy to test or develop a fix for sys/modules/Makefile. > > > > Eugene Grosbein wrote: > >> Unfortunately, CI does not catch stand-alone module build failures, > >> out of kernel build directory. > >> > >> For example: > >> > >> if_em https://cgit.freebsd.org/src/commit/?id=c0460cf2e42d2819c1f191a1d6e1b3dc0c7ea010 > >> if_epair https://cgit.freebsd.org/src/commit/?id=7a382e744b0b0ba9b51dc34bfa0cd1515f744f25 > >> linuxkpi https://cgit.freebsd.org/src/commit/?id=f5a2e7b0e8483bf51519046fd149a6a31acef6b1 > > > > > > I developed a fix, patch appended, mastered inc. a mini test Makefile at > > http://berklix.com/~jhs/src/bsd/fixes/freebsd/src/gen/sys/modules/ > > > > Filed with https://bugs.freebsd.org/bugzilla/enter_bug.cgi as > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=263758 > > > > I added cc: current@, Would someone like to try it please ? > > > > BTW I've not yet but will later read how DUDS is implemented in > > /usr/ports/Mk/bsd.port.subdir.mk > > I filled https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=263750 > with a patch fixing standalone build of random_fortuna and random_other. > > Please test the patch in the PR 263750 and report back if it fixes the problem for you, too. Yes, I confirm the logic of your patch marked Comment2 2022-05-03 09:12:25 UTC lets both random_fortuna and random_other compile on my 12.3-STABLE. Thanks ! However, a patch quibble: First I saved the page with firefox, scissored the pre & post HTML crud, cd /sys/modules ; patch -p2 < ~/Downloads/263750.diff failed, so I hand patched. The patch command failed as excess spaces in the patch, original tabs lost. fetch 'https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=263750' confirms unwanted spaces in the patch. There are tabs in 12.3-STABLE. Cheers, -- Julian Stacey http://berklix.com/jhs/ http://StolenVotes.UK Kill / remove Putin: He kills innocents & causes global grain & fuel shortage.