Re: nvme INVALID_FIELD in dmesg.boot
- In reply to: Warner Losh : "Re: nvme INVALID_FIELD in dmesg.boot"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Sun, 12 Jun 2022 15:18:21 UTC
On 2022-05-25 at 11:49 EDT, Warner Losh <imp@bsdimp.com> wrote: >On Wed, May 25, 2022 at 9:39 AM Matteo Riondato <matteo@freebsd.org> wrote: > >> On 2022-05-25 at 11:29 EDT, Warner Losh <imp@bsdimp.com> wrote: >> > >> >SET FEATURES (opcode 9) feature 0xb is indeed async event >> >configuration. >> >0x31f is: >> >SMART WARNING for available spares (0x1) >> >SMART warning for temperature (0x2) >> >SMART WARNING for device reliability (0x4) >> >SMART WARNING for being read only (0x8) >> >SMART WARNING for volatile memory backup (0x10) >> >Namespace attribute change events (0x100) >> >Firmware activation events (0x200) >> > >> >I wonder which one of those it doesn't like. My reading of the standard >> >suggests that those should always be supported for a 1.2 and later >> >drive... Thought maybe with the possible exception of the volatile >> >memory backup, so let me do some digging here... >> > >> >We can get the last two items from OAES field of the controller >> >identificaiton data. This is bytes 95:92, which if I'm counting right >> >is the last word on the 040: line in the nvmecontrol identify -x nvmeX >> >command: >> > >> >040: 4e474e4b 30303150 000cca07 00230000 00010200 005b8d80 0030d400 >> >00000100 >> >> >----------------------------------------------------------------------------------------------------------^^^^^^^^^ >> >> On my system: >> >> 040: 31564456 30373130 5cd2e400 00000500 00010200 001e8480 002dc6c0 >> 00000200 >> > >Yea, 0x200 and we send 0x300, so maybe that's the cause of the message.... With the patch you sent, the message is gone from dmesg. Thank you. I didn't check (because I don't know how), but I assume that everything else stayed the same. If, as you said above, these features should be supported per ithe standard, but aren't, perhaps it would be worth printing a warning (maybe under verbose boot)? But maybe it is too much hassle. Thanks anyway, and perhaps you may commit the patch you sent me. Thanks, Matteo