From nobody Wed Jan 05 07:07:17 2022 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 9A6EA1937BBE for ; Wed, 5 Jan 2022 07:08:01 +0000 (UTC) (envelope-from m.e.sanliturk@gmail.com) Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JTLD13lSbz3nvD; Wed, 5 Jan 2022 07:08:01 +0000 (UTC) (envelope-from m.e.sanliturk@gmail.com) Received: by mail-wr1-x434.google.com with SMTP id e5so80955035wrc.5; Tue, 04 Jan 2022 23:08:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=J789KwAXO9SVrtRSTG+36yX1wbalZBIeKsqrD9Q6ifw=; b=EulWHk0giuXY5yvW2JndKpxwrPF5CsBBCLfi1m+wuWHdIvFSYfqG88a/JN+1nSggU1 HFZE9vAREex2SnRtk7mrBoNZNJL6qAz73S+N55LHFxaJ6e8hwBwohCtJf4C/W8HEUoAT Ua1NuKIcxjPqL/cX566KlOyXH6Ji/mtuegLv3REtjSqzEGisBpvJCpY1DujiVMf4liJs mpkK1+Mwfgri+NYvev0UF0wO+1bjyfuGCFZa7d1GaIKBGi2Wgha6hefkpC27MFKnXJ3V miplnCxwsqpxWx219vQEA7jwmP6G4ZiqDDXrhugMNo228sRQJNdXU5Bfp5HMttskwSZN qK4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=J789KwAXO9SVrtRSTG+36yX1wbalZBIeKsqrD9Q6ifw=; b=v6T8hFpPWQSnzLr8DgIQt/igE1BFyKP/N6s9VUYxuPP7dmuQB08+9RmfYorSoVQ5p7 pE2aBzKYLYRwwtkwxTyrNxMdOyKuR716j/YQOyQbd4Hbq5px4n7ZDGbZ83K1XAfUA5Pf +p6LbtWoew5dwZBBa54QLBL5QAfrL+RuXJdCR60jyKoCOzj3a7dJniXfQEOIWOyA7Tnh nJVGxuNFKFzeaxYIRtMfCRdWpqw2n8wUDcTTyyHuBQ+0StvN91NH6oVdL3HlZDW8qN8u 1t3x0e+9Y9cRfStL7hi5nankOIlgkoht97L4yk08AaGO70yeHkZjC3z3PpTsSp9tDRum Hf1Q== X-Gm-Message-State: AOAM5336heAjnRXMRO/yuEmwcw+5yeGvQq166s3t2MMIRfO7npc6DRNd OoJ8bl9HJoU5aITzZ4E8YvXgB3tqq6zZrx222OPzkqFV2lHRDA== X-Google-Smtp-Source: ABdhPJzI84RrIt6h1uPlALOcHy2ij6+KKMvZej7ePfBpTJyX14CRIYAo8BbP08V0kATmpxKaPv6lFhqVcdKKNzFZDDA= X-Received: by 2002:adf:e0c8:: with SMTP id m8mr23653646wri.609.1641366473783; Tue, 04 Jan 2022 23:07:53 -0800 (PST) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 References: In-Reply-To: From: Mehmet Erol Sanliturk Date: Wed, 5 Jan 2022 10:07:17 +0300 Message-ID: Subject: Re: atkbd_timeout() period? To: Warner Losh Cc: Alexander Motin , "freebsd-current@freebsd.org" Content-Type: multipart/alternative; boundary="0000000000009dbb4505d4d06944" X-Rspamd-Queue-Id: 4JTLD13lSbz3nvD X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[] X-ThisMailContainsUnwantedMimeParts: N --0000000000009dbb4505d4d06944 Content-Type: text/plain; charset="UTF-8" On Wed, Jan 5, 2022 at 9:39 AM Warner Losh wrote: > > > On Tue, Jan 4, 2022 at 10:42 PM Alexander Motin wrote: > >> Hi, >> >> As I see, one of the most active threaded callouts on idle VMware VM and >> some hardware is atkbd_timeout(), called 10 times per second. Plus it >> is also one of few remaining non-MP-safe callouts. According to the >> comment it seems to be only a workaround for some lost interrupts. That >> makes me thing: is it really needed to run so often and so accurate, or >> may be we could reduce it to 1-2 times per second? Or may be it can be >> avoided somehow 20 years later? >> > > Yea, we can likely just trash it and wait for people to complain about the > keyboard being hung. I doubt we'll get any complaints because Xaccel 2.1 > was quite a long time ago... It is no longer relevant and the original > conditions > that caused the lost interrupts are likely long gone... > > And if they aren't, we'll get a reproducible test case to judge what the > right workaround > should be. > > Warner > If "10" in " atkbd_timeout(), called 10 times per second " can be defined by a control variable , then it may not be necessary to remove its call , and polling rate may be set with respect to the suitable needs . Mehmet Erol Sanliturk --0000000000009dbb4505d4d06944 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Wed, Jan 5, 2022 = at 9:39 AM Warner Losh <imp@bsdimp.com= > wrote:
=


=
On Tue, Jan 4, 2022 at 10:42 PM Alexa= nder Motin <mav@fre= ebsd.org> wrote:
Hi,

As I see, one of the most active threaded callouts on idle VMware VM and some hardware is atkbd_timeout(), called 10 times per second.=C2=A0 Plus it=
is also one of few remaining non-MP-safe callouts.=C2=A0 According to the comment it seems to be only a workaround for some lost interrupts.=C2=A0 Th= at
makes me thing: is it really needed to run so often and so accurate, or
may be we could reduce it to 1-2 times per second?=C2=A0 Or may be it can b= e
avoided somehow 20 years later?

Yea, we= can likely just trash it and wait for people to complain about the
keyboard being hung. I doubt we'll get any complaints because=C2=A0X= accel 2.1
was quite a long time ago... It is no longer relevant a= nd the original conditions
that caused the lost interrupts are li= kely long gone...

And if they aren't, we'l= l get a reproducible test case to judge what the right workaround
should be.

Warner



If=C2=A0 &qu= ot;10"=C2=A0 in=C2=A0=C2=A0 " atkbd_timeout(), called 10 times pe= r second "
=C2=A0=C2=A0=C2=A0=C2=A0 can = be defined by a control variable ,
then
=C2= =A0=C2=A0=C2=A0=C2=A0 it may not be necessary to remove its call , and
=C2=A0=C2=A0=C2=A0=C2=A0 polling rate may be set with respect to= the suitable needs .


Mehmet Erol Sanliturk






--0000000000009dbb4505d4d06944--