From nobody Wed Feb 09 10:54:55 2022 X-Original-To: current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id C339119A8836 for ; Wed, 9 Feb 2022 10:55:01 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Jtxbm5rDNz3wRf; Wed, 9 Feb 2022 10:55:00 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: by mail-wr1-x42c.google.com with SMTP id s10so3319106wra.5; Wed, 09 Feb 2022 02:55:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references:reply-to :mime-version:content-transfer-encoding; bh=ijrAfdzwxJQ2Xm5cW5RDOtNZeLuIT1LsCFgnJ8qwvWQ=; b=mNgW0ZNn5jQxpSTaMW+L6oWB44etTHQJXa9AUGUAGVYGFY/RqXeEPx7tfd5ntaQ7Q3 vTwSdTZfKMjibNNB+alH8az0TwnPne19gE3cC6TXyH4Po31MbRm6Gxl+dIWAgxUmOcCJ gZ/Ljh7MTz+TIQ23Is7vmuSYjNw6tKzE65GrdismOscIXYKU3MKQtCubK/e/uUtL+TX3 q3c1gDNXC+3wDcL4toCW/grOs6dvNYAg03TdibHYw+MGVJ6r8pQbDVAo9mVI9gUF2Jml Poc363NyNgmvQGLiqWq6E3mSmlivjlmTD6RYMfNQWhSbk3s6E6MZPhnOuxP4MCd4Aa9n 4/Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:reply-to:mime-version:content-transfer-encoding; bh=ijrAfdzwxJQ2Xm5cW5RDOtNZeLuIT1LsCFgnJ8qwvWQ=; b=c1ltYVPKSnqY7PUoigvFBP1Yf7c//snGud5NHFKSElkIA97oCtcgkQGpLU6y0ftvZ4 CvHd3bf/iIlhJIcyrQHH/vDn0uYa8hsQqeewt2IyR/rP1SBqJYNN0E/fKMiuHEZsMrg0 PyiWZjSfm6sz7T61FaBHyYZJSERy8fGjQPDHZxY+w5rm/Zji0zQTD3AMTCJOdDSXqihX M1gr4mq+xi3jTYY24RcnNtDHk3eq3NZPIUJbDhQGRQG2YNWovuilRchSM4Y5BhRLklpD 80nZiST4jJuDXcJt2SvMNlU7pSI/e65291kAAfEPfm1yGBkMVMCH3pKPAg4hGsAQYVWp /RiA== X-Gm-Message-State: AOAM533v4wlOhGlGXjgpDB+XAWLPa5JwxHovtq6bwLmRsOL5mTR5fxgg lPyV3JcFa+bcLlVBQA922vfuPMPx1fg= X-Google-Smtp-Source: ABdhPJzkb6DrdryGeZ4DaOMg5NVim3jbUk8DUkuKibEln6RLwJBoIP6I3/jJQPbQXNlIrS1tgcnpxw== X-Received: by 2002:adf:e5c4:: with SMTP id a4mr719897wrn.441.1644404099751; Wed, 09 Feb 2022 02:54:59 -0800 (PST) Received: from ernst.home (p5b3be0d9.dip0.t-ipconnect.de. [91.59.224.217]) by smtp.gmail.com with ESMTPSA id x7sm15084225wrt.77.2022.02.09.02.54.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Feb 2022 02:54:59 -0800 (PST) Date: Wed, 9 Feb 2022 11:54:55 +0100 From: Gary Jennejohn To: Kristof Provost Cc: current@freebsd.org Subject: Re: test-includes breaks buildworld when WITHOUT_PF is set in src.conf Message-ID: <20220209115455.18d2e064@ernst.home> In-Reply-To: <7E81E26A-1296-4107-8379-53A9F2C0DCE6@FreeBSD.org> References: <20220209105752.2c382ac2@ernst.home> <7E81E26A-1296-4107-8379-53A9F2C0DCE6@FreeBSD.org> Reply-To: gljennjohn@gmail.com X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; amd64-portbld-freebsd14.0) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4Jtxbm5rDNz3wRf X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20210112 header.b=mNgW0ZNn; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of gljennjohn@gmail.com designates 2a00:1450:4864:20::42c as permitted sender) smtp.mailfrom=gljennjohn@gmail.com X-Spamd-Result: default: False [-3.78 / 15.00]; HAS_REPLYTO(0.00)[gljennjohn@gmail.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; REPLYTO_ADDR_EQ_FROM(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; RCPT_COUNT_TWO(0.00)[2]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; NEURAL_HAM_SHORT(-1.00)[-1.000]; RECEIVED_SPAMHAUS_PBL(0.00)[91.59.224.217:received]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.78)[-0.781]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20210112]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; FREEMAIL_REPLYTO(0.00)[gmail.com]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::42c:from]; MLMMJ_DEST(0.00)[current]; RCVD_TLS_ALL(0.00)[] X-ThisMailContainsUnwantedMimeParts: N On Wed, 09 Feb 2022 11:08:44 +0100 Kristof Provost wrote: > On 9 Feb 2022, at 10:57, Gary Jennejohn wrote: > > test-includes uses pf.h when checking usage of pfvar.h. > > > > But, these lines in include/Makefile remove pf.h when WITHOUT_PF is > > set in src.conf: > > > > .if ${MK_PF} != "no" > > INCSGROUPS+= PF > > .endif > > > > This breaks buildworld. The error message: > > > > In file included from net_pfvar.c:1: > > /usr/obj/usr/src/amd64.amd64/tmp/usr/include/net/pfvar.h:65:10: fatal error: > > 'netpfil/pf/pf.h' file not found > > #include > > ^~~~~~~~~~~~~~~~~ > > 1 error generated. > > --- net_pfvar.o --- > > *** [net_pfvar.o] Error code 1 > > > > make[3]: stopped in /usr/src/tools/build/test-includes > > .ERROR_TARGET='net_pfvar.o' > > > > Removing the .if/.endif fixes it for me, although there may be a better > > way to avoid the error. > > > Warner's working on a better fix. See https://reviews.freebsd.org/D34009 for the discussion. > Thanks for the info. -- Gary Jennejohn