From nobody Wed Feb 09 09:57:52 2022 X-Original-To: current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id E89F119AA5B0 for ; Wed, 9 Feb 2022 09:57:59 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JtwKy5hJxz3KNG for ; Wed, 9 Feb 2022 09:57:58 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: by mail-ej1-x62f.google.com with SMTP id fy20so5863002ejc.0 for ; Wed, 09 Feb 2022 01:57:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:subject:message-id:reply-to:mime-version :content-transfer-encoding; bh=B7dckOPEoXEEpLhODyX+6EqF25/yYuIWzq9ZKVb0jxo=; b=WdouUc1mKQsV76r0Ew8Z0hNza2D/3jCu7oKAK4cRFRQFtzMXSdhOV6NMISi3obXOkI uyrum3GLYWX5MtJwSGSnI0q36V7H8ECTT8hhzOfi/d8b52LuDgdAwTrt+z/gbPE6PV06 UfyCIat8c3ZRxf7zr8TOJXCfGlmArkN+C+bYU6iIirVy/klN6CjULgnTpQvowC0AeKPh fZWPjuy3KEoachOY+cF9PfAnOfVA+yYiXU4QBFX5KJo3YqoOmb76tVAnn2NVofJAkICq C6vC2+tkKgJLK6sG4KfIeEw8tlmw6OHEZYUT4ILQT2QeACHHkikfU0ewqemLbYQqotT5 4TIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:reply-to :mime-version:content-transfer-encoding; bh=B7dckOPEoXEEpLhODyX+6EqF25/yYuIWzq9ZKVb0jxo=; b=q/rMXZlbto628k2rZTV/HcHwp3QBcnMIkqnZKBu5tx9zhFeW5SKyr/BRS5zfuCGHHK Dckn9Qo0l0BcB//Ut11y/5wVkYxmL3AY7awkbriEm1bZhwqPaaW/UCYShHQ6P0CJT7kJ obfH//4c79VH7syn7yBK7eV8Hq3IP2mjYrrhOmo6xp9N4aRxLj2fvnrviLRgkBrJVvMb q8aixx2maqdWyL9tPVkKE6AhYT/VigDupNduc9AgeU6Wttlv7wtc/HoYzVK23RT8bzl3 DbauyFHLcoi79HvtJ4luMHO2qiZTIIR/vAij8XFlXbfXnGGCGKsDw2MnikimhwYnJCNI RYlQ== X-Gm-Message-State: AOAM530OT2EzTNH14lxM947RnQEhHdynGmA0qU5KlOEyHpf+8W3lPPBu xtHW4+94UwDrrJ0OsqxRfr3CUHvCA6g= X-Google-Smtp-Source: ABdhPJyN8khKqfJhilt+f67dvAXTiTRptwmB/3rC2i5k7A3pgOtXjeDKVeBNZt6G6KkTxulBsE0flg== X-Received: by 2002:a17:907:7241:: with SMTP id ds1mr1231833ejc.491.1644400677437; Wed, 09 Feb 2022 01:57:57 -0800 (PST) Received: from ernst.home (p5b3be0d9.dip0.t-ipconnect.de. [91.59.224.217]) by smtp.gmail.com with ESMTPSA id e26sm4221356eds.10.2022.02.09.01.57.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Feb 2022 01:57:57 -0800 (PST) Date: Wed, 9 Feb 2022 10:57:52 +0100 From: Gary Jennejohn To: current@freebsd.org Subject: test-includes breaks buildworld when WITHOUT_PF is set in src.conf Message-ID: <20220209105752.2c382ac2@ernst.home> Reply-To: gljennjohn@gmail.com X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; amd64-portbld-freebsd14.0) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4JtwKy5hJxz3KNG X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20210112 header.b=WdouUc1m; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of gljennjohn@gmail.com designates 2a00:1450:4864:20::62f as permitted sender) smtp.mailfrom=gljennjohn@gmail.com X-Spamd-Result: default: False [-3.91 / 15.00]; HAS_REPLYTO(0.00)[gljennjohn@gmail.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; REPLYTO_ADDR_EQ_FROM(0.00)[]; TO_DN_NONE(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.91)[-0.907]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20210112]; RECEIVED_SPAMHAUS_PBL(0.00)[91.59.224.217:received]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; FREEMAIL_REPLYTO(0.00)[gmail.com]; PREVIOUSLY_DELIVERED(0.00)[current@freebsd.org]; RCPT_COUNT_ONE(0.00)[1]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::62f:from]; MLMMJ_DEST(0.00)[current]; RCVD_TLS_ALL(0.00)[] X-ThisMailContainsUnwantedMimeParts: N test-includes uses pf.h when checking usage of pfvar.h. But, these lines in include/Makefile remove pf.h when WITHOUT_PF is set in src.conf: .if ${MK_PF} != "no" INCSGROUPS+= PF .endif This breaks buildworld. The error message: In file included from net_pfvar.c:1: /usr/obj/usr/src/amd64.amd64/tmp/usr/include/net/pfvar.h:65:10: fatal error: 'netpfil/pf/pf.h' file not found #include ^~~~~~~~~~~~~~~~~ 1 error generated. --- net_pfvar.o --- *** [net_pfvar.o] Error code 1 make[3]: stopped in /usr/src/tools/build/test-includes .ERROR_TARGET='net_pfvar.o' Removing the .if/.endif fixes it for me, although there may be a better way to avoid the error. -- Gary Jennejohn