From nobody Fri Oct 22 16:11:56 2021 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 384D3181E503 for ; Fri, 22 Oct 2021 16:12:00 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HbTrJ17b7z4XPw; Fri, 22 Oct 2021 16:12:00 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from aniel.nours.eu (nours.eu [176.31.115.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: bapt) by smtp.freebsd.org (Postfix) with ESMTPSA id E82222C92; Fri, 22 Oct 2021 16:11:59 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from dummy.faircode.eu (10.246.39.62.rev.sfr.net [62.39.246.10]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aniel.nours.eu (Postfix) with ESMTPSA id A96F4E5C1F; Fri, 22 Oct 2021 18:11:57 +0200 (CEST) Date: Fri, 22 Oct 2021 16:11:56 +0000 (UTC) From: Baptiste Daroussin To: John Baldwin Cc: marklmi@yahoo.com, freebsd-current Message-ID: <5df871c1-08ff-4d36-bb11-1a93ce42c5aa@FreeBSD.org> In-Reply-To: References: <5270B5FE-6C3B-4172-A310-AE9A5A1B853A.ref@yahoo.com> <5270B5FE-6C3B-4172-A310-AE9A5A1B853A@yahoo.com> Subject: Re: main changed DIALOG_STATE, DIALOG_VARS, and DIALOG_COLORS but /usr/lib/libdialog.so.? naming was not adjusted? (crashes in releng/13 programs on main [so: 14] can result) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Correlation-ID: <5df871c1-08ff-4d36-bb11-1a93ce42c5aa@FreeBSD.org> X-ThisMailContainsUnwantedMimeParts: N 22 oct. 2021 18:06:56 John Baldwin : > On 10/22/21 1:08 AM, Mark Millard via freebsd-current wrote: >> main [soi: 14] commit a96ef450 (2021-02-26 09:16:49 +0000) >> changed DIALOG_STATE, DIALOG_VARS, and DIALOG_COLORS . >> These are publicly exposed in (ones that I noticed): >> /usr/include/dialog.h:extern DIALOG_STATE dialog_state; >> /usr/include/dialog.h:extern DIALOG_VARS dialog_vars; >> /usr/include/dialog.h:extern DIALOG_COLORS dlg_color_table[]; > > Then we need to bump libdialog's so version to 10?=C2=A0 (I don't > think libdialog has symbol versioning) > > -- > John Baldwin It does not have symbol versionning and yes good catch it needs to be bumpe= d Bapt