From nobody Sun Oct 10 13:57:07 2021 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id A834617E0BA9 for ; Sun, 10 Oct 2021 13:57:19 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-QB1-obe.outbound.protection.outlook.com (mail-eopbgr660058.outbound.protection.outlook.com [40.107.66.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "DigiCert Cloud Services CA-1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HS3QR3VWQz4q7w; Sun, 10 Oct 2021 13:57:19 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bSy/iyFowW1527wzV3HxfhjWWSXTaFzkfKJkUcSRccYIIXKOm8lTaVCGCXjY9aaRWRWdWk1TaMKOjotMQDFqut98dQuEBGrwFX/YGvZWj4rZhuVW9ZSFHXNr6gyoIPM1zns61Y9nWC8YKCoBvvzCUu4ZhJtvqIAfxEzgM+CUbdl3+7eJZkMiGTOXP01/RplL+Z1JC8Z8hWHnem+SahZwPiWArTvge9H2tz9+TwXOZLXu0bGJbsjtpWvGXbUFwRwn/tLtXCYd1VNxZX7CIOlGJKSKitpQbC6l4lc1qhZRV20tZvvYVD25BjoSw2gjWlKRO46V+nCFv9ur5XgDov3p3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=URDXdzAjWv7tXwiW+AdHlWu1F9bG6313oUzYVlOUv9Q=; b=gqTrxYjyK8bdUXr7r2PCLW6vvO14GZJsOBYvmyUOaIJsP/EJKFxRB7q63dZp2ezck9lyCHMiOoUeyM6KgCeGB8meFhb+IALL7z896J9ewtfRXDsnMuZ9mFNda4h2C8QEvJ2R5bvx3Njy44FUXAMbvcMwpvk8IDHWaofDkcjT6UU8mrT96LzsAPL/WQ0g1N4ty2mQLWFuMz9Drnaxec99biIMcBf03AI1bUrKJigfzFVMa4WDuJe+P3J1WffLDl+TD67EZGXyWPlkDXFSEJQNF23LXGv8Hte9rMH1glS4jf9OoXhm85PSdacBAIbEpdUB2lkwlpYJJKSA8a3tczHEzA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=uoguelph.ca; dmarc=pass action=none header.from=uoguelph.ca; dkim=pass header.d=uoguelph.ca; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=uoguelph.ca; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=URDXdzAjWv7tXwiW+AdHlWu1F9bG6313oUzYVlOUv9Q=; b=MFoBr6ZFdd8kWAWmf47CKWDzRoIIXopYGnW84+S0fYzhpzblWBD/ecDZ66rJYFN8R8xcZk35N67LwAveEz6jqHD4J/Qyk+K2CUiMQM0e35EXucW36viYOAOOEE+Q7oZUadHJJPuNjuePIsWCn+qiOiMBOQYbrsBVWfpb6Sn4xjetFb0m7alnv9Grh3CN1EMiM/7A3uIXzN65CHnvlmRjVipxXZAJ7NF3I4pZkeJGagr2uQ5RYQgSP2+URqvYu/xSFEm8+1cti/QgVOVSuaNRou1t2YxWAehcoeQJDGvMXwPPagGo7yb6Ndy/WoNwiunhZWlPl44xcVRmi/dxWRGg0w== Received: from YQXPR0101MB0968.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c00:19::29) by YQBPR0101MB2083.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c00:3::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25; Sun, 10 Oct 2021 13:57:12 +0000 Received: from YQXPR0101MB0968.CANPRD01.PROD.OUTLOOK.COM ([fe80::7091:13ac:171f:1c12]) by YQXPR0101MB0968.CANPRD01.PROD.OUTLOOK.COM ([fe80::7091:13ac:171f:1c12%5]) with mapi id 15.20.4587.025; Sun, 10 Oct 2021 13:57:07 +0000 From: Rick Macklem To: Alan Somers CC: FreeBSD Current Subject: Re: RFC: Use of VOP_ALLOCATE() by NFSV4.2 nfsd Thread-Topic: RFC: Use of VOP_ALLOCATE() by NFSV4.2 nfsd Thread-Index: AQHXvXMbM0Hsf8N9W0qQA3mOobhhb6vLmYKAgAAg6CeAAIXKgIAAAJEb Date: Sun, 10 Oct 2021 13:57:07 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: suggested_attachment_session_id: fe23a23d-f9d1-3069-f846-fc1b8270cad2 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b66c9611-f0bc-49f6-d618-08d98bf5d8dc x-ms-traffictypediagnostic: YQBPR0101MB2083: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: WRmB/FZp6gyPaSPOlzGa0fFd8pc7sDJ/8Nzuq145qq56f9oL9oqS1DCDsPrl5CJaokTigJxS0dAHluxrbtV5/1Du7cuSXr+A9BVWq32/OhZwa1ir8gg4bZI1N1PhuHvlH7vI7drnl2QT9e/YrAvCXwzIxFdFedWCFoleP3u2zdXC2C5kzm+Q2G/Me4vaC1Gy3M+zR6t0cxFYyw/eIfeOejbRdKvlli65icOG6iiWKZOfh9ZBE6gWKJZTOcE/sGB+VoSdzTxM6MbGbTzelvxv/AXmRuf4spBebsrQlrE1ANiJw4gePyUs0QKiBAZS3bm8HZ4XqZ5XfeWLzAHatUW6Ly/RuVusT1zp0NUeWCraedWgps//4Ph3aKpsJOoCOlOr5cQkrvmRAJj7CuUgJ3guYdnOtaj/tniOV8K2itD/azNp7ytcX6EPN1OXVyNItq0XIet+SP0R1uuaos/ArUcd89ILi341+O19f/JK6fcq4/BaI9G5dZFgd4YR8JipuFZaIADYamDFU1qyoMI7eCRpyQNuA67u8mbRJbAOEQ6qjc3f7RNu5nj5/KLPJOOAovmoLDzKD5EgFp4BX+EQE9QO7STZ8Re+G8hifs2SAyROvXAAPKyfRzz38YRFZlj7eUJt9JmX3AvCbuuc9gETehbA4e2RM8g5jn9hbIR6uwGWACv0JZPRa1nI2DfmQS1/GJDLQziqTtaBJsycJU5vYsEhOQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:YQXPR0101MB0968.CANPRD01.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(366004)(38070700005)(33656002)(6506007)(9686003)(66556008)(86362001)(6916009)(66446008)(4326008)(122000001)(38100700002)(7696005)(316002)(786003)(66476007)(8676002)(5660300002)(52536014)(55016002)(2906002)(508600001)(71200400001)(64756008)(76116006)(8936002)(91956017)(66946007)(186003)(450100002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?Qi+wDVwHS/wRzvkjLpVswqnxhY1sfoJ5mxrlKvqEIymVLPPkf6j2uA5TCr?= =?iso-8859-1?Q?JhWDrvpBjLk9zurxdu3ai/trLz8TT+5Kho3CVBXe8iEdRBaa901Nn83Xm0?= =?iso-8859-1?Q?qiEIHLUeRYQmu3GyZcL4zh9/YctzEuDMGy8XSSj2fw728apDI9w18IMtk4?= =?iso-8859-1?Q?ODbzLeDzGrMdt7PW8Gm+gaTsuDZ7OnEfiUAclX7Yp27MkfbWyzA2DLgMjd?= =?iso-8859-1?Q?LmShqTtJlBwVq0btzVnAHOLEUxpZ7zo8TOYGRT8whVxi4Pb2vW4/HOIBAZ?= =?iso-8859-1?Q?8Xfvjtoov7k3Ji+xy6kHcDXFvoeL2dWfB5s4wrqFQ4ZLYno5r0+jo+jpIU?= =?iso-8859-1?Q?xiQ6MTnYE+hS0SctHr3Vxdlr0rfdwy1zGwxjoU8BrubOUQmt3Z5tdvSq/U?= =?iso-8859-1?Q?zZg1rWay+hFagz5PI8e5sfez4anjvscr0RsA5wxxj3GDh4C9/YsFGOA0Dp?= =?iso-8859-1?Q?XklwFgkC/ZYBrGuCr8J+fcg8PosRzkyB8lB5bRF5LDKYo30y50zZOXHOOu?= =?iso-8859-1?Q?K2AQoEHQZLiY/6XXvaeyM7hifl5w8y3Dq0Dm3VX/8GcH4nJKPBaMJAdtWT?= =?iso-8859-1?Q?hFWUoJMyt2x+e16NxGTzDgmmOcqYXdO95v8NpJXgMAJdA0whWKv7/e3309?= =?iso-8859-1?Q?ra9wAqcaskodyPT2UIxnglzh38+VSN+dcfOKWpNxzA749XFtdKGWcSHyMU?= =?iso-8859-1?Q?k1RUtDGPl1x6qMnKVubunto8vHjc7Q0hoQo7OvTVOoCbyCkOjpm2WI54/u?= =?iso-8859-1?Q?oCbQkWlElGPtsqtU5j+7Dy2gOzmQtnNyMLn0uGcwGirbRRqfz71/J+RKK1?= =?iso-8859-1?Q?emsef45ZKcsGLo1M+RhENAgzP/Kk+kj0nGOOHt/AA3m7NYP/7cRbJQJdBu?= =?iso-8859-1?Q?vvTMgJvCiGoCgr+WxNuhXJQwn76vqKaVNir9izuhcWg7XD0RiiNkeG658x?= =?iso-8859-1?Q?S4AIZSfmVnPKx8sVtTC2OYfnmIY/M1D9oFyGAqMM3zKbKflBW8LghtSQ+U?= =?iso-8859-1?Q?n36I8UbyzAdA402w5nSjUradzh4eGfjOSNb8jaQm8Urh1PaEQ/a+R0Gcbx?= =?iso-8859-1?Q?VOXKcwpbgtFU5oLDTV9midij72DJprIfmKJqg7+MmH6JZdutRhhu/kWuvU?= =?iso-8859-1?Q?PHltFlKTqNwmkgrGsv2YnJp2QsK4TMqiNlSYOSDUGJs8xHh4YninRCAYKM?= =?iso-8859-1?Q?kk6+bYKME3u/nVt7ofbZK/oJDtqPc21ReHJhvUT/6yno6Pujed+0yK6dWm?= =?iso-8859-1?Q?al96iTUumrouWIR+NGHxGNze0NHciK+aM37Dmr7cCVlcDiJ5pIqQUjr1qX?= =?iso-8859-1?Q?sn1Kc2USlcSv+Q3WYUVKqGOa60cvRg6/wDlqcfUE+tx54lV/HmPEB1SVDP?= =?iso-8859-1?Q?qDQgrdCmgC7/kmBAuE68H14NVDCNQInBIpIXNs5+Esglp3zdgyWp4=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: YQXPR0101MB0968.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: b66c9611-f0bc-49f6-d618-08d98bf5d8dc X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Oct 2021 13:57:07.0146 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: C7oDStoAzp54P/jbF2HCBg2I6IVkjhOJ4NaJdqU1MVz9c+xxLLySeY0GB7a7cVGuJE5RYQ5ycC8Tfj34hXwxgg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YQBPR0101MB2083 X-Rspamd-Queue-Id: 4HS3QR3VWQz4q7w X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N Alan Somers wrote:=0A= [stuff snipped]=0A= >Rick Macklem wrote:=0A= > >Alan Somers wrote:=0A= > > >Yes. posix_fallocate is supposed to guarantee that subsequent writes= =0A= > > >to the file will not fail with ENOSPC. But ZFS, being a copy-on-write= =0A= > > >file system, cannot possibly guarantee that. See SVN r325320.=0A= > > However, vop_stdallocate() just does VOP_WRITE()s to the area (with=0A= > > bytes of data all zeros). Wouldn't that satisfy the criteria?=0A= >=0A= > No. It works for UFS, which is an overwriting file system. But for=0A= > ZFS, when the user comes back later to rewrite those same offsets, ZFS=0A= > will actually allocate new LBAs for them.=0A= Eighto. I get it now.=0A= =0A= Looks like I must disable it in the server, unless there is a way to enable= =0A= it on a per file system basis (which I don not believe is the case for NFSv= 4.2,=0A= although that isn't completely clear from the RFC, which says each operatio= n=0A= is optional, but does not mention "per file system").=0A= =0A= Thanks everyone, for your replies, rick=0A= =0A= >=0A= > >> - Should I try and support both file system types via vop_stdallocate(= )=0A= > >> or not support Allocate at all?=0A= > >=0A= > >Since you can't possibly support it for ZFS (not to mention other file= =0A= > >systems like fusefs) you'll have to not support it at all.=0A= > It does sound like not supporting it is the best alternative.=0A= >=0A= > rick=0A= >=0A= > >=0A= > > Btw, as a bit of an aside, "cc" uses posix_fallocate() and in weird way= s,=0A= > > such as offset=3D0, len=3D1. Why, I have no idea?=0A= > >=0A= > > Thanks in advance for any comments, rick=0A= > >=0A=