From nobody Wed Dec 22 11:51:45 2021 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id BD02618FEDAB for ; Wed, 22 Dec 2021 11:51:51 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JJs9y5VgSz3khZ for ; Wed, 22 Dec 2021 11:51:50 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: by mail-wr1-x430.google.com with SMTP id s1so4357542wra.6 for ; Wed, 22 Dec 2021 03:51:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references:reply-to :mime-version:content-transfer-encoding; bh=yu+mZ7XWQufe4E1rNWzwAAsQTE4sG1/Bi4iqGg/RzgA=; b=b2s5itMBl3ZBSTPOU8v8ueljgjKHC6TiwQyBNBmZOkXOAdF7ar4xnUZZwili2rzD4L imQBB6SJMFvYddWiyOUZufLjt7lrhRVoOlGZoClx6zHB7ROMkj0yWfyIa4FokjVMnzqN ZyhhTS+zqi8AB9iJ3xLaOlAu16RAPU72qCSeqGJ7ashjV4QaFZgGacVXf8H9fFG4g1xe 3+hzMnHukYUuOxj9iBeAMaeAbZKoXcW/kuF+lR77T3hP1m6ZNM+wbufTswuofNdxf0Bj niaFMnrR5gsRAuqB6M5ieOQAv0CSkmmQZb7a+f5JG1StqxN9NRiAEnCkO5XB1b0U9AeL QDJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:reply-to:mime-version:content-transfer-encoding; bh=yu+mZ7XWQufe4E1rNWzwAAsQTE4sG1/Bi4iqGg/RzgA=; b=O9WjpId+fj5WAtjZUBI1Hqxd052FLJqaKDNViRn5wadlKNGGVBouqc1gp+5GBG5AqV EXbMtqT6KB+Kc70AQNJEBmQ6udR1BQaQ65xT+C4828NDOt4RjQMAm0mHTozqEzSe+au/ L4RhpnXjDhV/XQiivu7dDqrnmCmsIskdQz9d2BefZ7EBy+YDwLoAbnAYaMZ/GpA8NlU0 M1h+OesTJk/r3vz2R3BTTocNXlwNSNV8Uhl4vGTsP3Lkl37bceMb67WH6aSpezmkvPwC 54GXFzpEtFoeupyUNejr3GlZ8xGILNqWs00TeTARlVIWndwLScNhLvCNp6dNpqduDIuP lYEw== X-Gm-Message-State: AOAM532G+doUdQbYILJGDIywdZT0XAnC1Qb0h13J+Q7rOfjoe8ytAMxO ePK5fCnzgQVj62Bu3EEuSwE= X-Google-Smtp-Source: ABdhPJz13c8TVk+Nft+weEuACDMYtgyN+fvv9YmYuw+wKLFNOKRyVYKB7JbdX44Bh6I15SjqDK40+Q== X-Received: by 2002:a05:6000:104f:: with SMTP id c15mr1851743wrx.665.1640173909733; Wed, 22 Dec 2021 03:51:49 -0800 (PST) Received: from ernst.home (p5b3be0d9.dip0.t-ipconnect.de. [91.59.224.217]) by smtp.gmail.com with ESMTPSA id r62sm1542852wmr.35.2021.12.22.03.51.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Dec 2021 03:51:49 -0800 (PST) Date: Wed, 22 Dec 2021 12:51:45 +0100 From: Gary Jennejohn To: Konrad Sewi??o-Jopek Cc: Alastair Hogge , freebsd-current@freebsd.org Subject: Re: WITHOUT_PF breaks buildworld Message-ID: <20211222125145.344d3681@ernst.home> In-Reply-To: <20211222120401.7a9b7817@ernst.home> References: <20211219114723.338b235e@ernst.home> <61bf1204.1c69fb81.2c8fc.3280SMTPIN_ADDED_BROKEN@mx.google.com> <20211219122443.1c84093f@ernst.home> <20211222120401.7a9b7817@ernst.home> Reply-To: gljennjohn@gmail.com X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; amd64-portbld-freebsd14.0) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4JJs9y5VgSz3khZ X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20210112 header.b=b2s5itMB; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of gljennjohn@gmail.com designates 2a00:1450:4864:20::430 as permitted sender) smtp.mailfrom=gljennjohn@gmail.com X-Spamd-Result: default: False [-2.00 / 15.00]; HAS_REPLYTO(0.00)[gljennjohn@gmail.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; REPLYTO_ADDR_EQ_FROM(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20210112]; RECEIVED_SPAMHAUS_PBL(0.00)[91.59.224.217:received]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; NEURAL_SPAM_SHORT(1.00)[1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; FREEMAIL_REPLYTO(0.00)[gmail.com]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::430:from]; RCVD_TLS_ALL(0.00)[] X-ThisMailContainsUnwantedMimeParts: N On Wed, 22 Dec 2021 12:04:01 +0100 Gary Jennejohn wrote: > On Wed, 22 Dec 2021 08:21:35 +0100 > Konrad Sewi??o-Jopek wrote: > > > Hi, > > > > I think the reason is somewhere in tools/build/test-includes: > > > > --- net/if_pfsync.o --- > > In file included from net/if_pfsync.c:1: > > In file included from > > [...]freebsd/arm64.aarch64/tmp/usr/include/net/if_pfsync.h:56: > > [...]freebsd/arm64.aarch64/tmp/usr/include/net/pfvar.h:65:10: fatal error: > > 'netpfil/pf/pf.h' file not found > > #include > > ^~~~~~~~~~~~~~~~~ > > 1 error generated. > > *** [net/if_pfsync.o] Error code 1 > > > > make[3]: stopped in [...]freebsd/tools/build/test-includes > > --- net/pfvar.o --- > > In file included from net/pfvar.c:1: > > [...]freebsd/arm64.aarch64/tmp/usr/include/net/pfvar.h:65:10: fatal error: > > 'netpfil/pf/pf.h' file not found > > #include > > ^~~~~~~~~~~~~~~~~ > > 1 error generated. > > *** [net/pfvar.o] Error code 1 > > > > make[3]: stopped in [...]freebsd/tools/build/test-includes > > 2 errors > > > > make[3]: stopped in [...]freebsd/tools/build/test-includes > > *** [test-includes] Error code 2 > > > > make[2]: stopped in [...]freebsd > > 1 error > > > > Could be. With WITHOUT_PF include/netpfil/pf/pf.h disappears from obj. > But since buildworld still tries to build net/if_pfsync.c and other > pf-related binaries the buildworld fails. > > One would thank the WITHOUT_PF should also block building ALL pf-related > binaries, but that's not the case. > Ah well, pf.h is used in so many places under /usr/src that the best approach might be to simply remove the WITHOUT_PF build option. -- Gary Jennejohn