[Bug 279397] www/chromium sqlite3_shim.c compilation error

From: <bugzilla-noreply_at_freebsd.org>
Date: Fri, 31 May 2024 14:32:51 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=279397

--- Comment #6 from Florian Walpen <dev@submerge.ch> ---
I'm currently experimenting with the internal SQLite of devel/qtcreator, which
is easier to test for me. Appending " && !defined(__FreeBSD__)" to the
exceptions for APPLE and DARWIN works, but I think the correct solution for
upstream should be:

#if defined(_POSIX_C_SOURCE) && !defined(_XOPEN_SOURCE)
#  define _XOPEN_SOURCE 600
#endif

Rationale is that _XOPEN_SOURCE helps to extend an already present restriction
to _POSIX_C_SOURCE with XOPEN features. But SQLite should not impose a
restriction to XOPEN features only when there is no POSIX restriction in
effect, thereby reducing the available feature set (like alloca).

I don't have time to create a chromium patch now, it may be defined in multiple
places due to the amalgamated SQLite source.

-- 
You are receiving this mail because:
You are the assignee for the bug.