[Bug 279397] www/chromium sqlite3_shim.c compilation error

From: <bugzilla-noreply_at_freebsd.org>
Date: Fri, 31 May 2024 12:30:43 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=279397

Florian Walpen <dev@submerge.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pavelivolkov@gmail.com

--- Comment #5 from Florian Walpen <dev@submerge.ch> ---
(In reply to Tatsuki Makino from comment #4)
You're right, I've read that code multiple times before I spotted the #else,
but with _XOPEN_SOURCE defined there is neither __BSD_VISIBLE nor alloca. And
this is correct I think, according to standards _POSIX_C_SOURCE and
_XOPEN_SOURCE actually *restrict* the set of available headers and
functionality. See:

https://pubs.opengroup.org/onlinepubs/007904975/functions/xsh_chap02_02.html

Which means _XOPEN_SOURCE should never be set if non-standard functionality
like alloca (or BSD, GNU extensions) is used.

Add the maintainer of databases/sqlite3 to this discussion, I think
SQLITE_USE_ALLOCA is disabled there as well?

-- 
You are receiving this mail because:
You are the assignee for the bug.