maintainer-feedback requested: [Bug 279397] www/chromium sqlite3_shim.c compilation error

From: <bugzilla-noreply_at_freebsd.org>
Date: Thu, 30 May 2024 10:34:43 UTC
Bugzilla Automation <bugzilla@FreeBSD.org> has asked freebsd-chromium (Nobody)
<chromium@FreeBSD.org> for maintainer-feedback:
Bug 279397: www/chromium sqlite3_shim.c compilation error
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=279397



--- Description ---
I started getting the error compiling chromium 125.0.6422.76_1, which is kept
persistent with update to 125.0.6422.112:
In file included from ../../third_party/sqlite/sqlite3_shim.c:16:
../../third_party/sqlite/src/amalgamation/sqlite3.c:53619:21: error: call to
undeclared function 'alloca'; ISO C99 and later do not support implicit
function declarations [-Wimplicit-function-declaration]
 53619 |     u32 *aiValues = sqlite3StackAllocRaw(0, sizeof(p->u.aHash));
       |		     ^
../../third_party/sqlite/src/amalgamation/sqlite3.c:20536:38: note: expanded
from macro 'sqlite3StackAllocRaw'
 20536 | # define sqlite3StackAllocRaw(D,N)   alloca(N)
       |				      ^
../../third_party/sqlite/src/amalgamation/sqlite3.c:53619:10: error:
incompatible integer to pointer conversion initializing 'u32 *' (aka 'unsigned
int *') with an expression of type 'int' [-Wint-conversion]
 53619 |     u32 *aiValues = sqlite3StackAllocRaw(0, sizeof(p->u.aHash));
       |	  ^	     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
all seemingly related to alloca().

I am not sure when did that started, might be with an update of llvm18.
Even more, I am not sure if this is a local issue or indeed a port's problem.

The poudriere log is attached.