[Bug 280376] www/qt6-webengine: Fix build on head after string.h changes
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Sat, 20 Jul 2024 05:36:53 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=280376
Jason E. Hale <jhale@FreeBSD.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|New |Open
Flags|maintainer-feedback?(kde@Fr |maintainer-feedback+
|eeBSD.org) |
CC| |chromium@FreeBSD.org,
| |jhale@FreeBSD.org,
| |tagattie@FreeBSD.org
--- Comment #1 from Jason E. Hale <jhale@FreeBSD.org> ---
Thanks for the report and patch, but I think the underlying issue is that the
regex in [1] no longer matches after [2], so HAVE_MEMPCPY=1 no longer gets
defined and nasm uses it's own implementation instead. The pattern
"*\*mempcpy*" will match "*mempcpy", but not "*(mempcpy)".
Since all supported versions of FreeBSD have mempcpy(3), we can probably just
remove [1] entirely and that part of the patch in [3], but I haven't tested
that theory yet.
These patches were taken from www/chromium, so it and other chromium-based
ports like www/electron*, will also need reworked. CC'ing maintainers of those
ports.
[1]
https://cgit.freebsd.org/ports/tree/www/qt6-webengine/files/patch-src_3rdparty_chromium_third__party_nasm_BUILD.gn#n9
[2]
https://github.com/freebsd/freebsd-src/commit/0c47b9c211ede221629914ae0c5553586e772109
[3]
https://cgit.freebsd.org/ports/tree/www/qt6-webengine/files/patch-src_3rdparty_chromium_third__party_nasm_config_config-linux.h#n36
--
You are receiving this mail because:
You are on the CC list for the bug.