maintainer-feedback requested: [Bug 278560] www/chromium 124.0.6367.60 on 13.2-RELEASE-p10 compile failure

From: <bugzilla-noreply_at_freebsd.org>
Date: Wed, 24 Apr 2024 00:24:49 UTC
Bugzilla Automation <bugzilla@FreeBSD.org> has asked freebsd-chromium (Nobody)
<chromium@FreeBSD.org> for maintainer-feedback:
Bug 278560: www/chromium 124.0.6367.60 on 13.2-RELEASE-p10 compile failure
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=278560



--- Description ---
../../third_party/ffmpeg/libavutil/thread.h:228:19: error: call to undeclared
function 'pthread_setname_np'; ISO C99 and later do not support implicit
function declarations [-Wimplicit-function-declaration]
  228 |     ret = AVERROR(pthread_setname_np(pthread_self(), name));
      | 		  ^
m../../third_party/ffmpeg/libavutil/thread.h:228:19: note: did you mean
'pthread_set_name_np'?
/usr/include/pthread_np.h:67:6: note: 'pthread_set_name_np' declared here
   67 | void pthread_set_name_np(pthread_t, const char *);
      |      ^
1 error generated.


In short, the problem seems to be that HAVE_PTHREAD_SETNAME_NP was set during
the configuration phase of things instead HAVE_PTHREAD_SET_NAME_NP.  In order
to be able to compile, I changed lines 225 and following of
third_party/ffmpeg/libavutil/thread.h to:

static inline int ff_thread_setname(const char *name)
{
    int ret = 0;

    pthread_set_name_np(pthread_self(), name);

    return ret;
}


Clearly not the right fix!  But I'm testing right now (i.e. for at least the
next couple of hours) to see if it lets me finish the compile.	Perhaps an
expert on the configuration phase can point me in the right direction.