From nobody Thu Sep 07 19:51:27 2023 X-Original-To: chromium@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RhVHN43FTz4sWgj for ; Thu, 7 Sep 2023 19:51:28 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RhVHN0XXqz4M4R for ; Thu, 7 Sep 2023 19:51:28 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1694116288; a=rsa-sha256; cv=none; b=hIOxofyCrBlIY+us6vYYV2CR5OxgHZPLQilWxqOvHAvObCHeDdzd5GmFRCUQswFNBxpGMh R/Io/XOT7WL1rgFvE76PU1TLjDYgUPArrEImDyxpgxLiLx8JJB3TATeJQA3qe6y0Jnd0Yo QuPAoOQCFXZBAhehRkaUwlI9Rivh3F0wkKu6hnoj40SPmrOVk3IVh4V/VYuPFETWoYtwB8 bERFfMYNFyQgUIAQQaykAkj1bMUi5cHMlGzaEp8AR7BbrtLHOBfXsrqChy8Gu9LKeX9EZd 1OxEO7hzPZb6jVEqXoXUH4+Z1PwM/pVq3B+knVrPlwHz4sTbWOnE5sAdQmaZtw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1694116288; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=26qkVAD3vtxawvsyOGUYjUGtqUIZ5VmtI9h3+PP5T+Y=; b=vCcQ4+4TUu8YTdqBT/OTMFqyoQ62Xgb2py3bAak2fKTeJtClqWV7MWBw3nUr44a1DYE84n gtI2TgQKPxzLxUvMKmZ825evlFkU3SEgFSoEDv6eV5mhfXQPYwv2j1feyMWD/JznVM4gFV ECQOG2wjTK30h0hEuVe0ijUNIJYPRvM5Z7tw5q0Os9Ja2daHSD1SxlUeAX+yR2ykFtiuRO D0XN9Y1SWfntYrdAR9OszeCN2XpQwYRTTsVo6jhuOlCkfg1qRT1sG3L4PQVoh41uVDEkWk 3D6TBuJwCH2BoUbmgK3ufu4+CdQseZ4eYhEzIbsJaFLYiMEjws+U/GxJ82BVhQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RhVHM6k9mz1CCB for ; Thu, 7 Sep 2023 19:51:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 387JpR1S039589 for ; Thu, 7 Sep 2023 19:51:27 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 387JpRN0039588 for chromium@FreeBSD.org; Thu, 7 Sep 2023 19:51:27 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" From: bugzilla-noreply@freebsd.org To: chromium@FreeBSD.org Subject: maintainer-feedback requested: [Bug 273625] www/chromium: use base iconv Date: Thu, 07 Sep 2023 19:51:27 +0000 X-Bugzilla-Type: request X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: chromium@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? Message-ID: In-Reply-To: References: X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: FreeBSD-specific Chromium issues List-Archive: https://lists.freebsd.org/archives/freebsd-chromium List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-chromium@freebsd.org MIME-Version: 1.0 Bugzilla Automation has asked freebsd-chromium (Nobo= dy) for maintainer-feedback: Bug 273625: www/chromium: use base iconv https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D273625 --- Description --- The chromium build does ignore USES=3Diconv settings. If converters/libicon= v is installed the header ${LOCALBASE}/include/iconv.h is found before base icon= v.h. Since LIBICONV_PLUG defines from USES/iconv.mk do not affect the chromium b= uild system linking with -liconv was added in commit bfedd5f1f016c. Commit eb0137c80b62d enforced use of converters/libiconv by switching to iconv:wchar_t. However chromium builds successfully without libiconv instal= led when the modification of third_party/maldoca/BUILD.gn is removed. If base i= conv is sufficient for chromium, then third_party/maldoca/BUILD.gn should simply define LIBICONV_PLUG like this: -- cut -- --- third_party/maldoca/BUILD.gn~ 2022-11-20 12:40:52.000000000 +0100 +++ third_party/maldoca/BUILD.gn 2022-11-21 09:48:50.410589000 +0100 @@ -18,6 +18,9 @@ config("maldoca_flags") { config("maldoca_chromium_config") { defines =3D [ "MALDOCA_IN_CHROMIUM" ] + if (is_bsd) { + defines +=3D [ "LIBICONV_PLUG" ] + } } static_library("zlibwrapper") { -- cut -- Whether this approach works on OpenBSD, I do not know. It does work on Free= BSD. Maybe USES=3Diconv should removed completely since it does not work as inte= nded for chromium build.