From nobody Wed Jul 20 18:08:06 2022 X-Original-To: chromium@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Lp3bB4hlgz4WZbd for ; Wed, 20 Jul 2022 18:08:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Lp3bB36Lqz3DV9 for ; Wed, 20 Jul 2022 18:08:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Lp3bB22fjz16gq for ; Wed, 20 Jul 2022 18:08:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 26KI86HD027227 for ; Wed, 20 Jul 2022 18:08:06 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 26KI869f027226 for chromium@FreeBSD.org; Wed, 20 Jul 2022 18:08:06 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: chromium@FreeBSD.org Subject: [Bug 265180] www/chromium: actually use the system-installed ICU Date: Wed, 20 Jul 2022 18:08:06 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: mi@ALDAN.algebra.com X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: chromium@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: resolution bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: FreeBSD-specific Chromium issues List-Archive: https://lists.freebsd.org/archives/freebsd-chromium List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-chromium@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1658340486; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ikz4zTl2u+5/ooWgw01CYqcmCPMhgsB9fnavX3m2a4k=; b=oufip+w5lyKtJPIYFGUX9V5vp8BEO8iswsUTWgdMV3DPt02njGX/5aHkqtsyn55YE6Kijg HX13sl0WIe4o1/N59JtD5/U+Zxn+SOdACV9eF3/6Je69NPhcSRq/MT8doEExXwil3tStgk Mvo140iH3dsnI+m1+0DUa6K5OxfQxg3lRcNGmptSZCGZ1WGcMw19MFeMEHqItMQ8KcM60F juyNNe7+VBC3q/l8fmUDpG4pCtG8TgGRrk/T/5HXFskPzTvZqCm9cQyt8j75XQU/jz+Sav 8jAUdjzxLODiAGSsygOxufQxqbXSXoO4LYngIwkWV7DnhK0EuexXhbmJEm9JqQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1658340486; a=rsa-sha256; cv=none; b=Z+y1elXAADH/a5I5/C+N9OEPDwtpviq3EsV0Wi+pA0EHA1FrBZLrmcu8iLHa5pbXbqzUwg kervQkkyPxzO+7CzmyAMhkRd9OzPnmxmxp1NSk3c5t0kqIl3Bo5Di7hw6qUjzVgWZKyKFu K7KDBMERDSUV2uHzZFgJje9v75aCnTjFKlWCa4kfv5Ekf9V4aRii1rxKaUO10oLhomEe9O E3S42vZLsZ25tiYAyvSKFisrwLEqAHGn2jIvr8nV5ByQIQc3zuCOYaeP+vLoCohnr1TOLy n60+PfMPeIxVM89g8JQlQqPLxfix9Jr3njuOTImKeCdSIZ/u0DCDXxKon+mFBQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D265180 Mikhail T. changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|Closed |Open --- Comment #7 from Mikhail T. --- The committed change is insufficient -- instead of using the headers instal= led by devel/icu, the port still uses the bundled ones. A simple experiment: 1. make patch 2. Edit the ${WRKSRC}/third_party/icu/source/common/unicode/utypes.h to in= sert the line at the beginning: #error Meow-meow 3. make 4. Observe the build failing with: ../../third_party/icu/source/common/unicode/utypes.h:1:2: error: Meow-meow As I mentioned in Comment #5, this -- taking declarations from one source a= nd definitions from another -- is dangerous. Please, consider using my patch -- or some derivative thereof -- instead. --=20 You are receiving this mail because: You are the assignee for the bug.=