maintainer-feedback requested: [Bug 262067] www/chromium: HAVE_MEMPCPY is undefined in third_party/nasm/include/compiler.h

From: <bugzilla-noreply_at_freebsd.org>
Date: Sun, 20 Feb 2022 18:18:01 UTC
Bugzilla Automation <bugzilla@FreeBSD.org> has asked freebsd-chromium (Nobody)
<chromium@FreeBSD.org> for maintainer-feedback:
Bug 262067: www/chromium: HAVE_MEMPCPY is undefined in
third_party/nasm/include/compiler.h
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=262067



--- Description ---
This is on 14.0-CURRENT.
HAVE_MEMPCPY is undefined in third_party/nasm/include/compiler.h, resulting in
messages such as:

In file included from ../../third_party/nasm/asm/directbl.c:6:
In file included from ../../third_party/nasm/asm/directiv.h:9:
In file included from ../../third_party/nasm/include/perfhash.h:37:
../../third_party/nasm/include/compiler.h:249:21: error: static declaration of
'mempcpy' follows non-static declaration
static inline void *mempcpy(void *dst, const void *src, size_t n)
		    ^
/usr/include/string.h:70:7: note: previous declaration is here
void	*mempcpy(void * __restrict, const void * __restrict, size_t);
	 ^
1 error generated.

My crude and simple patch involve commenting out the offending prototype in
third_party/nasm/include/compiler.h. A better patch would be to ensure
HAVE_MEMPCPY is defined all the way.

Log file and patch will be attached soon.