From nobody Tue Jan 21 12:48:36 2025 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Ycn7m2hYbz5l3Xx for ; Tue, 21 Jan 2025 12:48:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Ycn7m1yX6z3qHw for ; Tue, 21 Jan 2025 12:48:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1737463716; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oPbE2vwz4fcUpjc1QcIkEixdtcaHiRBZfW2gPYRkl/Y=; b=mRqb7Wm4uDwIbN4sYQg1Qpc+Le6lWHi/nKrVA9DVWV0pmoVmJdotFMxpwOrT0UfA5Gqqdz vKB+INoemwHzm+nXO9fIGUsaUml9qwV7UaSQBm3KUakw02A2VDiBBSMR83eahCIHGBnjbf ZT54j9pYgO2cSlrEufLgbYJWxt+0STIYhzKBlNmVUCfhnc+yOULeOpy5MFX6bIfMCb74Jm uk8gQ4aE7PeWwROJYjcfap0knlUDXHf5cTiPJ7/iYEqf8X6isRajCGhCNzXDtiFvocsJ1S 69xvUyVJoNwAPuAbRd+DyuQxhQ+MiAVI03BkR1JWqChJeZY/r1n0FI+eszbS6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1737463716; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oPbE2vwz4fcUpjc1QcIkEixdtcaHiRBZfW2gPYRkl/Y=; b=k+mDIQoPSPiOp0mSYHEGJ6Gtm0ZYt9XnPUwKUA2pfRB8P898MV/2nDn6CLpKFUSTyjoZWG UvOU7NxZZDI3qVbX1UzTCGh6QgcpqYRncOs2UemgcJ2Q8ZJ0Nwy5BO2wOjM344Yp8H6M2F iup9R1xH95KK/JfXHmnLmqR6Eistd7n1b1qQid/WdhcSMO9fExttA+XSIlxS1f4bJePH78 ZKASuatEdvS+qOeKLNiNo7vteC3Yl0Qb8Riuz/uv7D+3Q1NbanboeHWiFGQhddJr2hBIK9 VmQ+HovWCF2V8xuTb6SI7pun41MHQhDxp9kz2gd73foL5xH7Zn7N0hfYTc++hg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1737463716; a=rsa-sha256; cv=none; b=VOjD0DDX15fCBRvmOU/fwAIzINFqu/RMkRPvpWqgmUL/KO570Fwgmcf3BMxH5b7XYkpDlh dkoaoSiOSQjnbGC8S+DH+PPjBe4eTDuZofZMDk5YI4nyxTVCGz70yAYVuCp9372pS5ZTfs Y/xFX9z/w7cV7BREzwe+eysFLwlE/O/57xLaHduoOChm13qD49U839VBpaAWoIjiBlrXy1 pXNw5TLN10dj4jVfY3ICUZcvWakD8Ku9d6Xvvgu7tneNc3UTeVTqugUCyVeEWflC2DYGuL heQbeDYmSDYbqlqvtfx+irlL+F5Mka/XTS2c3ZVnPt03p108Td9jMxPyrwX3wg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Ycn7m1Nq4z166p for ; Tue, 21 Jan 2025 12:48:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 50LCma7T037745 for ; Tue, 21 Jan 2025 12:48:36 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 50LCmajs037744 for bugs@FreeBSD.org; Tue, 21 Jan 2025 12:48:36 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 284119] install(1): numeric -o / -g args produce uname and gname in METALOG Date: Tue, 21 Jan 2025 12:48:36 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D284119 --- Comment #1 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D4b04f5d7e8a2bb0488ad5804ecaf45cef= 5b1d46f commit 4b04f5d7e8a2bb0488ad5804ecaf45cef5b1d46f Author: Ed Maste AuthorDate: 2025-01-17 19:14:22 +0000 Commit: Ed Maste CommitDate: 2025-01-21 12:47:48 +0000 install: Fix METALOG ouptut for numeric -o and -g args install's -o and -g flags both accept a name or a numeric argument. In -U -M (non-root METALOG) mode it always emitted uname=3D and gname= =3D in the METALOG, but these are not appropriate for numeric IDs. If the -o and/or -u arguments parse as an ID, emit uid=3D and/or gid=3D respectively. Note that if an argument is valid as both a name and numeric ID we will prefer the name in normal (non -U -M) mode and the ID in -U -M mode. We don't want to require a passwd db in non-root mode, and entirely-numeric user or group names are a terrible idea so just accept this discrepancy. PR: 284119 Reviewed by: jlduran Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D48504 usr.bin/xinstall/xinstall.c | 20 ++++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=