From nobody Wed Feb 05 01:38:38 2025 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YnjYp2rdtz5mr9p for ; Wed, 05 Feb 2025 01:38:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YnjYn68xFz3r71 for ; Wed, 05 Feb 2025 01:38:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1738719517; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U+W/QsJqxbcJIMHcSUtIIkroKuoV3nDNUePTYmmkFIY=; b=kybF4OIf0p5K0byzdDXFfSRs6M8DxN1Vg/BK3TIpQL9SqlFM0mrqG+fWrkggsX8Dyu/mIR qejeLTFLnWTT0VjbCl4/FELW9QaDuaRrNLisx+4AV8z0LyEIaSIVH0Tu7ZuYVY303Rlj79 Bp6UQdieW9WVvoKACCzQj5AhV/W+rhXL5iwQXaBJORupoj2fh520TK5+CqRqm8z5EeMLMv /PFnr11pqen3nRtDBRJl6+Z2VhR/sHTIjIt0fdt2F8RGbiJW6ePpuiSRnRcRzaY78FC6Xz 73CKz6/Dfzgp0RkfSSyZaR527efIBz7e/OvFT7YJOHrJxlfXDmeKk7gdOl2qFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1738719517; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U+W/QsJqxbcJIMHcSUtIIkroKuoV3nDNUePTYmmkFIY=; b=dJHcyqGlY0leEbUWO92UjU3xSNM/UZOKRAgFiKIwyw8Soi1FXNTYwlKO2/SfBT0hQ+c9NI 7dO/Gxn46KG9gTitaRh2Sw9hkcGf2wA+Q9iW31tUfFnA3GkkNGbkUFrQESynLLAtZgG0jj vkw/LboA6jO2tkVqwr3jknWZu8DEC5QdvkcXsA9FVPj+Pp8/m/d1jNHg1BkWOriRwbl81j n12MBYOjpq/fy+aiCsZMNk5R2EzG698oJFRI+rMEiCO0+HyHWDQBs/uEkrV1au7AFJqONQ fZh4NgT5R9lbHOgm6GZ+U6aP79faIEYXaOXh4uxSTE6c9ln/3VKPekpQ9DLxdQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1738719517; a=rsa-sha256; cv=none; b=kNYP+31kIOfQewKB7SpCnDvJDq4V7UA4perwB57xHYgVTSxL84v1jZU+PSrSYqGz24jbBi Pxkt/dCql8YvsM2V6lqxRAsRgTGuWZpECVIGhyRdVfY9GKE1s9EsY24UxED8WXb0pxkC9/ 6+BRgIKHkAuuhSy4RjuhnV0SPZo2ZgDiZciQiLSXbByzM+AbLuBv9a+vHB0HeUS4sFGulE so5F3HH1lTMtOR7Yug9nxeO+2Iu5dqgTna80zjDgjrnf/Ru6HPS2XUHpS+RsZTHU4vBz8y r3ixbF5FY904PozdNZpF9VaswuKeKavG2tjxcpROFWEQv91v9x1kHngNzZe+4g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YnjYn5n0fzXGD for ; Wed, 05 Feb 2025 01:38:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 5151cbmK092880 for ; Wed, 5 Feb 2025 01:38:37 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 5151cbrS092879 for bugs@FreeBSD.org; Wed, 5 Feb 2025 01:38:37 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 191135] [hptrr] probe hptrr INQUIRY CDB: 12 00 00 00 24 00 CAM status: Invalid Target ID Error 22 Date: Wed, 05 Feb 2025 01:38:38 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D191135 --- Comment #4 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3Df52154a2044a4d1f324952af05542f93f= df0a088 commit f52154a2044a4d1f324952af05542f93fdf0a088 Author: Warner Losh AuthorDate: 2025-02-05 01:31:25 +0000 Commit: Warner Losh CommitDate: 2025-02-05 01:38:02 +0000 hptrr: Better error recovery This bug and https://www.mail-archive.com/freebsd-stable@freebsd.org/msg124458.html both have this fix. It turns unknown errors into an autosense failure, which causes us to grab the sense buffer manually. It also sets a condition that we = use to retry timed out commands that jmg reports as being helpful. I'm torn on committing it. The code seems fine in terms of fixing things. But this is a 10-year-old bug with few other bugs and a short CC list for a driver that might go away in 15 anyway. I'm going to commit and close the bug, and MFC it in a week, unless someone complains (which seems unliekly, given the age of this hardware, I susepct most of it is out of service). Suggested by: jmg, Scott Long PR: 191135 MFC After: 1 week Reviewed by: imp sys/dev/hptrr/hptrr_osm_bsd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=