From nobody Sun Feb 02 16:38:24 2025 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YmFgN3Zr7z5mPM4 for ; Sun, 02 Feb 2025 16:38:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YmFgN2szlz3cwQ for ; Sun, 02 Feb 2025 16:38:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1738514304; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GjebZC33icHt2pTVqDPGcjMVuw6SrM9A0o5BG++m3Y4=; b=WuS1DTm/tqY1edU2qDzFK8DX0ZNQrLpW5MVy9EuJE/571oyR2NifNO3RxSabLb7GprM2ll nHoOxwUfOLMR8agvvkqkg7vb+paqTe+/9HOtJ/Z/zk7ZX47zg3paYVzkyLvUfiFnIPblah y4KX4vW2sW2JU2qzoUd6GSTq6qzqjxkaN8r9q9inc2FLC4HfLDE6Wd279RPZH/qzbW3IAO B20gI8nN8hgpXEenY7ck1E31/66CWPXs5ioaH6U69nHC0VQZeUfpXIE8Lnn7Tehf6CXUIq UBPYiD7fc7SutG22BxAWm4QPmOPJKdL1TTc2Q/3+hjrIkMiqpDE5GOglptgHLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1738514304; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GjebZC33icHt2pTVqDPGcjMVuw6SrM9A0o5BG++m3Y4=; b=bj+kBMpF4gf/oZ575IutbCXOrXZHPA0PAvHf9PsfpV9C0o1MwKd53ObP3Zamz9MgSi/A9L q4rJVyA9M6GOzwPtBSjYzT8+rgcr5yfN3sEbTOz0ncOroW+cUMyLj8EZpV3sT0V9308P+4 vQnNUDd+dquWhYbjt1VHO6pddMGQAjrw6SIfrijqT9X6i6b+/W++Fakwz8pKaEcx8GsjUN II6GbqxKYmNa/8RbseLCaqx9TX1J7nv/VNA/L8vHGNkHhYcEowEZ3Qa/NwL1GrtVMf08MS vXnmpe61av2o5H90Po0L32tDg5STGlHIQ9tTLFUBAsWoX2YTn4X3VDqv534p7Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1738514304; a=rsa-sha256; cv=none; b=n55/hRamXdWsjFXCQ8ckXTXA0Cji0HRFpP8vCK4ujNitEcSNHbHxGkNCB9E83gMmB75+FP UOA2MqHo2S0HmnB9xFe8T2VOGiB9w2JxxuCktm1lGNq00L6lxw4nYfuW6ypRQb+TFs1zCm ReKpgVMqbiV2z1PJZQH27uevjNN3iuoIVH/8xkb07QHqKIIGa3KIFI7JKCCiS/i0Yh84ip yHiR2jM7t+FHbrs6td9KzMtES5/nCqwQyZlwminZWjFhYvUxKgf57+2TxxhA+Uv6t6o0K1 n5TRPUnecWcOnUJJihAji1rluFugVTf4WozGJW05j5S81JZzTW/1PvLpC/9pUg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YmFgN2NmNzxpj for ; Sun, 02 Feb 2025 16:38:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 512GcOWL045889 for ; Sun, 2 Feb 2025 16:38:24 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 512GcO0e045888 for bugs@FreeBSD.org; Sun, 2 Feb 2025 16:38:24 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 217745] sys/dev/pms/RefTisa/sallsdk/spc/sampirsp.c: PVS-Studio: Expression is Always True (CWE-571) (2) Date: Sun, 02 Feb 2025 16:38:24 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D217745 --- Comment #1 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3Dead758a67a6b584293cfe02cd6c5cbefb= 6a4926f commit ead758a67a6b584293cfe02cd6c5cbefb6a4926f Author: Svyatoslav AuthorDate: 2025-02-02 16:35:51 +0000 Commit: Warner Losh CommitDate: 2025-02-02 16:35:51 +0000 pms: Fix always true condition Although this is vendor code, and apparently abandoned vendor code at that, this is clearly a mistake and always true. It's unclear how to contribute back to the upstream at this point, alas. PR: 217745 Reviewed by: imp sys/dev/pms/RefTisa/sallsdk/spc/sampirsp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --=20 You are receiving this mail because: You are the assignee for the bug.=