From nobody Thu Sep 12 21:44:59 2024 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4X4WF74Bt4z5WsVN for ; Thu, 12 Sep 2024 21:44:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4X4WF72T2Gz4CqN for ; Thu, 12 Sep 2024 21:44:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1726177499; a=rsa-sha256; cv=none; b=OhB4D6tzcU9sSa39omIuKaWh7nLztvUooE0PtLyxl7fADeaUgKFX5vffNidH8T8K/s+ncf daoSgdGu0+srlvELzXO6BXZcj5DsSghAJXmmQjeSQi3RBMVjk5BbF2Jt0+VDFXQ72kCw4s pjuswU/NZvcUnuLicjLjr3ZNeuzihsoCki6N1NEQybhU+cWaxDlRlQEPXtiSYn/GCNtc00 XULI56RotuG1tFeeDpbh9RRGu/L+WdNcJwCIuvsnCc0JUXisQH/ImIUE1oNK0jA2pScWQ1 b8h2BoUSAtMQSQYdvV7mPR3fajjM+KoX9jHpmcrad8qcjHrh5yKN0FvXRqUTWg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1726177499; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g3HD3PZtat5+mfDaOnpIKTPwMYMNpPjKpvyWgI44hmc=; b=fOAIiJw9fcYsdtXVtxWC6UdnCT8/loLYGXYpVTmMX7z1mzWyUVZbkDePfHE46OVYqKVQWw /IclvmpZGpZNIZ8kTNwSXqckNThihVY/3+1kZ822vlJRwv3h62VgtB2CZIrxICD+zeWEP+ q7qvqkM/GkkoF7AhubJrgR21QZDISqSK5gcnTt2k+b9cstifI1XonCc/B0e8cWNwSSJ11l bPFQqz2SF07winmCxyFmVmekP8Y42rOq+S6Sg4+GOaBBVfV2sqsDtv4n7+s3Km1s5tk55n jrgFBPgFUR79sALEEnwkG1jD9oSp7yONNLRU3Kqo5+VSQJfUkui+KkD+eCFJ2A== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4X4WF71hP2zGXD for ; Thu, 12 Sep 2024 21:44:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 48CLixmJ000132 for ; Thu, 12 Sep 2024 21:44:59 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 48CLiw8r000131 for bugs@FreeBSD.org; Thu, 12 Sep 2024 21:44:58 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 280978] Kernel panics with vfs.nfsd.enable_locallocks=1 and nfs clients doing hdf5 file operations Date: Thu, 12 Sep 2024 21:44:59 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 15.0-CURRENT X-Bugzilla-Keywords: crash X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: rmacklem@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: rmacklem@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: assigned_to bug_status attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D280978 Rick Macklem changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|bugs@FreeBSD.org |rmacklem@FreeBSD.org Status|New |Open --- Comment #3 from Rick Macklem --- Created attachment 253528 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D253528&action= =3Dedit Fix close handling when vfs.nfsd.enable_locallocks=3D1 I think this patch might fix the problem. nfsrv_freeopen() was being called after the mutex lock was released, making it possible for other kernel threads to change the lists while nfsrv_freeopen() took the nfsstateid out of the lists. This patch moves the code around "if (nfsrv_freeopen(stp, vp, 1 p) =3D=3D 0) {" into nfsrv_freeopen(), so that it can remove the nfsstateid structure from all lists before unlocking the mutex. This should avoid any race between CLOSE and other nfsd threads updating the NFSv4 state. The patch does not affect the semantics when vfs.nfsd.enable_locallocks=3D0. If the reporter can test this patch, that would be great. --=20 You are receiving this mail because: You are the assignee for the bug.=