From nobody Mon Oct 28 14:53:10 2024 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Xcbwk3tclz5bRdl for ; Mon, 28 Oct 2024 14:53:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Xcbwk2qSGz4rGC for ; Mon, 28 Oct 2024 14:53:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1730127190; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SqJ+ojnXn8L5rgkxG39wliEDMj7IRis0giCpluuP7w8=; b=ETvrGayiM74gnTBVlLRVzLsyxX4kqtb7cTCx3+bjVn86pqiWQpAvXgb8VuLi21JOYKyNLX 3Rrd/DiXWgBmuwE0adI8rvdOsd4CzP2r3LTZHOKedobZaRuEcFHuL7nBxVLY5/u4IP5YGj BYDyHyv56TSgk1wGjscTjXJYjyYlM1W9pEbED432/SfU5WAkXGp3r93bLvSm1GZ8ylFDAm JyWlj3FZ+sA+qx9QnTCNVIysUBQFvSed8wVhE9kZybdiqYXTszTETFaaH6zAn4xDCGzq8G VtfGz+DEFisFqBbfflWeCpx+2Q/4MIquk7O8VZI1h/SyDW05RWRT1iw8ce5CFg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1730127190; a=rsa-sha256; cv=none; b=XAb2dQU3hqELxYXjaNR3R7+vTUCU4rYkl4GLmwffPpfW4sdap/QWg3co7m9DDXg6Mq224S QNndMny15FxKdg83CaMWfX0jX3y4ZFv3IhM2sKBZdJZA/vAlYLRwUY6gdkUmKl4xqFRwGh AyOAgjO1Iwr0IBGQEwQJFk9hn5Jjo2T+IC/lqu2xbWVvoIC6pJb97+BSQfGS5C1a+Tr/E1 N6m9GYO4WhRjB9tkph7DI9ZVqnZLi17/T1T5ONikcdeYb1bXayJ57oljyYx+3RLPirphNb Ut62i5OTVpBnpXg6eksg0RFuVZH8n0rE/lcp1Cwh03mKMLIkdAPAc11cfdUyNA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Xcbwk2PhHzk0q for ; Mon, 28 Oct 2024 14:53:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 49SErAFm065233 for ; Mon, 28 Oct 2024 14:53:10 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 49SErAhV065232 for bugs@FreeBSD.org; Mon, 28 Oct 2024 14:53:10 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 280290] hms(4): Broken fresh after boot, fixed by resume Date: Mon, 28 Oct 2024 14:53:10 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 15.0-CURRENT X-Bugzilla-Keywords: regression X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: wulf@freebsd.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D280290 --- Comment #34 from Vladimir Kondratyev --- Try this patch (untested): diff --git a/sys/dev/iicbus/iichid.c b/sys/dev/iicbus/iichid.c index 6f0563d4e55..397c0917d43 100644 --- a/sys/dev/iicbus/iichid.c +++ b/sys/dev/iicbus/iichid.c @@ -1250,8 +1250,12 @@ iichid_attach(device_t dev) iichid_detach(dev); } done: - (void)iichid_set_power(sc, I2C_HID_POWER_OFF); - sc->power_on =3D false; + iicbus_request_bus(device_get_parent(dev), dev, IIC_WAIT); + if (!sc->open) { + (void)iichid_set_power(sc, I2C_HID_POWER_OFF); + sc->power_on =3D false; + } + iicbus_release_bus(device_get_parent(dev), dev); return (error); } --=20 You are receiving this mail because: You are the assignee for the bug.=