From nobody Wed Oct 16 14:44:39 2024 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XTDJS4FzRz5YbwH for ; Wed, 16 Oct 2024 14:44:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XTDJS1FN2z4Vk4 for ; Wed, 16 Oct 2024 14:44:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1729089880; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LhxZS1khhihcXA36Bl5XUXqOrQlMqRvhxEqIip7/iVI=; b=Yxj8h9r6Ikk49MZ6FmdnhzhlRhXaP4RE99cXw1TjkXocjFhqto5n9ctGNlLF3Hm9KuAXPU JSLLlWjRgGU2LBEdZbSsGpvjqvqZZNct7c5tc/HMa+kwy+YgYlTGjPRnl1ly24WWXW7Us0 GgHS4huPLRI5mgulV7GapwC1WDNRge4efFG1X6A2r5gzAmjZ09OKbeew8SQH1Qh1MlVls2 6PyoTGSuZQj1SIUphNaM8FHrPLmYOjHc0g2dNwRUPoKQkwGmCWSjz95+YVrpCAtjD/YzM9 qpGDkh7Ies3daKIc13VhgFKxeYVzBOT6z2nZ9occYtd0IAQgP12p2XJLgJkhGw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1729089880; a=rsa-sha256; cv=none; b=UTNWKQYt3JVcnXtY6ja/kF84jnZuOc0GtmCAKMzfR6kWjS8bQ/var0ZtufTwaWO3E5jhVF rjkmLv45Liti0Ou4MQqxiJrcgvob6+ae4rr10Py2kvJyij9iRlVxaYj++HdBaHyEnuYAkS /+Gx8wQjLXPzZKYXFg0AKLy3XStMarbWEoi4ewUUMjgtd4MKgFkOFZ99exFjRcxj9tHwWh W5t+SpI/XqjTrQPRMYMBl/CPX970CDyFrLzsqZ0D1MFQrsq7hcav2tbziLRhvfvO4qJD27 ybZtTEVIO8daLFAXeA3OEq1k/3mGJYGJ6dh+2Wr2zboe81THM/429f9IYjY4hA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XTDJS0Xgbz199g for ; Wed, 16 Oct 2024 14:44:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 49GEiddP091716 for ; Wed, 16 Oct 2024 14:44:39 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 49GEidWV091715 for bugs@FreeBSD.org; Wed, 16 Oct 2024 14:44:39 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 212841] getting panic during mps reinitialization. Date: Wed, 16 Oct 2024 14:44:39 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 9.2-RELEASE X-Bugzilla-Keywords: crash X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: mfc-stable14+ mfc-stable13+ X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D212841 --- Comment #15 from commit-hook@FreeBSD.org --- A commit in branch stable/13 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3De360f8c8fecc78d8f2aa2aee46940ec5e= ca86c87 commit e360f8c8fecc78d8f2aa2aee46940ec5eca86c87 Author: prateek sethi AuthorDate: 2024-10-13 18:38:54 +0000 Commit: Warner Losh CommitDate: 2024-10-16 14:33:33 +0000 mps/mpr: Add workaround for firmware not responding to IOC_FACTS or IOC_INIT Sometimes, especially with older firmware, mps(4) would have trouble initializing the card in one of these two steps. Add in a retry after a short delay. Sean Bruno and Stephen McConnell thought this was OK in the bug discussions, but never committed it. Steve indicated the delay might not be necessary, but the OP clearly needed to make it longer to make things work. I've kept the delay, and added the suggested comment. Ported the iocfacts part to mpr as well, since we see similar errors about once every month or two over a few thousand controllers at work. We've not seen it with IOC_INIT as far back as I can query the error log database, so I didn't port that forward. We'll see if this helps, but won't know for sure until next year (so I'm committing it now since it won't hurt and might help). We usually see this failure in connection with complicated recovery operations with a drive that's failing, though, at least in the last year's worth of failures. It's not clear this is the same as OP or not. PR: 212841 Sponsored by: Netflix Co-authored-by: imp (cherry picked from commit c0e0e530ced057502f51d7a6086857305e08fae0) sys/dev/mpr/mpr.c | 23 ++++++++++++++++++----- sys/dev/mps/mps.c | 38 ++++++++++++++++++++++++++++++-------- 2 files changed, 48 insertions(+), 13 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=