From nobody Mon Oct 14 05:41:56 2024 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XRmM862lCz5ZCxq for ; Mon, 14 Oct 2024 05:41:56 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XRmM83ZZZz42Tk for ; Mon, 14 Oct 2024 05:41:56 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1728884516; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7aj9psZF3t+ruOFnbWr0/Tq3GY+pgf9GzX72A6uyvMs=; b=xK1z/BTIXGjCrpJkQcM4wOu58tqh8y7GHILxymvdrsGxj2A2B3ixAHLXtBIa+tlHa1Z6Wy l/Es+r/bOFuUTHGKpsyA6uuoVjy5AnApANerPW2IFtRZDTNgtOtD/Y4mVmTPsklClvSUIh yt7ktK6JkfD2+cASHYn0fNIwTxfpzqVmp/g2hBxYXhzB1s7WE9JdHn3KOBaYZVCCWALoVb m/MVeC0Q3+5MzeB1wU2LpewmhKE+r2OTAtT0HOuKOFMGSBEarhoLzECC89MLI2v+awIQ27 Et+xtIxb1TeqaDDHnIaF2q9O5B/Yr35T/0WSDacvEHyjAk902ZjOACx3c2pcuw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1728884516; a=rsa-sha256; cv=none; b=VFSiPDmXbZtWSUPxpfcRns2KMF/WJT0BaWQ+SydxIY6rhfMEmpDJRWv22iG4fMTcbfWO4P xkgbftyZ6fv0JSGRwSMKh6u2uVOdbJhEltCWsOb7jG+VES471AAJ6UaoxUavdRzAdeUtWR LugE855bA3YupcXGKNRb0rDgz++M8GouZboO0JpCkqAa9zc0ENSIg53jPQ5sSun1EVHygr mpU/t0mWwU6bYLQaWHz6C60VCn+FcKOzvOjMWInz+Lmi+IGXjkC2V1IPNlIPrZX2Z3wXYu 9DgJwkDNsIoAPFxvOLJKj+PhX0alJ0YEKR5VCBsuzB+CodsMDD6DAnsr6a4jsA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XRmM838QNzQXX for ; Mon, 14 Oct 2024 05:41:56 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 49E5fuVk023041 for ; Mon, 14 Oct 2024 05:41:56 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 49E5fu5d023040 for bugs@FreeBSD.org; Mon, 14 Oct 2024 05:41:56 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 246279] ciss device driver not allowing more than 48 drives to be detected by the CAM layer Date: Mon, 14 Oct 2024 05:41:56 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.4-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D246279 --- Comment #33 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3Db339ab1491055d89415f85b6d1a034231= 93178f9 commit b339ab1491055d89415f85b6d1a03423193178f9 Author: Peter Eriksson AuthorDate: 2024-10-14 04:01:33 +0000 Commit: Warner Losh CommitDate: 2024-10-14 05:37:46 +0000 ciss: Don't panic on null CR ciss_dequeue_notify Apparently, sometimes on hot plug/unplug, a null cr comes back from ciss_dequeue_notify. This is clearly a bug, and by ignoring it we're papering over that bug. We only ever wake the thread after enqueing a notification or setting a bit about killing the thread, so once we check the bit isn't the cause, cr can't be NULL unless something else has dequeued it. Ideally, this would be fixed, rather than papered over, but this makes a very old card somewhat more useable for external enclosures. I suspect it's a race when we set CISS_THREAD_SHUT and another flag (the latter w/o ciss_mtx held), but I don't see it and w/o hardware to reproduce it would be hard to know for sure. PR: 246279 Reviewed by: imp Tested by: Marek Zarychta Differential Revision: https://reviews.freebsd.org/D25155 sys/dev/ciss/ciss.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=