From nobody Fri Oct 11 22:11:45 2024 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XQLSd6TWTz5ZVDM for ; Fri, 11 Oct 2024 22:11:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XQLSd3xx3z4Vxr for ; Fri, 11 Oct 2024 22:11:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1728684705; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AvKuyAmvnCaWkeoqaUk7ZSjX+xZKLQiyZusSY2xZoMo=; b=LZzVLMRVXLW1IZoELzZtf2Py4oliNnWXCCigjC/EtrKJbwklTfSF9Icg+NcMZbhSDm2CCr 7novhvsv+5aQKNwKJ5nGOoaLbWdgH6KZavZ/OefeT/UkVyHBwfZ430HqYva9FtMbL4bvsF EdlrDrVW6nCkJUzvdsDXfKFQr54O+n3gk+bqiO0xrh1BPOFhgKVRAxEcXWiTWOBBJlUQ8G zyRxH4AU569habv+1hiLwuw+us0XTg64FJIjSeMJGrALNMjqzQYTMIMivvt+YRXweQO3ii JMvaqP1vYgm5EoeKfYYEPjP+m3vnIm0dwF1iy3v82Kz+bu1RLt0gwG39QDz/wg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1728684705; a=rsa-sha256; cv=none; b=porlx87Dp09kOCYzV52rPFgkIT+qCS1qbNokZSHTSxR8yCi/Zxx9qPD1urEcwxTNXBd5eO nh77k1lOiMqz/dLsO900NNXDzOKJGlzqKEchXbNCzTUq+sJU3mdMcSVLzuId6b1kgalbsW 70zhvSK0KNaJY5P+xBJ+O9IedVhkmjTj5YvfYu1SxN8hNReJt67sSylhTO/2ltM0Ur8GUu 8Jty9pDZwuGfFVBsBz2iGF+6e7LD4CD/WUWq/fcenN3ZGM9j2Z3fy+wyt1tzGmU/qJtg1d vqOI7EDA6xeEc8p4Y0oZYyZgKPyFNwUv33ZQ0nzpumZkwT12xgh5S26zx7+wkQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XQLSd3MbYz10N3 for ; Fri, 11 Oct 2024 22:11:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 49BMBjmc049907 for ; Fri, 11 Oct 2024 22:11:45 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 49BMBjOV049889 for bugs@FreeBSD.org; Fri, 11 Oct 2024 22:11:45 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 127912] In theory, uncompress(1) may crash and SEGV Date: Fri, 11 Oct 2024 22:11:45 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 1.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D127912 --- Comment #4 from commit-hook@FreeBSD.org --- A commit in branch stable/14 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D03b4f232354ce68fe1cb462038654f652= 7f63579 commit 03b4f232354ce68fe1cb462038654f6527f63579 Author: David Jones AuthorDate: 2024-10-11 15:49:17 +0000 Commit: Warner Losh CommitDate: 2024-10-11 22:11:02 +0000 uncompress: Avoid reading an extra byte When reading the next code in a stream, avoid reading an extra byte if we're going to throw it away. When there's no more bits to extract from the stream, bits will be 0 and we'll mask the read byte with 0 anyway. At worst, this will avoid reading one past the end of gbuf array (which is not possible in well formed streams). PR: 127912 Reviewed by: emaste Differential Revision: https://reviews.freebsd.org/D47041 (cherry picked from commit 818c7b769a4f7d3c8fecc4cf491f4e22ef816eba) usr.bin/compress/zopen.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --=20 You are receiving this mail because: You are the assignee for the bug.=